mirror of
https://github.com/andwati/zitadel.git
synced 2026-10-18 05:52:51 +00:00
Elio BischofandGitHub
b10455b51f
# Which Problems Are Solved - The previous monorepo in monorepo structure for the login app and its related packages was fragmented, complicated and buggy. - The process for building and testing the login container was inconsistent between local development and CI. - Lack of clear documentation as well as easy and reliable ways for non-frontend developers to reproduce and fix failing PR checks locally. # How the Problems Are Solved - Consolidated the login app and its related npm packages by moving the main package to `apps/login/apps/login` and merging `apps/login/packages/integration` and `apps/login/packages/acceptance` into the main `apps/login` package. - Migrated from Docker Compose-based test setups to dev container-based setups, adding support for multiple dev container configurations: - `.devcontainer/base` - `.devcontainer/turbo-lint-unit` - `.devcontainer/turbo-lint-unit-debug` - `.devcontainer/login-integration` - `.devcontainer/login-integration-debug` - Added npm scripts to run the new dev container setups, enabling exact reproduction of GitHub PR checks locally, and updated the pipeline to use these containers. - Cleaned up Dockerfiles and docker-bake.hcl files to only build the production image for the login app. - Cleaned up compose files to focus on dev environments in dev containers. - Updated `CONTRIBUTING.md` with guidance on running and debugging PR checks locally using the new dev container approach. - Introduced separate Dockerfiles for the login app to distinguish between using published client packages and building clients from local protos. - Ensured the login container is always built in the pipeline for use in integration and acceptance tests. - Updated Makefile and GitHub Actions workflows to use `--frozen-lockfile` for installing pnpm packages, ensuring reproducible installs. - Disabled GitHub release creation by the changeset action. - Refactored the `/build` directory structure for clarity and maintainability. - Added a `clean` command to `docks/package.json`. - Experimentally added `knip` to the `zitadel-client` package for improved linting of dependencies and exports. # Additional Changes - Fixed Makefile commands for consistency and reliability. - Improved the structure and clarity of the `/build` directory to support seamless integration of the login build. - Enhanced documentation and developer experience for running and debugging CI checks locally. # Additional Context - See updated `CONTRIBUTING.md` for new local development and debugging instructions. - These changes are a prerequisite for further improvements to the CI pipeline and local development workflow. - Closes #10276
71 lines
2.0 KiB
YAML
71 lines
2.0 KiB
YAML
name: Login Container
|
|
|
|
on:
|
|
workflow_call:
|
|
inputs:
|
|
login_build_image_name:
|
|
description: 'The image repository name of the standalone login image'
|
|
type: string
|
|
required: true
|
|
node_version:
|
|
required: true
|
|
type: string
|
|
outputs:
|
|
login_build_image:
|
|
description: 'The full image tag of the standalone login image'
|
|
value: '${{ inputs.login_build_image_name }}:${{ github.sha }}'
|
|
secrets:
|
|
DEPOT_TOKEN:
|
|
required: true
|
|
|
|
permissions:
|
|
packages: write
|
|
|
|
env:
|
|
default_labels: |
|
|
org.opencontainers.image.documentation=https://zitadel.com/docs
|
|
org.opencontainers.image.vendor=CAOS AG
|
|
org.opencontainers.image.licenses=MIT
|
|
|
|
jobs:
|
|
login-container:
|
|
name: Build Login Container
|
|
runs-on: depot-ubuntu-22.04-8
|
|
permissions:
|
|
packages: write
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- uses: depot/setup-action@v1
|
|
- name: Login meta
|
|
id: login-meta
|
|
uses: docker/metadata-action@v5
|
|
with:
|
|
images: ${{ inputs.login_build_image_name }}
|
|
labels: ${{ env.default_labels}}
|
|
annotations: |
|
|
manifest:org.opencontainers.image.licenses=MIT
|
|
tags: |
|
|
type=sha,prefix=,suffix=,format=long
|
|
- name: Login to Docker registry
|
|
uses: docker/login-action@v3
|
|
with:
|
|
registry: ghcr.io
|
|
username: ${{ github.actor }}
|
|
password: ${{ secrets.GITHUB_TOKEN }}
|
|
- name: Bake login multi-arch
|
|
uses: depot/bake-action@v1
|
|
env:
|
|
DEPOT_TOKEN: ${{ secrets.DEPOT_TOKEN }}
|
|
NODE_VERSION: ${{ inputs.node_version }}
|
|
with:
|
|
push: true
|
|
provenance: true
|
|
sbom: true
|
|
targets: login-standalone
|
|
project: w47wkxzdtw
|
|
files: |
|
|
./apps/login/docker-bake.hcl
|
|
./apps/login/docker-bake-release.hcl
|
|
./docker-bake.hcl
|
|
cwd://${{ steps.login-meta.outputs.bake-file }}
|