mirror of
https://github.com/andwati/zitadel.git
synced 2026-10-18 05:52:51 +00:00
6082e59d47
# Which Problems Are Solved - The eventstore did not support intentionally overwriting the resource owner when creating events for aggregates that may be reused across owners. - Resource owner handling was implicit and could not be controlled per command/event type. - We needed a safe way to distinguish between: - keeping the existing aggregate owner, and - explicitly setting a new owner for specific create-like events. # How the Problems Are Solved - Introduced a new eventstore command type with an explicit enforce_owner flag. - Updated eventstore.commands_to_events and eventstore.push so owner assignment is now explicit: - if enforce_owner is true, the command owner is written - if enforce_owner is false, the existing aggregate owner is retained when present - Added EnforceResourceOwnerCommand and wiring so command types can opt in to enforced owner behavior. - Wired the new behavior through the v3 eventstore push path, including compatibility fallback for older command type mapping. - Added migration/setup changes to register and use the new command type and SQL functions. - Added and updated tests for owner overwrite and aggregate ID reuse scenarios. # Additional Changes - Added small migration/setup robustness improvements related to eventstore setup ordering and helper reuse. - Added focused test coverage for enforced owner behavior and sequencing. - Events that currently allow owner changes (implement EnforceResourceOwner) are: - AddedEvent (action) - GroupAddedEvent - StartedEvent (idp intent) - ProjectAddedEvent - HumanAddedEvent - HumanRegisteredEvent - MachineAddedEvent - CreatedEvent (schema user) # Additional Context - Follow-up for eventstore owner-handling correctness in create flows and aggregate ID reuse cases. - No additional issue link was attached for this change. --------- Co-authored-by: abhishek kumar gupta <[email protected]>
60 lines
1.5 KiB
Go
60 lines
1.5 KiB
Go
package eventstore
|
|
|
|
import (
|
|
"time"
|
|
)
|
|
|
|
// WriteModel is the minimum representation of a command side write model.
|
|
// It implements a basic reducer
|
|
// it's purpose is to reduce events to create new ones
|
|
type WriteModel struct {
|
|
AggregateID string `json:"-"`
|
|
ProcessedSequence uint64 `json:"-"`
|
|
Events []Event `json:"-"`
|
|
ResourceOwner string `json:"-"`
|
|
InstanceID string `json:"-"`
|
|
ChangeDate time.Time `json:"-"`
|
|
}
|
|
|
|
// AppendEvents adds all the events to the read model.
|
|
// The function doesn't compute the new state of the read model
|
|
func (rm *WriteModel) AppendEvents(events ...Event) {
|
|
rm.Events = append(rm.Events, events...)
|
|
}
|
|
|
|
// Reduce is the basic implementation of reducer
|
|
// If this function is extended the extending function should be the last step
|
|
func (wm *WriteModel) Reduce() error {
|
|
if len(wm.Events) == 0 {
|
|
return nil
|
|
}
|
|
|
|
latestEvent := wm.Events[len(wm.Events)-1]
|
|
if wm.AggregateID == "" {
|
|
wm.AggregateID = latestEvent.Aggregate().ID
|
|
}
|
|
|
|
if wm.ResourceOwner == "" {
|
|
wm.ResourceOwner = latestEvent.Aggregate().ResourceOwner
|
|
}
|
|
|
|
for _, event := range wm.Events {
|
|
if _, ok := event.(EnforceResourceOwnerCommand); ok {
|
|
wm.ResourceOwner = event.Aggregate().ResourceOwner
|
|
}
|
|
}
|
|
|
|
if wm.InstanceID == "" {
|
|
wm.InstanceID = latestEvent.Aggregate().InstanceID
|
|
}
|
|
|
|
wm.ProcessedSequence = latestEvent.Sequence()
|
|
wm.ChangeDate = latestEvent.CreatedAt()
|
|
|
|
// all events processed and not needed anymore
|
|
wm.Events = nil
|
|
wm.Events = []Event{}
|
|
|
|
return nil
|
|
}
|