andwati/telecom-platform
1
0
Fork 0
mirror of https://github.com/andwati/telecom-platform.git synced 2026-10-24 13:42:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: Replace unwrap_or with proper error handling in credit_management

Browse Source 
- Replace unwrap_or(0) with map_err for get operation in deduct_credit
- Replace unwrap_or(0) with ? operator in check_credit
- Add RedisOperation error mapping for current_balance retrieval
This commit is contained in:
nutcas3
2026-04-25 03:02:36 +03:00
parent 40e9d1f221
commit 3c5878d3cc
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/charging-engine/src/charging/credit_management.rs
+3 -2
View File
@@ -38,7 +38,8 @@ impl crate::charging::ChargingEngine {
let key = format!("credit:{}", ip);
// Check current balance first
let current_balance: u64 = redis::AsyncCommands::get(&mut conn, &key).await.unwrap_or(0);
let current_balance: u64 = redis::AsyncCommands::get(&mut conn, &key).await
.map_err(|e| crate::errors::ChargingError::RedisOperation(e.to_string()))?;
if current_balance < bytes_used {
return Err(ChargingError::InsufficientCredit {
@@ -55,7 +56,7 @@ impl crate::charging::ChargingEngine {
}
pub async fn check_credit(&self, ip: &str, bytes_requested: u64) -> ChargingResult<bool> {
let current_balance = self.get_balance(ip).await.unwrap_or(0);
let current_balance = self.get_balance(ip).await?;
Ok(current_balance >= bytes_requested)
}