Files
zitadel/backend/v3/domain/org_deactivate_test.go
T
Marco A.andGitHub 2793abf1e3 chore(domain): Assert errors using ErrorIS for instance and organization tests (#11789)
# Which Problems Are Solved

This is a small refactoring for tests in `backend/v3/domain` package to
use `assert.ErrorIs` instead of `assert.Equal` for error assertion.

# How the Problems Are Solved

  - Add custom `Is()` function to `MultipleObjectsUpdatedError` error
- Substitute `assert.Equal` with `assert.ErrorIs` in instance and
organization tests

# Additional Context

This was part of #11035
2026-03-06 19:20:54 +01:00

235 lines
6.8 KiB
Go

package domain_test
import (
"context"
"errors"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.uber.org/mock/gomock"
"github.com/zitadel/zitadel/backend/v3/domain"
domainmock "github.com/zitadel/zitadel/backend/v3/domain/mock"
"github.com/zitadel/zitadel/backend/v3/storage/database"
"github.com/zitadel/zitadel/backend/v3/storage/database/dbmock"
noopdb "github.com/zitadel/zitadel/backend/v3/storage/database/dialect/noop"
"github.com/zitadel/zitadel/internal/api/authz"
"github.com/zitadel/zitadel/internal/eventstore"
"github.com/zitadel/zitadel/internal/repository/org"
"github.com/zitadel/zitadel/internal/zerrors"
)
func TestDeactivateOrgCommand_Events(t *testing.T) {
t.Parallel()
// Given
expected := []eventstore.Command{org.NewOrgDeactivatedEvent(context.Background(), &org.NewAggregate("some-id").Aggregate)}
deactivateCmd := domain.NewDeactivateOrgCommand("some-id")
// Test
actual, err := deactivateCmd.Events(context.Background(), &domain.InvokeOpts{})
// Verify
require.NoError(t, err)
assert.Equal(t, expected, actual)
}
func TestDeactivateOrgCommand_Validate(t *testing.T) {
t.Parallel()
getErr := errors.New("get error")
tt := []struct {
testName string
orgRepo func(ctrl *gomock.Controller) domain.OrganizationRepository
inputOrgID string
expectedError error
}{
{
testName: "empty org id",
expectedError: zerrors.ThrowInvalidArgument(nil, "DOM-Qc3T1r", "invalid organization ID"),
},
{
testName: "whitespace org id",
inputOrgID: " ",
expectedError: zerrors.ThrowInvalidArgument(nil, "DOM-Qc3T1r", "invalid organization ID"),
},
{
testName: "when retrieving org fails with generic error should return error",
orgRepo: func(ctrl *gomock.Controller) domain.OrganizationRepository {
repo := domainmock.NewOrgRepo(ctrl)
repo.EXPECT().
Get(gomock.Any(), gomock.Any(), dbmock.QueryOptions(
database.WithCondition(
repo.PrimaryKeyCondition("instance-1", "org-1"),
))).
Times(1).
Return(nil, getErr)
return repo
},
inputOrgID: "org-1",
expectedError: getErr,
},
{
testName: "when retrieving org fails with not found error should return not found error",
orgRepo: func(ctrl *gomock.Controller) domain.OrganizationRepository {
repo := domainmock.NewOrgRepo(ctrl)
repo.EXPECT().
Get(gomock.Any(), gomock.Any(), dbmock.QueryOptions(
database.WithCondition(
repo.PrimaryKeyCondition("instance-1", "org-1"),
))).
Times(1).
Return(nil, database.NewNoRowFoundError(getErr))
return repo
},
inputOrgID: "org-1",
expectedError: zerrors.ThrowNotFound(database.NewNoRowFoundError(getErr), "DOM-QEjfpz", "Errors.Org.NotFound"),
},
{
testName: "when org state is inactive should return already inactive error",
orgRepo: func(ctrl *gomock.Controller) domain.OrganizationRepository {
repo := domainmock.NewOrgRepo(ctrl)
repo.EXPECT().
Get(gomock.Any(), gomock.Any(), dbmock.QueryOptions(database.WithCondition(
repo.PrimaryKeyCondition("instance-1", "org-1"),
))).
Times(1).
Return(&domain.Organization{
ID: "org-1",
State: domain.OrgStateInactive,
}, nil)
return repo
},
inputOrgID: "org-1",
expectedError: zerrors.ThrowPreconditionFailed(nil, "DOM-Z2dzsT", "Errors.Org.AlreadyDeactivated"),
},
}
for _, tc := range tt {
t.Run(tc.testName, func(t *testing.T) {
t.Parallel()
ctx := authz.NewMockContext("instance-1", "", "")
ctrl := gomock.NewController(t)
cmd := domain.NewDeactivateOrgCommand(tc.inputOrgID)
opts := &domain.InvokeOpts{}
domain.WithQueryExecutor(new(noopdb.Pool))(opts)
if tc.orgRepo != nil {
domain.WithOrganizationRepo(tc.orgRepo(ctrl))(opts)
}
// Test
err := cmd.Validate(ctx, opts)
// Verify
assert.ErrorIs(t, err, tc.expectedError)
})
}
}
func TestDeactivateOrgCommand_Execute(t *testing.T) {
t.Parallel()
updateErr := errors.New("update error")
tt := []struct {
testName string
queryExecutor func(ctrl *gomock.Controller) database.QueryExecutor
orgRepo func(ctrl *gomock.Controller) domain.OrganizationRepository
inputID string
expectedError error
}{
{
testName: "when org update fails should return error",
orgRepo: func(ctrl *gomock.Controller) domain.OrganizationRepository {
repo := domainmock.NewOrgRepo(ctrl)
repo.EXPECT().
Update(gomock.Any(), gomock.Any(),
repo.PrimaryKeyCondition("instance-1", "org-1"),
repo.SetState(domain.OrgStateInactive),
).
Times(1).
Return(int64(0), updateErr)
return repo
},
inputID: "org-1",
expectedError: updateErr,
},
{
testName: "when org update returns 0 rows updated should return not found error",
inputID: "org-1",
orgRepo: func(ctrl *gomock.Controller) domain.OrganizationRepository {
repo := domainmock.NewOrgRepo(ctrl)
repo.EXPECT().
Update(gomock.Any(), gomock.Any(),
repo.PrimaryKeyCondition("instance-1", "org-1"),
repo.SetState(domain.OrgStateInactive)).
Times(1).
Return(int64(0), nil)
return repo
},
expectedError: zerrors.ThrowNotFound(nil, "DOM-vWPy7D", "Errors.Org.NotFound"),
},
{
testName: "when org update returns more than 1 row updated should return internal error",
orgRepo: func(ctrl *gomock.Controller) domain.OrganizationRepository {
repo := domainmock.NewOrgRepo(ctrl)
repo.EXPECT().
Update(gomock.Any(), gomock.Any(),
repo.PrimaryKeyCondition("instance-1", "org-1"),
repo.SetState(domain.OrgStateInactive)).
Times(1).
Return(int64(2), nil)
return repo
},
inputID: "org-1",
expectedError: zerrors.ThrowInternal(domain.NewMultipleObjectsUpdatedError(1, 2), "DOM-dXl1kJ", "unexpected number of rows updated"),
},
{
testName: "when org update returns 1 row updated should return no error",
orgRepo: func(ctrl *gomock.Controller) domain.OrganizationRepository {
repo := domainmock.NewOrgRepo(ctrl)
repo.EXPECT().
Update(gomock.Any(), gomock.Any(),
repo.PrimaryKeyCondition("instance-1", "org-1"),
repo.SetState(domain.OrgStateInactive)).
Times(1).
Return(int64(1), nil)
return repo
},
inputID: "org-1",
},
}
for _, tc := range tt {
t.Run(tc.testName, func(t *testing.T) {
t.Parallel()
// Given
ctx := authz.NewMockContext("instance-1", "", "")
ctrl := gomock.NewController(t)
cmd := &domain.DeactivateOrgCommand{
ID: tc.inputID,
}
opts := &domain.InvokeOpts{}
domain.WithQueryExecutor(new(noopdb.Pool))(opts)
if tc.orgRepo != nil {
domain.WithOrganizationRepo(tc.orgRepo(ctrl))(opts)
}
if tc.queryExecutor != nil {
domain.WithQueryExecutor(tc.queryExecutor(ctrl))(opts)
}
// Test
err := opts.Invoke(ctx, cmd)
// Verify
assert.ErrorIs(t, err, tc.expectedError)
})
}
}