mirror of
https://github.com/andwati/zitadel.git
synced 2026-10-26 09:12:16 +00:00
# Which Problems Are Solved - The previous monorepo in monorepo structure for the login app and its related packages was fragmented, complicated and buggy. - The process for building and testing the login container was inconsistent between local development and CI. - Lack of clear documentation as well as easy and reliable ways for non-frontend developers to reproduce and fix failing PR checks locally. # How the Problems Are Solved - Consolidated the login app and its related npm packages by moving the main package to `apps/login/apps/login` and merging `apps/login/packages/integration` and `apps/login/packages/acceptance` into the main `apps/login` package. - Migrated from Docker Compose-based test setups to dev container-based setups, adding support for multiple dev container configurations: - `.devcontainer/base` - `.devcontainer/turbo-lint-unit` - `.devcontainer/turbo-lint-unit-debug` - `.devcontainer/login-integration` - `.devcontainer/login-integration-debug` - Added npm scripts to run the new dev container setups, enabling exact reproduction of GitHub PR checks locally, and updated the pipeline to use these containers. - Cleaned up Dockerfiles and docker-bake.hcl files to only build the production image for the login app. - Cleaned up compose files to focus on dev environments in dev containers. - Updated `CONTRIBUTING.md` with guidance on running and debugging PR checks locally using the new dev container approach. - Introduced separate Dockerfiles for the login app to distinguish between using published client packages and building clients from local protos. - Ensured the login container is always built in the pipeline for use in integration and acceptance tests. - Updated Makefile and GitHub Actions workflows to use `--frozen-lockfile` for installing pnpm packages, ensuring reproducible installs. - Disabled GitHub release creation by the changeset action. - Refactored the `/build` directory structure for clarity and maintainability. - Added a `clean` command to `docks/package.json`. - Experimentally added `knip` to the `zitadel-client` package for improved linting of dependencies and exports. # Additional Changes - Fixed Makefile commands for consistency and reliability. - Improved the structure and clarity of the `/build` directory to support seamless integration of the login build. - Enhanced documentation and developer experience for running and debugging CI checks locally. # Additional Context - See updated `CONTRIBUTING.md` for new local development and debugging instructions. - These changes are a prerequisite for further improvements to the CI pipeline and local development workflow. - Closes #10276
68 lines
1.9 KiB
TypeScript
68 lines
1.9 KiB
TypeScript
import { Int32Value } from "@bufbuild/protobuf/wkt";
|
|
import { compileService } from "@bufbuild/protocompile";
|
|
import { createRouterTransport, HandlerContext } from "@connectrpc/connect";
|
|
import { describe, expect, test, vitest } from "vitest";
|
|
import { NewAuthorizationBearerInterceptor } from "./interceptors.js";
|
|
|
|
const TestService = compileService(`
|
|
syntax = "proto3";
|
|
package handwritten;
|
|
service TestService {
|
|
rpc Unary(Int32Value) returns (StringValue);
|
|
}
|
|
message Int32Value {
|
|
int32 value = 1;
|
|
}
|
|
message StringValue {
|
|
string value = 1;
|
|
}
|
|
`);
|
|
|
|
describe("NewAuthorizationBearerInterceptor", () => {
|
|
const transport = {
|
|
interceptors: [NewAuthorizationBearerInterceptor("mytoken")],
|
|
};
|
|
|
|
test("injects the authorization token", async () => {
|
|
const handler = vitest.fn((request: Int32Value, _context: HandlerContext) => {
|
|
return { value: request.value.toString() };
|
|
});
|
|
|
|
const service = createRouterTransport(
|
|
({ rpc }) => {
|
|
rpc(TestService.method.unary, handler);
|
|
},
|
|
{ transport },
|
|
);
|
|
|
|
await service.unary(TestService.method.unary, undefined, undefined, {}, { value: 9001 });
|
|
|
|
expect(handler).toBeCalled();
|
|
expect(handler.mock.calls[0][1].requestHeader.get("Authorization")).toBe("Bearer mytoken");
|
|
});
|
|
|
|
test("do not overwrite the previous authorization token", async () => {
|
|
const handler = vitest.fn((request: Int32Value, _context: HandlerContext) => {
|
|
return { value: request.value.toString() };
|
|
});
|
|
|
|
const service = createRouterTransport(
|
|
({ rpc }) => {
|
|
rpc(TestService.method.unary, handler);
|
|
},
|
|
{ transport },
|
|
);
|
|
|
|
await service.unary(
|
|
TestService.method.unary,
|
|
undefined,
|
|
undefined,
|
|
{ Authorization: "Bearer somethingelse" },
|
|
{ value: 9001 },
|
|
);
|
|
|
|
expect(handler).toBeCalled();
|
|
expect(handler.mock.calls[0][1].requestHeader.get("Authorization")).toBe("Bearer somethingelse");
|
|
});
|
|
});
|