Files
zitadel/internal/query/projection/instance_domain_relational_test.go
T
de1cab9976 refactor: merge relational table projections into one handler (#11740)
## Problem description

During tests we found concurrency issues in the relational table
projections. Tests got flaky if a table (e.g. organization domains) had
too many foreign keys to tables which were projected by another handler.

## Resolution

The projections of the relational tables got merged into one handler to
enforce sequential reduction of events.

## Additional info

- closes https://github.com/zitadel/zitadel/issues/11703
- closes https://github.com/zitadel/zitadel/issues/10810

---------

Co-authored-by: Marco Ardizzone <[email protected]>
2026-03-10 17:01:46 +00:00

205 lines
6.2 KiB
Go

package projection
import (
"testing"
"time"
"github.com/brianvoe/gofakeit/v6"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/zitadel/zitadel/backend/v3/domain"
"github.com/zitadel/zitadel/backend/v3/storage/database"
"github.com/zitadel/zitadel/backend/v3/storage/database/repository"
"github.com/zitadel/zitadel/internal/repository/instance"
)
func TestInstanceDomainReducers(t *testing.T) {
handler := &relationalTablesProjection{}
rawTx, tx := getTransactions(t)
t.Cleanup(func() {
require.NoError(t, rawTx.Rollback())
})
ctx := t.Context()
instanceDomainRepo := repository.InstanceDomainRepository()
instanceRepo := repository.InstanceRepository()
err := instanceRepo.Create(ctx, tx, &domain.Instance{
ID: "123",
Name: "my instance",
DefaultOrgID: gofakeit.UUID(),
IAMProjectID: gofakeit.UUID(),
ConsoleClientID: gofakeit.UUID(),
ConsoleAppID: gofakeit.UUID(),
DefaultLanguage: gofakeit.LanguageAbbreviation(),
CreatedAt: time.Now(),
UpdatedAt: time.Now(),
})
require.NoError(t, err)
t.Run("'custom domain added' reducer should create custom domain", func(t *testing.T) {
// Given
domainName := "test-domain.com"
domainAddedEvt := instance.NewDomainAddedEvent(ctx, &instance.NewAggregate("123").Aggregate, domainName, false)
// Test
res := callReduce(t, ctx, rawTx, handler, domainAddedEvt)
require.True(t, res)
// Verify
domain, err := instanceDomainRepo.Get(ctx, tx,
database.WithCondition(
database.And(
instanceDomainRepo.InstanceIDCondition("123"),
instanceDomainRepo.DomainCondition(database.TextOperationEqual, domainName),
instanceDomainRepo.TypeCondition(domain.DomainTypeCustom),
),
),
)
require.NoError(t, err)
assert.Equal(t, domainName, domain.Domain)
assert.Equal(t, "123", domain.InstanceID)
require.NotNil(t, domain.IsPrimary)
assert.False(t, *domain.IsPrimary)
assert.NotZero(t, domain.CreatedAt)
assert.NotZero(t, domain.UpdatedAt)
})
t.Run("'primary domain set' reducer should update existing domain", func(t *testing.T) {
// Given
domainName := "test-domain-primary-set.com"
err := instanceDomainRepo.Add(ctx, tx, &domain.AddInstanceDomain{
InstanceID: "123",
Domain: domainName,
Type: domain.DomainTypeCustom,
CreatedAt: time.Now(),
UpdatedAt: time.Now(),
IsPrimary: new(bool),
IsGenerated: new(bool),
})
require.NoError(t, err)
domainPrimarySetEvt := instance.NewDomainPrimarySetEvent(ctx, &instance.NewAggregate("123").Aggregate, domainName)
// Test
res := callReduce(t, ctx, rawTx, handler, domainPrimarySetEvt)
require.True(t, res)
// Verify
domain, err := instanceDomainRepo.Get(ctx, tx,
database.WithCondition(
database.And(
instanceDomainRepo.InstanceIDCondition("123"),
instanceDomainRepo.DomainCondition(database.TextOperationEqual, domainName),
instanceDomainRepo.TypeCondition(domain.DomainTypeCustom),
instanceDomainRepo.IsPrimaryCondition(true),
),
),
)
require.NoError(t, err)
assert.Equal(t, domainName, domain.Domain)
assert.Equal(t, "123", domain.InstanceID)
require.NotNil(t, domain.IsPrimary)
assert.True(t, *domain.IsPrimary)
assert.NotZero(t, domain.CreatedAt)
assert.NotZero(t, domain.UpdatedAt)
})
t.Run("'custom domain removed' reducer should remove custom domain", func(t *testing.T) {
// Given
domainName := "test-domain-removed.com"
err := instanceDomainRepo.Add(ctx, tx, &domain.AddInstanceDomain{
InstanceID: "123",
Domain: domainName,
Type: domain.DomainTypeCustom,
CreatedAt: time.Now(),
UpdatedAt: time.Now(),
IsPrimary: new(bool),
IsGenerated: new(bool),
})
require.NoError(t, err)
domainRemovedEvt := instance.NewDomainRemovedEvent(ctx, &instance.NewAggregate("123").Aggregate, domainName)
// Test
res := callReduce(t, ctx, rawTx, handler, domainRemovedEvt)
require.True(t, res)
// Verify
_, err = instanceDomainRepo.Get(ctx, tx,
database.WithCondition(
database.And(
instanceDomainRepo.InstanceIDCondition("123"),
instanceDomainRepo.DomainCondition(database.TextOperationEqual, domainName),
instanceDomainRepo.TypeCondition(domain.DomainTypeCustom),
),
),
)
require.Error(t, err)
assert.ErrorIs(t, err, &database.NoRowFoundError{})
})
t.Run("'trusted domain added' reducer should create trusted domain", func(t *testing.T) {
// Given
domainName := "trusted-test-domain.com"
trustedDomainAddedEvt := instance.NewTrustedDomainAddedEvent(ctx, &instance.NewAggregate("123").Aggregate, domainName)
// Test
res := callReduce(t, ctx, rawTx, handler, trustedDomainAddedEvt)
require.True(t, res)
// Verify
domain, err := instanceDomainRepo.Get(ctx, tx,
database.WithCondition(
database.And(
instanceDomainRepo.InstanceIDCondition("123"),
instanceDomainRepo.DomainCondition(database.TextOperationEqual, domainName),
instanceDomainRepo.TypeCondition(domain.DomainTypeTrusted),
),
),
)
require.NoError(t, err)
assert.Equal(t, domainName, domain.Domain)
assert.Equal(t, "123", domain.InstanceID)
assert.NotZero(t, domain.CreatedAt)
assert.NotZero(t, domain.UpdatedAt)
})
t.Run("'trusted domain removed' reducer should remove trusted domain", func(t *testing.T) {
// Given
domainName := "test-trusted-domain-removed.com"
err := instanceDomainRepo.Add(ctx, tx, &domain.AddInstanceDomain{
InstanceID: "123",
Domain: domainName,
Type: domain.DomainTypeTrusted,
CreatedAt: time.Now(),
UpdatedAt: time.Now(),
})
require.NoError(t, err)
trustedDomainRemovedEvt := instance.NewTrustedDomainRemovedEvent(ctx, &instance.NewAggregate("123").Aggregate, domainName)
// Test
res := callReduce(t, ctx, rawTx, handler, trustedDomainRemovedEvt)
require.True(t, res)
// Verify
_, err = instanceDomainRepo.Get(ctx, tx,
database.WithCondition(
database.And(
instanceDomainRepo.InstanceIDCondition("123"),
instanceDomainRepo.DomainCondition(database.TextOperationEqual, domainName),
instanceDomainRepo.TypeCondition(domain.DomainTypeTrusted),
),
),
)
require.Error(t, err)
assert.ErrorIs(t, err, &database.NoRowFoundError{})
})
}