zitadel/internal/api/grpc/admin/idp_converter_test.go

package admin

import (
	"testing"

	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"

	"github.com/zitadel/zitadel/internal/command"
	"github.com/zitadel/zitadel/internal/repository/idp"
	"github.com/zitadel/zitadel/internal/test"
	admin_pb "github.com/zitadel/zitadel/pkg/grpc/admin"
	idp_pb "github.com/zitadel/zitadel/pkg/grpc/idp"
)

func Test_addOIDCIDPRequestToDomain(t *testing.T) {
	type args struct {
		req *admin_pb.AddOIDCIDPRequest
	}
	tests := []struct {
		name string
		args args
	}{
		{
			name: "all fields filled",
			args: args{
				req: &admin_pb.AddOIDCIDPRequest{
					Name:               "ZITADEL",
					StylingType:        idp_pb.IDPStylingType_STYLING_TYPE_GOOGLE,
					ClientId:           "test1234",
					ClientSecret:       "test4321",
					Issuer:             "zitadel.ch",
					Scopes:             []string{"email", "profile"},
					DisplayNameMapping: idp_pb.OIDCMappingField_OIDC_MAPPING_FIELD_EMAIL,
					UsernameMapping:    idp_pb.OIDCMappingField_OIDC_MAPPING_FIELD_PREFERRED_USERNAME,
					AutoRegister:       true,
				},
			},
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			got := addOIDCIDPRequestToDomain(tt.args.req)
			test.AssertFieldsMapped(t, got,
				"ObjectRoot",
				"OIDCConfig.ClientSecret",
				"OIDCConfig.ObjectRoot",
				"OIDCConfig.IDPConfigID",
				"IDPConfigID",
				"State",
				"OIDCConfig.AuthorizationEndpoint",
				"OIDCConfig.TokenEndpoint",
				"Type",
				"JWTConfig",
			)
		})
	}
}

func Test_addOIDCIDPRequestToDomainOIDCIDPConfig(t *testing.T) {
	type args struct {
		req *admin_pb.AddOIDCIDPRequest
	}
	tests := []struct {
		name string
		args args
	}{
		{
			name: "all fields filled",
			args: args{
				req: &admin_pb.AddOIDCIDPRequest{
					ClientId:           "test1234",
					ClientSecret:       "test4321",
					Issuer:             "zitadel.ch",
					Scopes:             []string{"email", "profile"},
					DisplayNameMapping: idp_pb.OIDCMappingField_OIDC_MAPPING_FIELD_EMAIL,
					UsernameMapping:    idp_pb.OIDCMappingField_OIDC_MAPPING_FIELD_PREFERRED_USERNAME,
				},
			},
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			got := addOIDCIDPRequestToDomainOIDCIDPConfig(tt.args.req)
			test.AssertFieldsMapped(t, got,
				"ObjectRoot",
				"ClientSecret",
				"IDPConfigID",
				"AuthorizationEndpoint",
				"TokenEndpoint",
			)
		})
	}
}

func Test_updateIDPToDomain(t *testing.T) {
	type args struct {
		req *admin_pb.UpdateIDPRequest
	}
	tests := []struct {
		name string
		args args
	}{
		{
			name: "all fields filled",
			args: args{
				req: &admin_pb.UpdateIDPRequest{
					IdpId:        "13523",
					Name:         "new name",
					StylingType:  idp_pb.IDPStylingType_STYLING_TYPE_GOOGLE,
					AutoRegister: true,
				},
			},
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			got := updateIDPToDomain(tt.args.req)
			test.AssertFieldsMapped(t, got,
				"ObjectRoot",
				"OIDCConfig",
				"JWTConfig",
				"State",
				"Type",
			)
		})
	}
}

func Test_updateOIDCConfigToDomain(t *testing.T) {
	type args struct {
		req *admin_pb.UpdateIDPOIDCConfigRequest
	}
	tests := []struct {
		name string
		args args
	}{
		{
			name: "all fields filled",
			args: args{
				req: &admin_pb.UpdateIDPOIDCConfigRequest{
					IdpId:              "4208",
					Issuer:             "zitadel.ch",
					ClientId:           "ZITEADEL",
					ClientSecret:       "i'm so secret",
					Scopes:             []string{"profile"},
					DisplayNameMapping: idp_pb.OIDCMappingField_OIDC_MAPPING_FIELD_EMAIL,
					UsernameMapping:    idp_pb.OIDCMappingField_OIDC_MAPPING_FIELD_PREFERRED_USERNAME,
				},
			},
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			got := updateOIDCConfigToDomain(tt.args.req)
			test.AssertFieldsMapped(t, got,
				"ObjectRoot",
				"ClientSecret",
				"AuthorizationEndpoint",
				"TokenEndpoint",
			)
		})
	}
}

func Test_signatureAlgorithmToCommand(t *testing.T) {
	t.Parallel()
	tests := []struct {
		name                   string
		signatureAlgorithm     idp_pb.SAMLSignatureAlgorithm
		wantSignatureAlgorithm string
	}{
		{
			name:                   "signature algorithm default value",
			signatureAlgorithm:     11,
			wantSignatureAlgorithm: "",
		},
		{
			name:                   "RSA_SHA1",
			signatureAlgorithm:     idp_pb.SAMLSignatureAlgorithm_SAML_SIGNATURE_RSA_SHA1,
			wantSignatureAlgorithm: "http://www.w3.org/2000/09/xmldsig#rsa-sha1",
		},
		{
			name:                   "RSA_SHA256",
			signatureAlgorithm:     idp_pb.SAMLSignatureAlgorithm_SAML_SIGNATURE_RSA_SHA256,
			wantSignatureAlgorithm: "http://www.w3.org/2001/04/xmldsig-more#rsa-sha256",
		},
		{
			name:                   "RSA_SHA512",
			signatureAlgorithm:     idp_pb.SAMLSignatureAlgorithm_SAML_SIGNATURE_RSA_SHA512,
			wantSignatureAlgorithm: "http://www.w3.org/2001/04/xmldsig-more#rsa-sha512",
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			t.Parallel()
			got := signatureAlgorithmToCommand(tt.signatureAlgorithm)
			require.Equal(t, tt.wantSignatureAlgorithm, got)
		})
	}
}

func Test_addZitadelProviderToCommand(t *testing.T) {
	t.Parallel()
	tests := []struct {
		name string
		req  *admin_pb.AddZitadelProviderRequest
		want command.ZitadelProvider
	}{
		{
			name: "without instance roles info",
			req: &admin_pb.AddZitadelProviderRequest{
				Name:         "Zitadel Support IdP",
				ClientId:     "test-client",
				ClientSecret: "test-secret",
				Scopes:       []string{"email", "profile", "urn:zitadel:iam:org:project:roles"},
				ProviderOptions: &idp_pb.Options{
					IsLinkingAllowed:  false,
					IsCreationAllowed: true,
					IsAutoCreation:    false,
					IsAutoUpdate:      true,
					AutoLinking:       0,
				},
			},
			want: command.ZitadelProvider{
				Name:         "Zitadel Support IdP",
				ClientID:     "test-client",
				ClientSecret: "test-secret",
				Scopes:       []string{"email", "profile", "urn:zitadel:iam:org:project:roles"},
				IDPOptions: idp.Options{
					IsCreationAllowed: true,
					IsAutoCreation:    false,
					IsLinkingAllowed:  false,
					IsAutoUpdate:      true,
				},
				InstanceRolesInfo: []idp.RolesInfo{},
			},
		},
		{
			name: "all fields filled",
			req: &admin_pb.AddZitadelProviderRequest{
				Name:         "Zitadel Support IdP",
				ClientId:     "test-client",
				ClientSecret: "test-secret",
				Scopes:       []string{"email", "profile", "urn:zitadel:iam:org:project:roles"},
				ProviderOptions: &idp_pb.Options{
					IsLinkingAllowed:  false,
					IsCreationAllowed: true,
					IsAutoCreation:    false,
					IsAutoUpdate:      true,
					AutoLinking:       0,
				},
				InstanceRolesInfo: []*idp_pb.InstanceRolesInfo{
					{
						OrganizationId:     "org1",
						OrganizationDomain: "org1.com",
					},
					{

						OrganizationId:     "org2",
						OrganizationDomain: "org2.com",
					},
				},
			},
			want: command.ZitadelProvider{
				Name:         "Zitadel Support IdP",
				ClientID:     "test-client",
				ClientSecret: "test-secret",
				Scopes:       []string{"email", "profile", "urn:zitadel:iam:org:project:roles"},
				IDPOptions: idp.Options{
					IsCreationAllowed: true,
					IsAutoCreation:    false,
					IsLinkingAllowed:  false,
					IsAutoUpdate:      true,
				},
				InstanceRolesInfo: []idp.RolesInfo{
					{
						OrganizationID:     "org1",
						OrganizationDomain: "org1.com",
					},
					{
						OrganizationID:     "org2",
						OrganizationDomain: "org2.com",
					},
				},
			},
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			t.Parallel()
			got := addZitadelProviderToCommand(tt.req)
			assert.Equal(t, tt.want, got)
		})
	}
}