mirror of
https://github.com/andwati/zitadel.git
synced 2026-10-28 18:12:16 +00:00
c4221a9c0f
This pull request refactors the command execution and transaction handling logic within the `domain` package. The primary goal is to simplify the invoker chain, clarify transaction management, and improve the overall structure for better maintainability and readability. ### Key Changes: - **Simplified Invoker Chain**: The previous chain of invokers has been refactored. A new `transactionInvoker` is introduced to explicitly manage database transactions for commands that require them. This responsibility is no longer spread across different parts of the invocation flow. - **`Transactional` Interface**: A new `Transactional` interface has been introduced. Commands that need to run within a database transaction now implement this interface. This provides a clear and explicit contract for transactional operations. - **Consolidated Transaction Logic**: The logic for starting, committing, and rolling back transactions is now centralized within the `transactionInvoker` and the `eventStoreInvoker`. The `EnsureTx` method on `InvokeOpts` has been removed, and transaction handling is now managed automatically by the invocation framework. - **Improved Event Handling**: The `eventStoreInvoker` and its `eventCollector` have been rewritten to be more robust and to correctly handle nested and batched commands, ensuring that all events are collected and published within the same transaction. - **Code Cleanup**: A significant amount of now-unused code, including the old `invoker_test.go`, has been removed. Various comments and variable declarations have also been cleaned up. - **Updated Command Implementations**: All commands in the `domain` package (e.g., `ActivateOrgCommand`, `DeactivateOrgCommand`, `DeleteOrgCommand`, `UpdateOrgCommand`) have been updated to use the new `Transactional` interface where appropriate, removing manual transaction management. - **Enhanced Testing**: Tests have been added and updated to cover the new transaction and event handling logic, ensuring the refactoring is sound. - **Use `PrimaryKeyCondition`**: Use the `repository.PrimaryKeyCondition(...)` method instead of using `database.And(...)` where possible. These changes lead to a cleaner, more decoupled architecture for command handling in ZITADEL. --------- Co-authored-by: Marco A. <[email protected]>
53 lines
1.6 KiB
Go
53 lines
1.6 KiB
Go
// Code generated by MockGen. DO NOT EDIT.
|
|
// Source: github.com/zitadel/zitadel/backend/v3/domain (interfaces: Transactional)
|
|
//
|
|
// Generated by this command:
|
|
//
|
|
// mockgen -destination=mock/transactional.mock.go -package=domainmock . Transactional
|
|
//
|
|
|
|
// Package domainmock is a generated GoMock package.
|
|
package domainmock
|
|
|
|
import (
|
|
reflect "reflect"
|
|
|
|
gomock "go.uber.org/mock/gomock"
|
|
)
|
|
|
|
// MockTransactional is a mock of Transactional interface.
|
|
type MockTransactional struct {
|
|
ctrl *gomock.Controller
|
|
recorder *MockTransactionalMockRecorder
|
|
isgomock struct{}
|
|
}
|
|
|
|
// MockTransactionalMockRecorder is the mock recorder for MockTransactional.
|
|
type MockTransactionalMockRecorder struct {
|
|
mock *MockTransactional
|
|
}
|
|
|
|
// NewMockTransactional creates a new mock instance.
|
|
func NewMockTransactional(ctrl *gomock.Controller) *MockTransactional {
|
|
mock := &MockTransactional{ctrl: ctrl}
|
|
mock.recorder = &MockTransactionalMockRecorder{mock}
|
|
return mock
|
|
}
|
|
|
|
// EXPECT returns an object that allows the caller to indicate expected use.
|
|
func (m *MockTransactional) EXPECT() *MockTransactionalMockRecorder {
|
|
return m.recorder
|
|
}
|
|
|
|
// RequiresTransaction mocks base method.
|
|
func (m *MockTransactional) RequiresTransaction() {
|
|
m.ctrl.T.Helper()
|
|
m.ctrl.Call(m, "RequiresTransaction")
|
|
}
|
|
|
|
// RequiresTransaction indicates an expected call of RequiresTransaction.
|
|
func (mr *MockTransactionalMockRecorder) RequiresTransaction() *gomock.Call {
|
|
mr.mock.ctrl.T.Helper()
|
|
return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "RequiresTransaction", reflect.TypeOf((*MockTransactional)(nil).RequiresTransaction))
|
|
}
|