mirror of
https://github.com/andwati/zitadel.git
synced 2026-10-18 05:52:51 +00:00
Elio BischofandGitHub
b10455b51f
# Which Problems Are Solved - The previous monorepo in monorepo structure for the login app and its related packages was fragmented, complicated and buggy. - The process for building and testing the login container was inconsistent between local development and CI. - Lack of clear documentation as well as easy and reliable ways for non-frontend developers to reproduce and fix failing PR checks locally. # How the Problems Are Solved - Consolidated the login app and its related npm packages by moving the main package to `apps/login/apps/login` and merging `apps/login/packages/integration` and `apps/login/packages/acceptance` into the main `apps/login` package. - Migrated from Docker Compose-based test setups to dev container-based setups, adding support for multiple dev container configurations: - `.devcontainer/base` - `.devcontainer/turbo-lint-unit` - `.devcontainer/turbo-lint-unit-debug` - `.devcontainer/login-integration` - `.devcontainer/login-integration-debug` - Added npm scripts to run the new dev container setups, enabling exact reproduction of GitHub PR checks locally, and updated the pipeline to use these containers. - Cleaned up Dockerfiles and docker-bake.hcl files to only build the production image for the login app. - Cleaned up compose files to focus on dev environments in dev containers. - Updated `CONTRIBUTING.md` with guidance on running and debugging PR checks locally using the new dev container approach. - Introduced separate Dockerfiles for the login app to distinguish between using published client packages and building clients from local protos. - Ensured the login container is always built in the pipeline for use in integration and acceptance tests. - Updated Makefile and GitHub Actions workflows to use `--frozen-lockfile` for installing pnpm packages, ensuring reproducible installs. - Disabled GitHub release creation by the changeset action. - Refactored the `/build` directory structure for clarity and maintainability. - Added a `clean` command to `docks/package.json`. - Experimentally added `knip` to the `zitadel-client` package for improved linting of dependencies and exports. # Additional Changes - Fixed Makefile commands for consistency and reliability. - Improved the structure and clarity of the `/build` directory to support seamless integration of the login build. - Enhanced documentation and developer experience for running and debugging CI checks locally. # Additional Context - See updated `CONTRIBUTING.md` for new local development and debugging instructions. - These changes are a prerequisite for further improvements to the CI pipeline and local development workflow. - Closes #10276
85 lines
2.3 KiB
YAML
85 lines
2.3 KiB
YAML
name: Lint
|
|
|
|
on:
|
|
workflow_call:
|
|
inputs:
|
|
node_version:
|
|
required: true
|
|
type: string
|
|
buf_version:
|
|
required: true
|
|
type: string
|
|
go_lint_version:
|
|
required: true
|
|
type: string
|
|
core_cache_key:
|
|
required: true
|
|
type: string
|
|
core_cache_path:
|
|
required: true
|
|
type: string
|
|
|
|
jobs:
|
|
lint-skip:
|
|
name: lint skip
|
|
runs-on: ubuntu-latest
|
|
if: ${{ github.event_name != 'pull_request' }}
|
|
steps:
|
|
- name: Lint skip
|
|
run: |
|
|
echo "Linting outside of pull requests is skipped"
|
|
|
|
api:
|
|
name: api
|
|
runs-on: ubuntu-latest
|
|
continue-on-error: true
|
|
if: ${{ github.event_name == 'pull_request' }}
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- uses: bufbuild/buf-setup-action@v1
|
|
with:
|
|
version: ${{ inputs.buf_version }}
|
|
github_token: ${{ secrets.GITHUB_TOKEN }}
|
|
- name: lint
|
|
uses: bufbuild/buf-lint-action@v1
|
|
- uses: bufbuild/buf-breaking-action@v1
|
|
with:
|
|
against: "https://github.com/${{ github.repository }}.git#branch=${{ github.base_ref }}"
|
|
|
|
turbo-lint-unit:
|
|
if: ${{ github.event_name == 'pull_request' }}
|
|
name: turbo-lint-unit
|
|
runs-on: depot-ubuntu-22.04-8
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
- name: Run lint and unit tests in dev container
|
|
uses: devcontainers/[email protected]
|
|
with:
|
|
push: never
|
|
configFile: .devcontainer/turbo-lint-unit/devcontainer.json
|
|
runCmd: echo "Successfully ran lint and unit tests in dev container postStartCommand"
|
|
|
|
core:
|
|
name: core
|
|
runs-on: ubuntu-latest
|
|
if: ${{ github.event_name == 'pull_request' }}
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
- uses: actions/setup-go@v5
|
|
with:
|
|
go-version-file: "go.mod"
|
|
- uses: actions/cache/restore@v4
|
|
timeout-minutes: 1
|
|
name: restore core
|
|
with:
|
|
path: ${{ inputs.core_cache_path }}
|
|
key: ${{ inputs.core_cache_key }}
|
|
fail-on-cache-miss: true
|
|
- uses: golangci/golangci-lint-action@v6
|
|
with:
|
|
version: ${{ inputs.go_lint_version }}
|
|
github-token: ${{ github.token }}
|
|
only-new-issues: true
|