mirror of
https://github.com/andwati/zitadel.git
synced 2026-10-24 16:22:16 +00:00
5beeb5738a
<!-- Please inform yourself about the contribution guidelines on submitting a PR here: https://github.com/zitadel/zitadel/blob/main/CONTRIBUTING.md#submit-a-pull-request-pr. Take note of how PR/commit titles should be written and replace the template texts in the sections below. Don't remove any of the sections. It is important that the commit history clearly shows what is changed and why. Important: By submitting a contribution you agree to the terms from our Licensing Policy as described here: https://github.com/zitadel/zitadel/blob/main/LICENSING.md#community-contributions. --> One-time recovery codes are a common multi-factor authentication (MFA) backup method, letting users access their account if they lose other MFA devices. Support for recovery codes can also reduce support burden for users locked out of their accounts and provide a more secure and reliable form of verification than security questions. # Which Problems Are Solved Zitadel currently lacks support for recovery codes. # How the Problems Are Solved This PR partially addresses recovery code support in Zitadel. Importantly, it adds recovery codes as a new 2FA `Factor` and an additional `Check` type for the Session API. ``` Example recovery code flow: 1. User generates N new recovery codes using `POST /v2/users/{user_id}/recovery_codes` 2. Zitadel hashes and stores these codes and returns the un-hashed codes in the response 3. User creates new session with an additional check: `recoveryCode` 4. Code is checked against hash and, if valid, cannot be used again 5. User attempts to adds N more codes using the same endpoint 6. If `remaining_codes + N <= RecoveryCodes->MaxCount` config value, then recovery codes are added in addition to original codes 7. User can remove all recovery codes using `DEL /v2/users/:userId/recovery_codes` ``` This PR adds: - [x] Session recovery_code check support on `POST+PATCH /v2/sessions` endpoints - [x] Adds `mfa_recovery_code_checked_at` column (default null) to `projections.sessions8` table - [x] Support for `SECOND_FACTOR_TYPE_RECOVERY_CODES` as available 2FA method on login policy - [x] Support for importing recovery codes in /import code Missing, will _not_ implement in this PR: - [ ] Admin console support for displaying Recovery Code settings for user(s) - [ ] Zitadel Typescript login support for recovery codes TODO: - [x] Additional unit and integration tests - [x] Error translations # Additional Changes None # Additional Context - Closes #6898 --------- Co-authored-by: Livio Spring <[email protected]>
86 lines
2.0 KiB
Go
86 lines
2.0 KiB
Go
package systemdefaults
|
|
|
|
import (
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/zitadel/zitadel/internal/crypto"
|
|
"github.com/zitadel/zitadel/internal/domain"
|
|
)
|
|
|
|
type SystemDefaults struct {
|
|
SecretGenerators SecretGenerators
|
|
PasswordHasher crypto.HashConfig
|
|
SecretHasher crypto.HashConfig
|
|
Multifactors MultifactorConfig
|
|
Tarpit TarpitConfig
|
|
DomainVerification DomainVerification
|
|
Notifications Notifications
|
|
KeyConfig KeyConfig
|
|
DefaultQueryLimit uint64
|
|
MaxQueryLimit uint64
|
|
MaxIdPIntentLifetime time.Duration
|
|
}
|
|
|
|
func (s SystemDefaults) Validate() error {
|
|
// NB: currently we only validate the recovery codes config,
|
|
// but we may want to add more validations in the future or refactor
|
|
return s.Multifactors.RecoveryCodes.Validate()
|
|
}
|
|
|
|
type SecretGenerators struct {
|
|
MachineKeySize uint32
|
|
ApplicationKeySize uint32
|
|
}
|
|
|
|
type MultifactorConfig struct {
|
|
OTP OTPConfig
|
|
RecoveryCodes RecoveryCodesConfig
|
|
}
|
|
|
|
type OTPConfig struct {
|
|
Issuer string
|
|
}
|
|
|
|
type RecoveryCodesConfig struct {
|
|
MaxCount int
|
|
Format string
|
|
Length int
|
|
WithHyphen bool
|
|
}
|
|
|
|
func (r RecoveryCodesConfig) Validate() error {
|
|
if r.MaxCount < 1 || r.MaxCount > 100 {
|
|
return fmt.Errorf("RecoveryCodes.MaxCount must be between 1 and 100, got %d", r.MaxCount)
|
|
}
|
|
|
|
switch r.Format {
|
|
case string(domain.RecoveryCodeFormatUUID):
|
|
// pass
|
|
case string(domain.RecoveryCodeFormatAlphanumeric):
|
|
if r.Length < 8 || r.Length > 60 {
|
|
return fmt.Errorf("RecoveryCodes.Length must be between 8 and 60 for alphanumeric format, got %d", r.Length)
|
|
}
|
|
default:
|
|
return fmt.Errorf("RecoveryCodes.Format must be 'uuid' or 'alphanumeric', got '%s'", r.Format)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
type DomainVerification struct {
|
|
VerificationGenerator crypto.GeneratorConfig
|
|
}
|
|
|
|
type Notifications struct {
|
|
FileSystemPath string
|
|
}
|
|
|
|
type KeyConfig struct {
|
|
Size int
|
|
PrivateKeyLifetime time.Duration
|
|
PublicKeyLifetime time.Duration
|
|
CertificateSize int
|
|
CertificateLifetime time.Duration
|
|
}
|