mirror of
https://github.com/andwati/zitadel.git
synced 2026-10-21 15:04:25 +00:00
3ff4fbc7e4
<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
# Which Problems Are Solved
Bulk unique-constraint deletes (org, IDP with many links, user, project)
reconstruct every uniqueness key in Go and emit N `DELETE`s. That can
OOM on large tenants.
A one-shot owner backfill is also not enough: during a rolling deploy,
older binaries still insert `owners = '{}'`, so a later owner-only
delete would miss those rows.
Owner-only org/user/grant delete only matches rows whose `owners` bag
contains that tag. Several grant and member types stamped the aggregate
resource owner, which is not always the user’s home org or the granted
org. Username-scope rewrites also dropped `user:` tags, so owner-only
user delete could miss rewritten username rows.
Command must not switch to owner-only delete on the first 79 of a
version, because leftover `'{}'` rows from rolling-update overlap are
only backfilled on a later 79. A failed 79 must not turn owner-delete
on, and backfill joins must not stamp the wrong org (unverified domains,
org-scoped usernames colliding with instance-scoped ones).
# How the Problems Are Solved
Uniqueness stays the existing primary key `(instance_id, unique_type,
unique_field)`. `owners` is only a lifecycle bag of tags (`org:<id>`,
`user:<id>`, `idp:<id>`, `project:<id>`, `grant:<id>`).
- Add `owners TEXT[] NOT NULL DEFAULT '{}'` on
`eventstore.unique_constraints` (init SQL for greenfield, setup 78 for
existing clusters).
- Create `unique_constraints_owners_gin` with `CREATE INDEX
CONCURRENTLY` **outside a transaction** (same pattern as step 76).
Built-in `GIN (owners)` only; no `btree_gin`.
- Stamp `WithOwners` on **add** events. Field-level removes ignore
owners. `RemoveByOwner` stores the tag in `Owners` and both v1/v3 and v2
pushers run `DELETE … WHERE instance_id = $1 AND owners @>
ARRAY[$tag]::text[]`.
- Setup 79 backfills `owners` from projections via numbered
`cmd/setup/79/*.sql` files. Table names are interpolated from
`internal/query/projection` constants. Matches use `unique_field IN (x,
lower(x))` so the primary key can be used. Missing projection tables
(`42P01`) are skipped.
- Org domains are tagged only when `is_verified`. Instance-scoped
usernames join only users that are not org-scoped (organization settings
or domain policy `user_login_must_be_domain`). Every username row still
gets `org:` + `user:` of that user.
- 79 is a **repeatable** migration. `Check` re-runs when
`lastRun["version"]` changed or when setup-only `ForceFinalize` is set
and `lastRun["finalized"]` is still false. `Finalized` is written only
after Execute succeeds.
- Failed setup events keep the last successful `lastRun`. Command reads
`finalized` only from `system.migration.repeatable.done`.
- Org / user / project remove skip N-key event replay **when that
`finalized` bit is true**. Otherwise they keep today’s N-key lists
**and** still emit `RemoveByOwner`. The “ready” result is cached in
memory once true.
Setup writes `finalized` on the 79 repeatable.done payload:
- First 79 of a version: backfill only, `finalized=false` (unless
`ForceFinalize` is already set).
- Later 79: version change or
`BackfillUniqueConstraintOwners.ForceFinalize` /
`ZITADEL_BACKFILLUNIQUECONSTRAINTOWNERS_FORCEFINALIZE` after the rolling
update is done. That run backfills leftovers and writes
`finalized=true`.
Member and grant owner bags now include every org that should delete the
row:
- Instance, org, and project members also stamp
`org:<user_resource_owner>`.
- User grants stamp grant, user, project, and granted orgs.
- Project grant members stamp the project org, user org, and granted
org.
- Project grants stamp both orgs plus `grant:<id>`. Grant remove emits
`RemoveByOwner(grant)`.
- Username-scope rewrites keep `user:<id>` as well as `org:`.
- User/grant orgs are carried as unexported add-event fields (not
persisted JSON). `WithOwners` skips empty and duplicate tags.
# Additional Changes
- Table-driven owner-tag tests, including project grant (two `org:` tags
plus `grant:`), cross-org members, user grants, and username-scope
rewrite `user:` tags.
- Table-driven 79 `Check` + `finalizeAfterSuccess` tests for version
change, sequential version bumps, ForceFinalize restart, and
already-finalized skip.
- Command tests: a failed 79 event with `finalized=true` does not enable
owner-delete.
- Integration fixtures (verified vs unverified org domain;
instance-scoped `bob` vs org-scoped `bob`).
- Instance-only and global unique types stay untagged (`'{}'`). Instance
wipe still uses `UniqueConstraintInstanceRemove`.
- Pusher owner cases live in `eventstore_pusher_owners_test.go` so
`eventstore_pusher_test.go` stays under 1k lines.
# Additional Context
A later cleanup can delete the N-key replay helpers once a release that
ran 79 a second time (or an operator who set `ForceFinalize`) is in
production. That is not required for correctness.
<!-- CURSOR_AGENT_PR_BODY_END -->
<div><a
href="https://cursor.com/agents/bc-44f9bc9b-9a93-4cd9-8dd1-663a7b9aad2a?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a
href="https://cursor.com/background-agent?bcId=bc-44f9bc9b-9a93-4cd9-8dd1-663a7b9aad2a&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div>
---------
Co-authored-by: Cursor Agent <[email protected]>
Co-authored-by: Silvan <[email protected]>
1347 lines
40 KiB
Go
1347 lines
40 KiB
Go
package postgres
|
|
|
|
import (
|
|
"context"
|
|
"database/sql/driver"
|
|
"errors"
|
|
"reflect"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/shopspring/decimal"
|
|
|
|
"github.com/zitadel/zitadel/internal/v2/database/mock"
|
|
"github.com/zitadel/zitadel/internal/v2/eventstore"
|
|
"github.com/zitadel/zitadel/internal/zerrors"
|
|
)
|
|
|
|
func Test_uniqueConstraints(t *testing.T) {
|
|
type args struct {
|
|
commands []*command
|
|
expectations []mock.Expectation
|
|
}
|
|
execErr := errors.New("exec err")
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
assertErr func(t *testing.T, err error) bool
|
|
}{
|
|
{
|
|
name: "no commands",
|
|
args: args{
|
|
commands: []*command{},
|
|
expectations: []mock.Expectation{},
|
|
},
|
|
assertErr: expectNoErr,
|
|
},
|
|
{
|
|
name: "command without constraints",
|
|
args: args{
|
|
commands: []*command{
|
|
{
|
|
Command: &eventstore.Command{},
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{},
|
|
},
|
|
assertErr: expectNoErr,
|
|
},
|
|
{
|
|
name: "add 1 constraint 1 command",
|
|
args: args{
|
|
commands: []*command{
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("", "", ""),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
UniqueConstraints: []*eventstore.UniqueConstraint{
|
|
eventstore.NewAddEventUniqueConstraint("test", "id", "error"),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectExec(
|
|
"INSERT INTO eventstore.unique_constraints (instance_id, unique_type, unique_field, owners) VALUES ($1, $2, $3, $4)",
|
|
mock.WithExecArgs("instance", "test", "id", []string{}),
|
|
mock.WithExecRowsAffected(1),
|
|
),
|
|
},
|
|
},
|
|
assertErr: expectNoErr,
|
|
},
|
|
{
|
|
name: "add 1 global constraint 1 command",
|
|
args: args{
|
|
commands: []*command{
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("", "", ""),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
UniqueConstraints: []*eventstore.UniqueConstraint{
|
|
eventstore.NewAddGlobalUniqueConstraint("test", "id", "error"),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectExec(
|
|
"INSERT INTO eventstore.unique_constraints (instance_id, unique_type, unique_field, owners) VALUES ($1, $2, $3, $4)",
|
|
mock.WithExecArgs("", "test", "id", []string{}),
|
|
mock.WithExecRowsAffected(1),
|
|
),
|
|
},
|
|
},
|
|
assertErr: expectNoErr,
|
|
},
|
|
{
|
|
name: "add 2 constraint 1 command",
|
|
args: args{
|
|
commands: []*command{
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("", "", ""),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
UniqueConstraints: []*eventstore.UniqueConstraint{
|
|
eventstore.NewAddEventUniqueConstraint("test", "id", "error"),
|
|
eventstore.NewAddEventUniqueConstraint("test", "id2", "error"),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectExec(
|
|
"INSERT INTO eventstore.unique_constraints (instance_id, unique_type, unique_field, owners) VALUES ($1, $2, $3, $4)",
|
|
mock.WithExecArgs("instance", "test", "id", []string{}),
|
|
mock.WithExecRowsAffected(1),
|
|
),
|
|
mock.ExpectExec(
|
|
"INSERT INTO eventstore.unique_constraints (instance_id, unique_type, unique_field, owners) VALUES ($1, $2, $3, $4)",
|
|
mock.WithExecArgs("instance", "test", "id2", []string{}),
|
|
mock.WithExecRowsAffected(1),
|
|
),
|
|
},
|
|
},
|
|
assertErr: expectNoErr,
|
|
},
|
|
{
|
|
name: "add 1 constraint per command",
|
|
args: args{
|
|
commands: []*command{
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("", "", ""),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
UniqueConstraints: []*eventstore.UniqueConstraint{
|
|
eventstore.NewAddEventUniqueConstraint("test", "id", "error"),
|
|
},
|
|
},
|
|
},
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("", "", ""),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
UniqueConstraints: []*eventstore.UniqueConstraint{
|
|
eventstore.NewAddEventUniqueConstraint("test", "id2", "error"),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectExec(
|
|
"INSERT INTO eventstore.unique_constraints (instance_id, unique_type, unique_field, owners) VALUES ($1, $2, $3, $4)",
|
|
mock.WithExecArgs("instance", "test", "id", []string{}),
|
|
mock.WithExecRowsAffected(1),
|
|
),
|
|
mock.ExpectExec(
|
|
"INSERT INTO eventstore.unique_constraints (instance_id, unique_type, unique_field, owners) VALUES ($1, $2, $3, $4)",
|
|
mock.WithExecArgs("instance", "test", "id2", []string{}),
|
|
mock.WithExecRowsAffected(1),
|
|
),
|
|
},
|
|
},
|
|
assertErr: expectNoErr,
|
|
},
|
|
{
|
|
name: "remove instance constraints 1 command",
|
|
args: args{
|
|
commands: []*command{
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("", "", ""),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
UniqueConstraints: []*eventstore.UniqueConstraint{
|
|
eventstore.NewRemoveInstanceUniqueConstraints(),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectExec(
|
|
"DELETE FROM eventstore.unique_constraints WHERE instance_id = $1",
|
|
mock.WithExecArgs("instance"),
|
|
mock.WithExecRowsAffected(10),
|
|
),
|
|
},
|
|
},
|
|
assertErr: expectNoErr,
|
|
},
|
|
{
|
|
name: "remove instance constraints 2 commands",
|
|
args: args{
|
|
commands: []*command{
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("", "", ""),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
UniqueConstraints: []*eventstore.UniqueConstraint{
|
|
eventstore.NewRemoveInstanceUniqueConstraints(),
|
|
},
|
|
},
|
|
},
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("", "", ""),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
UniqueConstraints: []*eventstore.UniqueConstraint{
|
|
eventstore.NewRemoveInstanceUniqueConstraints(),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectExec(
|
|
"DELETE FROM eventstore.unique_constraints WHERE instance_id = $1",
|
|
mock.WithExecArgs("instance"),
|
|
mock.WithExecRowsAffected(10),
|
|
),
|
|
mock.ExpectExec(
|
|
"DELETE FROM eventstore.unique_constraints WHERE instance_id = $1",
|
|
mock.WithExecArgs("instance"),
|
|
mock.WithExecRowsAffected(0),
|
|
),
|
|
},
|
|
},
|
|
assertErr: expectNoErr,
|
|
},
|
|
{
|
|
name: "remove 1 constraint 1 command",
|
|
args: args{
|
|
commands: []*command{
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("", "", ""),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
UniqueConstraints: []*eventstore.UniqueConstraint{
|
|
eventstore.NewRemoveUniqueConstraint("test", "id"),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectExec(
|
|
`DELETE FROM eventstore.unique_constraints WHERE (instance_id = $1 AND unique_type = $2 AND unique_field = ( SELECT unique_field from ( SELECT instance_id, unique_type, unique_field FROM eventstore.unique_constraints WHERE instance_id = $1 AND unique_type = $2 AND unique_field = $3 UNION ALL SELECT instance_id, unique_type, unique_field FROM eventstore.unique_constraints WHERE instance_id = $1 AND unique_type = $2 AND unique_field = LOWER($3) ) AS case_insensitive_constraints LIMIT 1) )`,
|
|
mock.WithExecArgs("instance", "test", "id"),
|
|
mock.WithExecRowsAffected(1),
|
|
),
|
|
},
|
|
},
|
|
assertErr: expectNoErr,
|
|
},
|
|
{
|
|
name: "remove 1 global constraint 1 command",
|
|
args: args{
|
|
commands: []*command{
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("", "", ""),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
UniqueConstraints: []*eventstore.UniqueConstraint{
|
|
eventstore.NewRemoveGlobalUniqueConstraint("test", "id"),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectExec(
|
|
`DELETE FROM eventstore.unique_constraints WHERE (instance_id = $1 AND unique_type = $2 AND unique_field = ( SELECT unique_field from ( SELECT instance_id, unique_type, unique_field FROM eventstore.unique_constraints WHERE instance_id = $1 AND unique_type = $2 AND unique_field = $3 UNION ALL SELECT instance_id, unique_type, unique_field FROM eventstore.unique_constraints WHERE instance_id = $1 AND unique_type = $2 AND unique_field = LOWER($3) ) AS case_insensitive_constraints LIMIT 1) )`,
|
|
mock.WithExecArgs("", "test", "id"),
|
|
mock.WithExecRowsAffected(1),
|
|
),
|
|
},
|
|
},
|
|
assertErr: expectNoErr,
|
|
},
|
|
{
|
|
name: "remove 2 constraints 1 command",
|
|
args: args{
|
|
commands: []*command{
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("", "", ""),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
UniqueConstraints: []*eventstore.UniqueConstraint{
|
|
eventstore.NewRemoveUniqueConstraint("test", "id"),
|
|
eventstore.NewRemoveUniqueConstraint("test", "id2"),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectExec(
|
|
`DELETE FROM eventstore.unique_constraints WHERE (instance_id = $1 AND unique_type = $2 AND unique_field = ( SELECT unique_field from ( SELECT instance_id, unique_type, unique_field FROM eventstore.unique_constraints WHERE instance_id = $1 AND unique_type = $2 AND unique_field = $3 UNION ALL SELECT instance_id, unique_type, unique_field FROM eventstore.unique_constraints WHERE instance_id = $1 AND unique_type = $2 AND unique_field = LOWER($3) ) AS case_insensitive_constraints LIMIT 1) )`,
|
|
mock.WithExecArgs("instance", "test", "id"),
|
|
mock.WithExecRowsAffected(1),
|
|
),
|
|
mock.ExpectExec(
|
|
`DELETE FROM eventstore.unique_constraints WHERE (instance_id = $1 AND unique_type = $2 AND unique_field = ( SELECT unique_field from ( SELECT instance_id, unique_type, unique_field FROM eventstore.unique_constraints WHERE instance_id = $1 AND unique_type = $2 AND unique_field = $3 UNION ALL SELECT instance_id, unique_type, unique_field FROM eventstore.unique_constraints WHERE instance_id = $1 AND unique_type = $2 AND unique_field = LOWER($3) ) AS case_insensitive_constraints LIMIT 1) )`,
|
|
mock.WithExecArgs("instance", "test", "id2"),
|
|
mock.WithExecRowsAffected(1),
|
|
),
|
|
},
|
|
},
|
|
assertErr: expectNoErr,
|
|
},
|
|
{
|
|
name: "remove 1 constraints per command",
|
|
args: args{
|
|
commands: []*command{
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("", "", ""),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
UniqueConstraints: []*eventstore.UniqueConstraint{
|
|
eventstore.NewRemoveUniqueConstraint("test", "id"),
|
|
},
|
|
},
|
|
},
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("", "", ""),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
UniqueConstraints: []*eventstore.UniqueConstraint{
|
|
eventstore.NewRemoveUniqueConstraint("test", "id2"),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectExec(
|
|
`DELETE FROM eventstore.unique_constraints WHERE (instance_id = $1 AND unique_type = $2 AND unique_field = ( SELECT unique_field from ( SELECT instance_id, unique_type, unique_field FROM eventstore.unique_constraints WHERE instance_id = $1 AND unique_type = $2 AND unique_field = $3 UNION ALL SELECT instance_id, unique_type, unique_field FROM eventstore.unique_constraints WHERE instance_id = $1 AND unique_type = $2 AND unique_field = LOWER($3) ) AS case_insensitive_constraints LIMIT 1) )`,
|
|
mock.WithExecArgs("instance", "test", "id"),
|
|
mock.WithExecRowsAffected(1),
|
|
),
|
|
mock.ExpectExec(
|
|
`DELETE FROM eventstore.unique_constraints WHERE (instance_id = $1 AND unique_type = $2 AND unique_field = ( SELECT unique_field from ( SELECT instance_id, unique_type, unique_field FROM eventstore.unique_constraints WHERE instance_id = $1 AND unique_type = $2 AND unique_field = $3 UNION ALL SELECT instance_id, unique_type, unique_field FROM eventstore.unique_constraints WHERE instance_id = $1 AND unique_type = $2 AND unique_field = LOWER($3) ) AS case_insensitive_constraints LIMIT 1) )`,
|
|
mock.WithExecArgs("instance", "test", "id2"),
|
|
mock.WithExecRowsAffected(1),
|
|
),
|
|
},
|
|
},
|
|
assertErr: expectNoErr,
|
|
},
|
|
{
|
|
name: "remove by owner 1 command",
|
|
args: args{
|
|
commands: []*command{
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("", "", ""),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
UniqueConstraints: []*eventstore.UniqueConstraint{
|
|
eventstore.NewRemoveUniqueConstraintsByOwner(eventstore.UniqueConstraintOwnerOrg, "org-1"),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectExec(
|
|
`DELETE FROM eventstore.unique_constraints WHERE instance_id = $1 AND owners @> ARRAY[$2]::text[]`,
|
|
mock.WithExecArgs("instance", "org:org-1"),
|
|
mock.WithExecRowsAffected(3),
|
|
),
|
|
},
|
|
},
|
|
assertErr: expectNoErr,
|
|
},
|
|
{
|
|
name: "exec fails no error specified",
|
|
args: args{
|
|
commands: []*command{
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("", "", ""),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
UniqueConstraints: []*eventstore.UniqueConstraint{
|
|
eventstore.NewAddEventUniqueConstraint("test", "id", ""),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectExec(
|
|
"INSERT INTO eventstore.unique_constraints (instance_id, unique_type, unique_field, owners) VALUES ($1, $2, $3, $4)",
|
|
mock.WithExecArgs("instance", "test", "id", []string{}),
|
|
mock.WithExecErr(execErr),
|
|
),
|
|
},
|
|
},
|
|
assertErr: func(t *testing.T, err error) bool {
|
|
is := errors.Is(err, zerrors.ThrowAlreadyExists(execErr, "POSTG-QzjyP", "Errors.Internal"))
|
|
if !is {
|
|
t.Errorf("no error expected got: %v", err)
|
|
}
|
|
return is
|
|
},
|
|
},
|
|
{
|
|
name: "exec fails error specified",
|
|
args: args{
|
|
commands: []*command{
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("", "", ""),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
UniqueConstraints: []*eventstore.UniqueConstraint{
|
|
eventstore.NewAddEventUniqueConstraint("test", "id", "My.Error"),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectExec(
|
|
"INSERT INTO eventstore.unique_constraints (instance_id, unique_type, unique_field, owners) VALUES ($1, $2, $3, $4)",
|
|
mock.WithExecArgs("instance", "test", "id", []string{}),
|
|
mock.WithExecErr(execErr),
|
|
),
|
|
},
|
|
},
|
|
assertErr: func(t *testing.T, err error) bool {
|
|
is := errors.Is(err, zerrors.ThrowAlreadyExists(execErr, "POSTG-QzjyP", "My.Error"))
|
|
if !is {
|
|
t.Errorf("no error expected got: %v", err)
|
|
}
|
|
return is
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
dbMock := mock.NewSQLMock(t, append([]mock.Expectation{mock.ExpectBegin(nil)}, tt.args.expectations...)...)
|
|
tx, err := dbMock.DB.Begin()
|
|
if err != nil {
|
|
t.Errorf("unexpected error in begin: %v", err)
|
|
t.FailNow()
|
|
}
|
|
err = uniqueConstraints(context.Background(), tx, tt.args.commands)
|
|
tt.assertErr(t, err)
|
|
dbMock.Assert(t)
|
|
})
|
|
}
|
|
}
|
|
|
|
var errReduce = errors.New("reduce err")
|
|
|
|
func Test_lockAggregates(t *testing.T) {
|
|
type args struct {
|
|
pushIntent *eventstore.PushIntent
|
|
expectations []mock.Expectation
|
|
}
|
|
type want struct {
|
|
intents []*intent
|
|
assertErr func(t *testing.T, err error) bool
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
want want
|
|
}{
|
|
{
|
|
name: "1 intent",
|
|
args: args{
|
|
pushIntent: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "testType", "testID"),
|
|
),
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectQuery(
|
|
`WITH existing AS ((SELECT instance_id, aggregate_type, aggregate_id, "sequence" FROM eventstore.events2 WHERE instance_id = $1 AND aggregate_type = $2 AND aggregate_id = $3 AND owner = $4 ORDER BY "sequence" DESC LIMIT 1)) SELECT e.instance_id, e.owner, e.aggregate_type, e.aggregate_id, e.sequence FROM eventstore.events2 e JOIN existing ON e.instance_id = existing.instance_id AND e.aggregate_type = existing.aggregate_type AND e.aggregate_id = existing.aggregate_id AND e.sequence = existing.sequence FOR UPDATE`,
|
|
mock.WithQueryArgs("instance", "testType", "testID", "owner"),
|
|
mock.WithQueryResult(
|
|
[]string{"instance_id", "owner", "aggregate_type", "aggregate_id", "sequence"},
|
|
[][]driver.Value{
|
|
{
|
|
"instance",
|
|
"owner",
|
|
"testType",
|
|
"testID",
|
|
42,
|
|
},
|
|
},
|
|
),
|
|
),
|
|
},
|
|
},
|
|
want: want{
|
|
intents: []*intent{
|
|
{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "testType", "testID"),
|
|
).Aggregates()[0],
|
|
sequence: 42,
|
|
},
|
|
},
|
|
assertErr: expectNoErr,
|
|
},
|
|
},
|
|
{
|
|
name: "two intents",
|
|
args: args{
|
|
pushIntent: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "testType", "testID"),
|
|
eventstore.AppendAggregate("owner", "myType", "id"),
|
|
),
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectQuery(
|
|
`WITH existing AS ((SELECT instance_id, aggregate_type, aggregate_id, "sequence" FROM eventstore.events2 WHERE instance_id = $1 AND aggregate_type = $2 AND aggregate_id = $3 AND owner = $4 ORDER BY "sequence" DESC LIMIT 1) UNION ALL (SELECT instance_id, aggregate_type, aggregate_id, "sequence" FROM eventstore.events2 WHERE instance_id = $5 AND aggregate_type = $6 AND aggregate_id = $7 AND owner = $8 ORDER BY "sequence" DESC LIMIT 1)) SELECT e.instance_id, e.owner, e.aggregate_type, e.aggregate_id, e.sequence FROM eventstore.events2 e JOIN existing ON e.instance_id = existing.instance_id AND e.aggregate_type = existing.aggregate_type AND e.aggregate_id = existing.aggregate_id AND e.sequence = existing.sequence FOR UPDATE`,
|
|
mock.WithQueryArgs(
|
|
"instance", "testType", "testID", "owner",
|
|
"instance", "myType", "id", "owner",
|
|
),
|
|
mock.WithQueryResult(
|
|
[]string{"instance_id", "owner", "aggregate_type", "aggregate_id", "sequence"},
|
|
[][]driver.Value{
|
|
{
|
|
"instance",
|
|
"owner",
|
|
"testType",
|
|
"testID",
|
|
42,
|
|
},
|
|
{
|
|
"instance",
|
|
"owner",
|
|
"myType",
|
|
"id",
|
|
17,
|
|
},
|
|
},
|
|
),
|
|
),
|
|
},
|
|
},
|
|
want: want{
|
|
intents: []*intent{
|
|
{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "testType", "testID"),
|
|
).Aggregates()[0],
|
|
sequence: 42,
|
|
},
|
|
{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "myType", "id"),
|
|
).Aggregates()[0],
|
|
sequence: 17,
|
|
},
|
|
},
|
|
assertErr: expectNoErr,
|
|
},
|
|
},
|
|
{
|
|
name: "1 intent aggregate not found",
|
|
args: args{
|
|
pushIntent: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "testType", "testID"),
|
|
),
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectQuery(
|
|
`WITH existing AS ((SELECT instance_id, aggregate_type, aggregate_id, "sequence" FROM eventstore.events2 WHERE instance_id = $1 AND aggregate_type = $2 AND aggregate_id = $3 AND owner = $4 ORDER BY "sequence" DESC LIMIT 1)) SELECT e.instance_id, e.owner, e.aggregate_type, e.aggregate_id, e.sequence FROM eventstore.events2 e JOIN existing ON e.instance_id = existing.instance_id AND e.aggregate_type = existing.aggregate_type AND e.aggregate_id = existing.aggregate_id AND e.sequence = existing.sequence FOR UPDATE`,
|
|
mock.WithQueryArgs("instance", "testType", "testID", "owner"),
|
|
mock.WithQueryResult(
|
|
[]string{"instance_id", "owner", "aggregate_type", "aggregate_id", "sequence"},
|
|
[][]driver.Value{},
|
|
),
|
|
),
|
|
},
|
|
},
|
|
want: want{
|
|
intents: []*intent{
|
|
{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "testType", "testID"),
|
|
).Aggregates()[0],
|
|
sequence: 0,
|
|
},
|
|
},
|
|
assertErr: expectNoErr,
|
|
},
|
|
},
|
|
{
|
|
name: "two intents none found",
|
|
args: args{
|
|
pushIntent: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "testType", "testID"),
|
|
eventstore.AppendAggregate("owner", "myType", "id"),
|
|
),
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectQuery(
|
|
`WITH existing AS ((SELECT instance_id, aggregate_type, aggregate_id, "sequence" FROM eventstore.events2 WHERE instance_id = $1 AND aggregate_type = $2 AND aggregate_id = $3 AND owner = $4 ORDER BY "sequence" DESC LIMIT 1) UNION ALL (SELECT instance_id, aggregate_type, aggregate_id, "sequence" FROM eventstore.events2 WHERE instance_id = $5 AND aggregate_type = $6 AND aggregate_id = $7 AND owner = $8 ORDER BY "sequence" DESC LIMIT 1)) SELECT e.instance_id, e.owner, e.aggregate_type, e.aggregate_id, e.sequence FROM eventstore.events2 e JOIN existing ON e.instance_id = existing.instance_id AND e.aggregate_type = existing.aggregate_type AND e.aggregate_id = existing.aggregate_id AND e.sequence = existing.sequence FOR UPDATE`,
|
|
mock.WithQueryArgs(
|
|
"instance", "testType", "testID", "owner",
|
|
"instance", "myType", "id", "owner",
|
|
),
|
|
mock.WithQueryResult(
|
|
[]string{"instance_id", "owner", "aggregate_type", "aggregate_id", "sequence"},
|
|
[][]driver.Value{},
|
|
),
|
|
),
|
|
},
|
|
},
|
|
want: want{
|
|
intents: []*intent{
|
|
{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "testType", "testID"),
|
|
).Aggregates()[0],
|
|
sequence: 0,
|
|
},
|
|
{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "myType", "id"),
|
|
).Aggregates()[0],
|
|
sequence: 0,
|
|
},
|
|
},
|
|
assertErr: expectNoErr,
|
|
},
|
|
},
|
|
{
|
|
name: "two intents 1 found",
|
|
args: args{
|
|
pushIntent: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "testType", "testID"),
|
|
eventstore.AppendAggregate("owner", "myType", "id"),
|
|
),
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectQuery(
|
|
`WITH existing AS ((SELECT instance_id, aggregate_type, aggregate_id, "sequence" FROM eventstore.events2 WHERE instance_id = $1 AND aggregate_type = $2 AND aggregate_id = $3 AND owner = $4 ORDER BY "sequence" DESC LIMIT 1) UNION ALL (SELECT instance_id, aggregate_type, aggregate_id, "sequence" FROM eventstore.events2 WHERE instance_id = $5 AND aggregate_type = $6 AND aggregate_id = $7 AND owner = $8 ORDER BY "sequence" DESC LIMIT 1)) SELECT e.instance_id, e.owner, e.aggregate_type, e.aggregate_id, e.sequence FROM eventstore.events2 e JOIN existing ON e.instance_id = existing.instance_id AND e.aggregate_type = existing.aggregate_type AND e.aggregate_id = existing.aggregate_id AND e.sequence = existing.sequence FOR UPDATE`,
|
|
mock.WithQueryArgs(
|
|
"instance", "testType", "testID", "owner",
|
|
"instance", "myType", "id", "owner",
|
|
),
|
|
mock.WithQueryResult(
|
|
[]string{"instance_id", "owner", "aggregate_type", "aggregate_id", "sequence"},
|
|
[][]driver.Value{
|
|
{
|
|
"instance",
|
|
"owner",
|
|
"myType",
|
|
"id",
|
|
17,
|
|
},
|
|
},
|
|
),
|
|
),
|
|
},
|
|
},
|
|
want: want{
|
|
intents: []*intent{
|
|
{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "testType", "testID"),
|
|
).Aggregates()[0],
|
|
sequence: 0,
|
|
},
|
|
{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "myType", "id"),
|
|
).Aggregates()[0],
|
|
sequence: 17,
|
|
},
|
|
},
|
|
assertErr: expectNoErr,
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
dbMock := mock.NewSQLMock(t, append([]mock.Expectation{mock.ExpectBegin(nil)}, tt.args.expectations...)...)
|
|
tx, err := dbMock.DB.Begin()
|
|
if err != nil {
|
|
t.Errorf("unexpected error in begin: %v", err)
|
|
t.FailNow()
|
|
}
|
|
got, err := lockAggregates(context.Background(), tx, tt.args.pushIntent)
|
|
tt.want.assertErr(t, err)
|
|
dbMock.Assert(t)
|
|
if len(got) != len(tt.want.intents) {
|
|
t.Errorf("unexpected length of intents %d, want: %d", len(got), len(tt.want.intents))
|
|
return
|
|
}
|
|
for i, gotten := range got {
|
|
assertIntent(t, gotten, tt.want.intents[i])
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func assertIntent(t *testing.T, got, want *intent) {
|
|
if got.sequence != want.sequence {
|
|
t.Errorf("unexpected sequence %d want %d", got.sequence, want.sequence)
|
|
}
|
|
assertPushAggregate(t, got.PushAggregate, want.PushAggregate)
|
|
}
|
|
|
|
func assertPushAggregate(t *testing.T, got, want *eventstore.PushAggregate) {
|
|
if !reflect.DeepEqual(got.Type(), want.Type()) {
|
|
t.Errorf("unexpected Type %v, want: %v", got.Type(), want.Type())
|
|
}
|
|
if !reflect.DeepEqual(got.ID(), want.ID()) {
|
|
t.Errorf("unexpected ID %v, want: %v", got.ID(), want.ID())
|
|
}
|
|
if !reflect.DeepEqual(got.Owner(), want.Owner()) {
|
|
t.Errorf("unexpected Owner %v, want: %v", got.Owner(), want.Owner())
|
|
}
|
|
if !reflect.DeepEqual(got.Commands(), want.Commands()) {
|
|
t.Errorf("unexpected Commands %v, want: %v", got.Commands(), want.Commands())
|
|
}
|
|
if !reflect.DeepEqual(got.Aggregate(), want.Aggregate()) {
|
|
t.Errorf("unexpected Aggregate %v, want: %v", got.Aggregate(), want.Aggregate())
|
|
}
|
|
if !reflect.DeepEqual(got.CurrentSequence(), want.CurrentSequence()) {
|
|
t.Errorf("unexpected CurrentSequence %v, want: %v", got.CurrentSequence(), want.CurrentSequence())
|
|
}
|
|
}
|
|
|
|
func Test_push(t *testing.T) {
|
|
type args struct {
|
|
commands []*command
|
|
expectations []mock.Expectation
|
|
reducer *testReducer
|
|
}
|
|
type want struct {
|
|
assertErr func(t *testing.T, err error) bool
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
want want
|
|
}{
|
|
{
|
|
name: "1 aggregate 1 command",
|
|
args: args{
|
|
reducer: &testReducer{
|
|
expectedReduces: 1,
|
|
},
|
|
commands: []*command{
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "testType", "testID"),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
Action: eventstore.Action[any]{
|
|
Creator: "gigi",
|
|
Revision: 1,
|
|
Type: "test.type",
|
|
},
|
|
},
|
|
sequence: 1,
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectQuery(
|
|
`INSERT INTO eventstore.events2 (instance_id, "owner", aggregate_type, aggregate_id, revision, creator, event_type, payload, "sequence", in_tx_order, created_at, "position") VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, statement_timestamp(), EXTRACT(EPOCH FROM clock_timestamp())) RETURNING created_at, "position"`,
|
|
mock.WithQueryArgs(
|
|
"instance",
|
|
"owner",
|
|
"testType",
|
|
"testID",
|
|
uint16(1),
|
|
"gigi",
|
|
"test.type",
|
|
mock.NilArg,
|
|
uint32(1),
|
|
uint32(0),
|
|
),
|
|
mock.WithQueryResult(
|
|
[]string{"created_at", "position"},
|
|
[][]driver.Value{
|
|
{
|
|
time.Now(),
|
|
decimal.NewFromFloat(123).String(),
|
|
},
|
|
},
|
|
),
|
|
),
|
|
},
|
|
},
|
|
want: want{
|
|
assertErr: expectNoErr,
|
|
},
|
|
},
|
|
{
|
|
name: "1 aggregate 2 commands",
|
|
args: args{
|
|
reducer: &testReducer{
|
|
expectedReduces: 2,
|
|
},
|
|
commands: []*command{
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "testType", "testID"),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
Action: eventstore.Action[any]{
|
|
Creator: "gigi",
|
|
Revision: 1,
|
|
Type: "test.type",
|
|
},
|
|
},
|
|
sequence: 1,
|
|
},
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "testType", "testID"),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
Action: eventstore.Action[any]{
|
|
Creator: "gigi",
|
|
Revision: 1,
|
|
Type: "test.type2",
|
|
},
|
|
},
|
|
sequence: 2,
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectQuery(
|
|
`INSERT INTO eventstore.events2 (instance_id, "owner", aggregate_type, aggregate_id, revision, creator, event_type, payload, "sequence", in_tx_order, created_at, "position") VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, statement_timestamp(), EXTRACT(EPOCH FROM clock_timestamp())), ($11, $12, $13, $14, $15, $16, $17, $18, $19, $20, statement_timestamp(), EXTRACT(EPOCH FROM clock_timestamp())) RETURNING created_at, "position"`,
|
|
mock.WithQueryArgs(
|
|
"instance",
|
|
"owner",
|
|
"testType",
|
|
"testID",
|
|
uint16(1),
|
|
"gigi",
|
|
"test.type",
|
|
mock.NilArg,
|
|
uint32(1),
|
|
uint32(0),
|
|
"instance",
|
|
"owner",
|
|
"testType",
|
|
"testID",
|
|
uint16(1),
|
|
"gigi",
|
|
"test.type2",
|
|
mock.NilArg,
|
|
uint32(2),
|
|
uint32(1),
|
|
),
|
|
mock.WithQueryResult(
|
|
[]string{"created_at", "position"},
|
|
[][]driver.Value{
|
|
{
|
|
time.Now(),
|
|
decimal.NewFromFloat(123).String(),
|
|
},
|
|
{
|
|
time.Now(),
|
|
decimal.NewFromFloat(123.1).String(),
|
|
},
|
|
},
|
|
),
|
|
),
|
|
},
|
|
},
|
|
want: want{
|
|
assertErr: expectNoErr,
|
|
},
|
|
},
|
|
{
|
|
name: "1 command per aggregate 2 aggregates",
|
|
args: args{
|
|
reducer: &testReducer{
|
|
expectedReduces: 2,
|
|
},
|
|
commands: []*command{
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "testType", "testID"),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
Action: eventstore.Action[any]{
|
|
Creator: "gigi",
|
|
Revision: 1,
|
|
Type: "test.type",
|
|
},
|
|
},
|
|
sequence: 1,
|
|
},
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "type2", "id2"),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
Action: eventstore.Action[any]{
|
|
Creator: "gigi",
|
|
Revision: 1,
|
|
Type: "test.type2",
|
|
},
|
|
},
|
|
sequence: 10,
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectQuery(
|
|
`INSERT INTO eventstore.events2 (instance_id, "owner", aggregate_type, aggregate_id, revision, creator, event_type, payload, "sequence", in_tx_order, created_at, "position") VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, statement_timestamp(), EXTRACT(EPOCH FROM clock_timestamp())), ($11, $12, $13, $14, $15, $16, $17, $18, $19, $20, statement_timestamp(), EXTRACT(EPOCH FROM clock_timestamp())) RETURNING created_at, "position"`,
|
|
mock.WithQueryArgs(
|
|
"instance",
|
|
"owner",
|
|
"testType",
|
|
"testID",
|
|
uint16(1),
|
|
"gigi",
|
|
"test.type",
|
|
mock.NilArg,
|
|
uint32(1),
|
|
uint32(0),
|
|
"instance",
|
|
"owner",
|
|
"type2",
|
|
"id2",
|
|
uint16(1),
|
|
"gigi",
|
|
"test.type2",
|
|
mock.NilArg,
|
|
uint32(10),
|
|
uint32(1),
|
|
),
|
|
mock.WithQueryResult(
|
|
[]string{"created_at", "position"},
|
|
[][]driver.Value{
|
|
{
|
|
time.Now(),
|
|
decimal.NewFromFloat(123).String(),
|
|
},
|
|
{
|
|
time.Now(),
|
|
decimal.NewFromFloat(123.1).String(),
|
|
},
|
|
},
|
|
),
|
|
),
|
|
},
|
|
},
|
|
want: want{
|
|
assertErr: expectNoErr,
|
|
},
|
|
},
|
|
{
|
|
name: "1 aggregate 1 command with payload",
|
|
args: args{
|
|
reducer: &testReducer{
|
|
expectedReduces: 1,
|
|
},
|
|
commands: []*command{
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "testType", "testID"),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
Action: eventstore.Action[any]{
|
|
Creator: "gigi",
|
|
Revision: 1,
|
|
Type: "test.type",
|
|
},
|
|
},
|
|
sequence: 1,
|
|
payload: []byte(`{"name": "gigi"}`),
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectQuery(
|
|
`INSERT INTO eventstore.events2 (instance_id, "owner", aggregate_type, aggregate_id, revision, creator, event_type, payload, "sequence", in_tx_order, created_at, "position") VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, statement_timestamp(), EXTRACT(EPOCH FROM clock_timestamp())) RETURNING created_at, "position"`,
|
|
mock.WithQueryArgs(
|
|
"instance",
|
|
"owner",
|
|
"testType",
|
|
"testID",
|
|
uint16(1),
|
|
"gigi",
|
|
"test.type",
|
|
[]byte(`{"name": "gigi"}`),
|
|
uint32(1),
|
|
uint32(0),
|
|
),
|
|
mock.WithQueryResult(
|
|
[]string{"created_at", "position"},
|
|
[][]driver.Value{
|
|
{
|
|
time.Now(),
|
|
decimal.NewFromFloat(123).String(),
|
|
},
|
|
},
|
|
),
|
|
),
|
|
},
|
|
},
|
|
want: want{
|
|
assertErr: expectNoErr,
|
|
},
|
|
},
|
|
{
|
|
name: "command reducer",
|
|
args: args{
|
|
reducer: &testReducer{
|
|
expectedReduces: 1,
|
|
},
|
|
commands: []*command{
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "testType", "testID"),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
Action: eventstore.Action[any]{
|
|
Creator: "gigi",
|
|
Revision: 1,
|
|
Type: "test.type",
|
|
},
|
|
},
|
|
sequence: 1,
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectQuery(
|
|
`INSERT INTO eventstore.events2 (instance_id, "owner", aggregate_type, aggregate_id, revision, creator, event_type, payload, "sequence", in_tx_order, created_at, "position") VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, statement_timestamp(), EXTRACT(EPOCH FROM clock_timestamp())) RETURNING created_at, "position"`,
|
|
mock.WithQueryArgs(
|
|
"instance",
|
|
"owner",
|
|
"testType",
|
|
"testID",
|
|
uint16(1),
|
|
"gigi",
|
|
"test.type",
|
|
mock.NilArg,
|
|
uint32(1),
|
|
uint32(0),
|
|
),
|
|
mock.WithQueryResult(
|
|
[]string{"created_at", "position"},
|
|
[][]driver.Value{
|
|
{
|
|
time.Now(),
|
|
decimal.NewFromFloat(123).String(),
|
|
},
|
|
},
|
|
),
|
|
),
|
|
},
|
|
},
|
|
want: want{
|
|
assertErr: expectNoErr,
|
|
},
|
|
},
|
|
{
|
|
name: "command reducer err",
|
|
args: args{
|
|
reducer: &testReducer{
|
|
expectedReduces: 1,
|
|
shouldErr: true,
|
|
},
|
|
commands: []*command{
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "testType", "testID"),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
Action: eventstore.Action[any]{
|
|
Creator: "gigi",
|
|
Revision: 1,
|
|
Type: "test.type",
|
|
},
|
|
},
|
|
sequence: 1,
|
|
},
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "testType", "testID"),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
Action: eventstore.Action[any]{
|
|
Creator: "gigi",
|
|
Revision: 1,
|
|
Type: "test.type2",
|
|
},
|
|
},
|
|
sequence: 2,
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectQuery(
|
|
`INSERT INTO eventstore.events2 (instance_id, "owner", aggregate_type, aggregate_id, revision, creator, event_type, payload, "sequence", in_tx_order, created_at, "position") VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, statement_timestamp(), EXTRACT(EPOCH FROM clock_timestamp())), ($11, $12, $13, $14, $15, $16, $17, $18, $19, $20, statement_timestamp(), EXTRACT(EPOCH FROM clock_timestamp())) RETURNING created_at, "position"`,
|
|
mock.WithQueryArgs(
|
|
"instance",
|
|
"owner",
|
|
"testType",
|
|
"testID",
|
|
uint16(1),
|
|
"gigi",
|
|
"test.type",
|
|
mock.NilArg,
|
|
uint32(1),
|
|
uint32(0),
|
|
"instance",
|
|
"owner",
|
|
"testType",
|
|
"testID",
|
|
uint16(1),
|
|
"gigi",
|
|
"test.type2",
|
|
mock.NilArg,
|
|
uint32(2),
|
|
uint32(1),
|
|
),
|
|
mock.WithQueryResult(
|
|
[]string{"created_at", "position"},
|
|
[][]driver.Value{
|
|
{
|
|
time.Now(),
|
|
decimal.NewFromFloat(123).String(),
|
|
},
|
|
{
|
|
time.Now(),
|
|
decimal.NewFromFloat(123.1).String(),
|
|
},
|
|
},
|
|
),
|
|
),
|
|
},
|
|
},
|
|
want: want{
|
|
assertErr: func(t *testing.T, err error) bool {
|
|
is := errors.Is(err, errReduce)
|
|
if !is {
|
|
t.Errorf("no error expected got: %v", err)
|
|
}
|
|
return is
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "1 aggregate 2 commands",
|
|
args: args{
|
|
reducer: &testReducer{
|
|
expectedReduces: 2,
|
|
},
|
|
commands: []*command{
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "testType", "testID"),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
Action: eventstore.Action[any]{
|
|
Creator: "gigi",
|
|
Revision: 1,
|
|
Type: "test.type",
|
|
},
|
|
},
|
|
sequence: 1,
|
|
},
|
|
{
|
|
intent: &intent{
|
|
PushAggregate: eventstore.NewPushIntent(
|
|
"instance",
|
|
eventstore.AppendAggregate("owner", "testType", "testID"),
|
|
).Aggregates()[0],
|
|
},
|
|
Command: &eventstore.Command{
|
|
Action: eventstore.Action[any]{
|
|
Creator: "gigi",
|
|
Revision: 1,
|
|
Type: "test.type2",
|
|
},
|
|
},
|
|
sequence: 2,
|
|
},
|
|
},
|
|
expectations: []mock.Expectation{
|
|
mock.ExpectQuery(
|
|
`INSERT INTO eventstore.events2 (instance_id, "owner", aggregate_type, aggregate_id, revision, creator, event_type, payload, "sequence", in_tx_order, created_at, "position") VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, statement_timestamp(), EXTRACT(EPOCH FROM clock_timestamp())), ($11, $12, $13, $14, $15, $16, $17, $18, $19, $20, statement_timestamp(), EXTRACT(EPOCH FROM clock_timestamp())) RETURNING created_at, "position"`,
|
|
mock.WithQueryArgs(
|
|
"instance",
|
|
"owner",
|
|
"testType",
|
|
"testID",
|
|
uint16(1),
|
|
"gigi",
|
|
"test.type",
|
|
mock.NilArg,
|
|
uint32(1),
|
|
uint32(0),
|
|
"instance",
|
|
"owner",
|
|
"testType",
|
|
"testID",
|
|
uint16(1),
|
|
"gigi",
|
|
"test.type2",
|
|
mock.NilArg,
|
|
uint32(2),
|
|
uint32(1),
|
|
),
|
|
mock.WithQueryResult(
|
|
[]string{"created_at", "position"},
|
|
[][]driver.Value{
|
|
{
|
|
time.Now(),
|
|
decimal.NewFromFloat(123).String(),
|
|
},
|
|
{
|
|
time.Now(),
|
|
decimal.NewFromFloat(123.1).String(),
|
|
},
|
|
},
|
|
),
|
|
),
|
|
},
|
|
},
|
|
want: want{
|
|
assertErr: expectNoErr,
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
dbMock := mock.NewSQLMock(t, append([]mock.Expectation{mock.ExpectBegin(nil)}, tt.args.expectations...)...)
|
|
tx, err := dbMock.DB.Begin()
|
|
if err != nil {
|
|
t.Errorf("unexpected error in begin: %v", err)
|
|
t.FailNow()
|
|
}
|
|
s := Storage{}
|
|
err = s.push(context.Background(), tx, tt.args.reducer, tt.args.commands)
|
|
tt.want.assertErr(t, err)
|
|
dbMock.Assert(t)
|
|
if tt.args.reducer != nil {
|
|
tt.args.reducer.assert(t)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func expectNoErr(t *testing.T, err error) bool {
|
|
is := err == nil
|
|
if !is {
|
|
t.Errorf("no error expected got: %v", err)
|
|
}
|
|
return is
|
|
}
|