mirror of
https://github.com/andwati/zitadel.git
synced 2026-10-18 05:52:51 +00:00
<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
# Which Problems Are Solved
Bulk unique-constraint deletes (org, IDP with many links, user, project)
reconstruct every uniqueness key in Go and emit N `DELETE`s. That can
OOM on large tenants.
A one-shot owner backfill is also not enough: during a rolling deploy,
older binaries still insert `owners = '{}'`, so a later owner-only
delete would miss those rows.
Owner-only org/user/grant delete only matches rows whose `owners` bag
contains that tag. Several grant and member types stamped the aggregate
resource owner, which is not always the user’s home org or the granted
org. Username-scope rewrites also dropped `user:` tags, so owner-only
user delete could miss rewritten username rows.
Command must not switch to owner-only delete on the first 79 of a
version, because leftover `'{}'` rows from rolling-update overlap are
only backfilled on a later 79. A failed 79 must not turn owner-delete
on, and backfill joins must not stamp the wrong org (unverified domains,
org-scoped usernames colliding with instance-scoped ones).
# How the Problems Are Solved
Uniqueness stays the existing primary key `(instance_id, unique_type,
unique_field)`. `owners` is only a lifecycle bag of tags (`org:<id>`,
`user:<id>`, `idp:<id>`, `project:<id>`, `grant:<id>`).
- Add `owners TEXT[] NOT NULL DEFAULT '{}'` on
`eventstore.unique_constraints` (init SQL for greenfield, setup 78 for
existing clusters).
- Create `unique_constraints_owners_gin` with `CREATE INDEX
CONCURRENTLY` **outside a transaction** (same pattern as step 76).
Built-in `GIN (owners)` only; no `btree_gin`.
- Stamp `WithOwners` on **add** events. Field-level removes ignore
owners. `RemoveByOwner` stores the tag in `Owners` and both v1/v3 and v2
pushers run `DELETE … WHERE instance_id = $1 AND owners @>
ARRAY[$tag]::text[]`.
- Setup 79 backfills `owners` from projections via numbered
`cmd/setup/79/*.sql` files. Table names are interpolated from
`internal/query/projection` constants. Matches use `unique_field IN (x,
lower(x))` so the primary key can be used. Missing projection tables
(`42P01`) are skipped.
- Org domains are tagged only when `is_verified`. Instance-scoped
usernames join only users that are not org-scoped (organization settings
or domain policy `user_login_must_be_domain`). Every username row still
gets `org:` + `user:` of that user.
- 79 is a **repeatable** migration. `Check` re-runs when
`lastRun["version"]` changed or when setup-only `ForceFinalize` is set
and `lastRun["finalized"]` is still false. `Finalized` is written only
after Execute succeeds.
- Failed setup events keep the last successful `lastRun`. Command reads
`finalized` only from `system.migration.repeatable.done`.
- Org / user / project remove skip N-key event replay **when that
`finalized` bit is true**. Otherwise they keep today’s N-key lists
**and** still emit `RemoveByOwner`. The “ready” result is cached in
memory once true.
Setup writes `finalized` on the 79 repeatable.done payload:
- First 79 of a version: backfill only, `finalized=false` (unless
`ForceFinalize` is already set).
- Later 79: version change or
`BackfillUniqueConstraintOwners.ForceFinalize` /
`ZITADEL_BACKFILLUNIQUECONSTRAINTOWNERS_FORCEFINALIZE` after the rolling
update is done. That run backfills leftovers and writes
`finalized=true`.
Member and grant owner bags now include every org that should delete the
row:
- Instance, org, and project members also stamp
`org:<user_resource_owner>`.
- User grants stamp grant, user, project, and granted orgs.
- Project grant members stamp the project org, user org, and granted
org.
- Project grants stamp both orgs plus `grant:<id>`. Grant remove emits
`RemoveByOwner(grant)`.
- Username-scope rewrites keep `user:<id>` as well as `org:`.
- User/grant orgs are carried as unexported add-event fields (not
persisted JSON). `WithOwners` skips empty and duplicate tags.
# Additional Changes
- Table-driven owner-tag tests, including project grant (two `org:` tags
plus `grant:`), cross-org members, user grants, and username-scope
rewrite `user:` tags.
- Table-driven 79 `Check` + `finalizeAfterSuccess` tests for version
change, sequential version bumps, ForceFinalize restart, and
already-finalized skip.
- Command tests: a failed 79 event with `finalized=true` does not enable
owner-delete.
- Integration fixtures (verified vs unverified org domain;
instance-scoped `bob` vs org-scoped `bob`).
- Instance-only and global unique types stay untagged (`'{}'`). Instance
wipe still uses `UniqueConstraintInstanceRemove`.
- Pusher owner cases live in `eventstore_pusher_owners_test.go` so
`eventstore_pusher_test.go` stays under 1k lines.
# Additional Context
A later cleanup can delete the N-key replay helpers once a release that
ran 79 a second time (or an operator who set `ForceFinalize`) is in
production. That is not required for correctness.
<!-- CURSOR_AGENT_PR_BODY_END -->
<div><a
href="https://cursor.com/agents/bc-44f9bc9b-9a93-4cd9-8dd1-663a7b9aad2a?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a
href="https://cursor.com/background-agent?bcId=bc-44f9bc9b-9a93-4cd9-8dd1-663a7b9aad2a&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div>
---------
Co-authored-by: Cursor Agent <[email protected]>
Co-authored-by: Silvan <[email protected]>
169 lines
4.3 KiB
Go
169 lines
4.3 KiB
Go
package migration
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"time"
|
|
|
|
"github.com/zitadel/zitadel/backend/v3/instrumentation/logging"
|
|
"github.com/zitadel/zitadel/internal/eventstore"
|
|
"github.com/zitadel/zitadel/internal/zerrors"
|
|
)
|
|
|
|
const (
|
|
StartedType = eventstore.EventType("system.migration.started")
|
|
DoneType = eventstore.EventType("system.migration.done")
|
|
failedType = eventstore.EventType("system.migration.failed")
|
|
repeatableDoneType = eventstore.EventType("system.migration.repeatable.done")
|
|
SystemAggregate = eventstore.AggregateType("system")
|
|
SystemAggregateID = "SYSTEM"
|
|
)
|
|
|
|
var (
|
|
errMigrationAlreadyStarted = errors.New("already started")
|
|
)
|
|
|
|
type Migration interface {
|
|
String() string
|
|
Execute(ctx context.Context, startedEvent eventstore.Event) error
|
|
}
|
|
|
|
type errCheckerMigration interface {
|
|
Migration
|
|
ContinueOnErr(err error) bool
|
|
}
|
|
|
|
type RepeatableMigration interface {
|
|
Migration
|
|
|
|
// Check if the migration should be executed again.
|
|
// True will repeat the migration, false will not.
|
|
Check(lastRun map[string]any) bool
|
|
}
|
|
|
|
func Migrate(ctx context.Context, es *eventstore.Eventstore, migration Migration) (err error) {
|
|
ctx = logging.With(ctx, "name", migration.String())
|
|
logging.Info(ctx, "verify migration")
|
|
|
|
continueOnErr := func(err error) bool {
|
|
return false
|
|
}
|
|
errChecker, ok := migration.(errCheckerMigration)
|
|
if ok {
|
|
continueOnErr = errChecker.ContinueOnErr
|
|
}
|
|
|
|
should, err := checkExec(ctx, es, migration)
|
|
if err != nil && !continueOnErr(err) {
|
|
return err
|
|
}
|
|
if !should {
|
|
return nil
|
|
}
|
|
|
|
startedEvent, err := es.Push(ctx, setupStartedCmd(ctx, migration))
|
|
if err != nil && !continueOnErr(err) {
|
|
return err
|
|
}
|
|
|
|
logging.Info(ctx, "starting migration")
|
|
err = migration.Execute(ctx, startedEvent[0])
|
|
logging.OnError(ctx, err).Error("migration failed")
|
|
|
|
_, pushErr := es.Push(ctx, setupDoneCmd(ctx, migration, err))
|
|
logging.OnError(ctx, pushErr).Error("migration finish failed")
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return pushErr
|
|
}
|
|
|
|
func LastStuckStep(ctx context.Context, es *eventstore.Eventstore) (*SetupStep, error) {
|
|
var states StepStates
|
|
err := es.FilterToQueryReducer(ctx, &states)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
step := states.lastByState(StepStarted)
|
|
if step == nil {
|
|
return nil, nil
|
|
}
|
|
|
|
return step.SetupStep, nil
|
|
}
|
|
|
|
var _ Migration = (*cancelMigration)(nil)
|
|
|
|
type cancelMigration struct {
|
|
name string
|
|
}
|
|
|
|
// Execute implements Migration
|
|
func (*cancelMigration) Execute(context.Context, eventstore.Event) error {
|
|
return nil
|
|
}
|
|
|
|
// String implements Migration
|
|
func (m *cancelMigration) String() string {
|
|
return m.name
|
|
}
|
|
|
|
var errCancelStep = zerrors.ThrowError(nil, "MIGRA-zo86K", "migration canceled manually")
|
|
|
|
func CancelStep(ctx context.Context, es *eventstore.Eventstore, step *SetupStep) error {
|
|
_, err := es.Push(ctx, setupDoneCmd(ctx, &cancelMigration{name: step.Name}, errCancelStep))
|
|
return err
|
|
}
|
|
|
|
// checkExec ensures that only one setup step is done concurrently
|
|
// if a setup step is already started, it calls shouldExec after some time again
|
|
func checkExec(ctx context.Context, es *eventstore.Eventstore, migration Migration) (bool, error) {
|
|
timer := time.NewTimer(0)
|
|
for {
|
|
select {
|
|
case <-ctx.Done():
|
|
return false, zerrors.ThrowInternal(nil, "MIGR-as3f7", "Errors.Internal")
|
|
case <-timer.C:
|
|
should, err := shouldExec(ctx, es, migration)
|
|
if err != nil {
|
|
if !errors.Is(err, errMigrationAlreadyStarted) {
|
|
return false, err
|
|
}
|
|
logging.Warn(ctx, "migration already started, will check again in 5 seconds")
|
|
timer.Reset(5 * time.Second)
|
|
break
|
|
}
|
|
return should, nil
|
|
}
|
|
}
|
|
}
|
|
|
|
func shouldExec(ctx context.Context, es *eventstore.Eventstore, migration Migration) (should bool, err error) {
|
|
var states StepStates
|
|
err = es.FilterToQueryReducer(ctx, &states)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
step := states.byName(migration.String())
|
|
if step == nil {
|
|
return true, nil
|
|
}
|
|
if step.state == StepFailed {
|
|
if repeatable, ok := migration.(RepeatableMigration); ok {
|
|
lastRun, _ := step.LastRun.(map[string]interface{})
|
|
repeatable.Check(lastRun)
|
|
}
|
|
return true, nil
|
|
}
|
|
if step.state == StepStarted {
|
|
return false, errMigrationAlreadyStarted
|
|
}
|
|
|
|
repeatable, ok := migration.(RepeatableMigration)
|
|
if !ok {
|
|
return step.state != StepDone, nil
|
|
}
|
|
lastRun, _ := step.LastRun.(map[string]interface{})
|
|
return repeatable.Check(lastRun), nil
|
|
}
|