mirror of
https://github.com/andwati/zitadel.git
synced 2026-10-18 05:52:51 +00:00
<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
# Which Problems Are Solved
Bulk unique-constraint deletes (org, IDP with many links, user, project)
reconstruct every uniqueness key in Go and emit N `DELETE`s. That can
OOM on large tenants.
A one-shot owner backfill is also not enough: during a rolling deploy,
older binaries still insert `owners = '{}'`, so a later owner-only
delete would miss those rows.
Owner-only org/user/grant delete only matches rows whose `owners` bag
contains that tag. Several grant and member types stamped the aggregate
resource owner, which is not always the user’s home org or the granted
org. Username-scope rewrites also dropped `user:` tags, so owner-only
user delete could miss rewritten username rows.
Command must not switch to owner-only delete on the first 79 of a
version, because leftover `'{}'` rows from rolling-update overlap are
only backfilled on a later 79. A failed 79 must not turn owner-delete
on, and backfill joins must not stamp the wrong org (unverified domains,
org-scoped usernames colliding with instance-scoped ones).
# How the Problems Are Solved
Uniqueness stays the existing primary key `(instance_id, unique_type,
unique_field)`. `owners` is only a lifecycle bag of tags (`org:<id>`,
`user:<id>`, `idp:<id>`, `project:<id>`, `grant:<id>`).
- Add `owners TEXT[] NOT NULL DEFAULT '{}'` on
`eventstore.unique_constraints` (init SQL for greenfield, setup 78 for
existing clusters).
- Create `unique_constraints_owners_gin` with `CREATE INDEX
CONCURRENTLY` **outside a transaction** (same pattern as step 76).
Built-in `GIN (owners)` only; no `btree_gin`.
- Stamp `WithOwners` on **add** events. Field-level removes ignore
owners. `RemoveByOwner` stores the tag in `Owners` and both v1/v3 and v2
pushers run `DELETE … WHERE instance_id = $1 AND owners @>
ARRAY[$tag]::text[]`.
- Setup 79 backfills `owners` from projections via numbered
`cmd/setup/79/*.sql` files. Table names are interpolated from
`internal/query/projection` constants. Matches use `unique_field IN (x,
lower(x))` so the primary key can be used. Missing projection tables
(`42P01`) are skipped.
- Org domains are tagged only when `is_verified`. Instance-scoped
usernames join only users that are not org-scoped (organization settings
or domain policy `user_login_must_be_domain`). Every username row still
gets `org:` + `user:` of that user.
- 79 is a **repeatable** migration. `Check` re-runs when
`lastRun["version"]` changed or when setup-only `ForceFinalize` is set
and `lastRun["finalized"]` is still false. `Finalized` is written only
after Execute succeeds.
- Failed setup events keep the last successful `lastRun`. Command reads
`finalized` only from `system.migration.repeatable.done`.
- Org / user / project remove skip N-key event replay **when that
`finalized` bit is true**. Otherwise they keep today’s N-key lists
**and** still emit `RemoveByOwner`. The “ready” result is cached in
memory once true.
Setup writes `finalized` on the 79 repeatable.done payload:
- First 79 of a version: backfill only, `finalized=false` (unless
`ForceFinalize` is already set).
- Later 79: version change or
`BackfillUniqueConstraintOwners.ForceFinalize` /
`ZITADEL_BACKFILLUNIQUECONSTRAINTOWNERS_FORCEFINALIZE` after the rolling
update is done. That run backfills leftovers and writes
`finalized=true`.
Member and grant owner bags now include every org that should delete the
row:
- Instance, org, and project members also stamp
`org:<user_resource_owner>`.
- User grants stamp grant, user, project, and granted orgs.
- Project grant members stamp the project org, user org, and granted
org.
- Project grants stamp both orgs plus `grant:<id>`. Grant remove emits
`RemoveByOwner(grant)`.
- Username-scope rewrites keep `user:<id>` as well as `org:`.
- User/grant orgs are carried as unexported add-event fields (not
persisted JSON). `WithOwners` skips empty and duplicate tags.
# Additional Changes
- Table-driven owner-tag tests, including project grant (two `org:` tags
plus `grant:`), cross-org members, user grants, and username-scope
rewrite `user:` tags.
- Table-driven 79 `Check` + `finalizeAfterSuccess` tests for version
change, sequential version bumps, ForceFinalize restart, and
already-finalized skip.
- Command tests: a failed 79 event with `finalized=true` does not enable
owner-delete.
- Integration fixtures (verified vs unverified org domain;
instance-scoped `bob` vs org-scoped `bob`).
- Instance-only and global unique types stay untagged (`'{}'`). Instance
wipe still uses `UniqueConstraintInstanceRemove`.
- Pusher owner cases live in `eventstore_pusher_owners_test.go` so
`eventstore_pusher_test.go` stays under 1k lines.
# Additional Context
A later cleanup can delete the N-key replay helpers once a release that
ran 79 a second time (or an operator who set `ForceFinalize`) is in
production. That is not required for correctness.
<!-- CURSOR_AGENT_PR_BODY_END -->
<div><a
href="https://cursor.com/agents/bc-44f9bc9b-9a93-4cd9-8dd1-663a7b9aad2a?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a
href="https://cursor.com/background-agent?bcId=bc-44f9bc9b-9a93-4cd9-8dd1-663a7b9aad2a&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div>
---------
Co-authored-by: Cursor Agent <[email protected]>
Co-authored-by: Silvan <[email protected]>
539 lines
20 KiB
Go
539 lines
20 KiB
Go
package command
|
|
|
|
import (
|
|
"context"
|
|
"slices"
|
|
|
|
"github.com/zitadel/zitadel/internal/api/authz"
|
|
"github.com/zitadel/zitadel/internal/domain"
|
|
"github.com/zitadel/zitadel/internal/eventstore"
|
|
"github.com/zitadel/zitadel/internal/feature"
|
|
"github.com/zitadel/zitadel/internal/repository/org"
|
|
"github.com/zitadel/zitadel/internal/repository/project"
|
|
"github.com/zitadel/zitadel/internal/repository/usergrant"
|
|
"github.com/zitadel/zitadel/internal/telemetry/tracing"
|
|
"github.com/zitadel/zitadel/internal/zerrors"
|
|
)
|
|
|
|
// AddUserGrant authorizes a user for a project with the given role keys.
|
|
// The project must be owned by or granted to the resourceOwner.
|
|
// If the resourceOwner is nil, the project must be owned by the project that belongs to usergrant.ProjectID.
|
|
func (c *Commands) AddUserGrant(ctx context.Context, usergrant *domain.UserGrant, check UserGrantPermissionCheck) (_ *domain.UserGrant, err error) {
|
|
ctx, span := tracing.NewSpan(ctx)
|
|
defer func() { span.EndWithError(err) }()
|
|
|
|
event, addedUserGrant, err := c.addUserGrant(ctx, usergrant, check)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
pushedEvents, err := c.eventstore.Push(ctx, event)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
err = AppendAndReduce(addedUserGrant, pushedEvents...)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return userGrantWriteModelToUserGrant(addedUserGrant), nil
|
|
}
|
|
|
|
func (c *Commands) addUserGrant(ctx context.Context, userGrant *domain.UserGrant, check UserGrantPermissionCheck) (command eventstore.Command, _ *UserGrantWriteModel, err error) {
|
|
if !userGrant.IsValid() {
|
|
return nil, nil, zerrors.ThrowInvalidArgument(nil, "COMMAND-kVfMa", "Errors.UserGrant.Invalid")
|
|
}
|
|
owners, err := c.checkUserGrantPreCondition(ctx, userGrant, check)
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
userGrant.AggregateID, err = c.idGenerator.Next()
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
|
|
addedUserGrant := NewUserGrantWriteModel(userGrant.AggregateID, userGrant.ResourceOwner)
|
|
userGrantAgg := UserGrantAggregateFromWriteModel(&addedUserGrant.WriteModel)
|
|
command = usergrant.NewUserGrantAddedEvent(
|
|
ctx,
|
|
userGrantAgg,
|
|
userGrant.UserID,
|
|
userGrant.ProjectID,
|
|
userGrant.ProjectGrantID,
|
|
userGrant.RoleKeys,
|
|
).WithOwnerOrgs(owners.userResourceOwner, owners.projectResourceOwner, owners.grantedOrg)
|
|
return command, addedUserGrant, nil
|
|
}
|
|
|
|
func (c *Commands) ChangeUserGrant(ctx context.Context, userGrant *domain.UserGrant, cascade, ignoreUnchanged bool, check UserGrantPermissionCheck) (_ *domain.UserGrant, err error) {
|
|
if userGrant.AggregateID == "" {
|
|
return nil, zerrors.ThrowInvalidArgument(nil, "COMMAND-3M0sd", "Errors.UserGrant.Invalid")
|
|
}
|
|
existingUserGrant, err := c.userGrantWriteModelByID(ctx, userGrant.AggregateID, "")
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if existingUserGrant.State == domain.UserGrantStateUnspecified || existingUserGrant.State == domain.UserGrantStateRemoved {
|
|
return nil, zerrors.ThrowNotFound(nil, "COMMAND-3M9sd", "Errors.UserGrant.NotFound")
|
|
}
|
|
|
|
grantUnchanged := slices.Equal(existingUserGrant.RoleKeys, userGrant.RoleKeys)
|
|
if grantUnchanged {
|
|
if ignoreUnchanged {
|
|
return userGrantWriteModelToUserGrant(existingUserGrant), nil
|
|
}
|
|
return nil, zerrors.ThrowPreconditionFailed(nil, "COMMAND-Rs8fy", "Errors.UserGrant.NotChanged")
|
|
}
|
|
userGrant.UserID = existingUserGrant.UserID
|
|
userGrant.ProjectID = existingUserGrant.ProjectID
|
|
userGrant.ProjectGrantID = existingUserGrant.ProjectGrantID
|
|
userGrant.ResourceOwner = existingUserGrant.ResourceOwner
|
|
|
|
_, err = c.checkUserGrantPreCondition(ctx, userGrant, check)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
changedUserGrant := NewUserGrantWriteModel(userGrant.AggregateID, userGrant.ResourceOwner)
|
|
userGrantAgg := UserGrantAggregateFromWriteModel(&changedUserGrant.WriteModel)
|
|
|
|
var event eventstore.Command = usergrant.NewUserGrantChangedEvent(ctx, userGrantAgg, existingUserGrant.UserID, userGrant.RoleKeys)
|
|
if cascade {
|
|
event = usergrant.NewUserGrantCascadeChangedEvent(ctx, userGrantAgg, userGrant.RoleKeys)
|
|
}
|
|
pushedEvents, err := c.eventstore.Push(ctx, event)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
err = AppendAndReduce(existingUserGrant, pushedEvents...)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return userGrantWriteModelToUserGrant(existingUserGrant), nil
|
|
}
|
|
|
|
func (c *Commands) removeRoleFromUserGrant(ctx context.Context, userGrantID string, roleKeysToRemove map[string]bool, cascade bool) (_ eventstore.Command, err error) {
|
|
existingUserGrant, err := c.userGrantWriteModelByID(ctx, userGrantID, "")
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if existingUserGrant.State == domain.UserGrantStateUnspecified || existingUserGrant.State == domain.UserGrantStateRemoved {
|
|
return nil, zerrors.ThrowNotFound(nil, "COMMAND-3M9sd", "Errors.UserGrant.NotFound")
|
|
}
|
|
|
|
beforeLen := len(existingUserGrant.RoleKeys)
|
|
existingUserGrant.RoleKeys = slices.DeleteFunc(existingUserGrant.RoleKeys, func(role string) bool {
|
|
return roleKeysToRemove[role]
|
|
})
|
|
|
|
if beforeLen == len(existingUserGrant.RoleKeys) {
|
|
return nil, zerrors.ThrowPreconditionFailed(nil, "COMMAND-5m8g9", "Errors.UserGrant.RoleKeyNotFound")
|
|
}
|
|
|
|
changedUserGrant := NewUserGrantWriteModel(userGrantID, existingUserGrant.ResourceOwner)
|
|
userGrantAgg := UserGrantAggregateFromWriteModel(&changedUserGrant.WriteModel)
|
|
|
|
if cascade {
|
|
return usergrant.NewUserGrantCascadeChangedEvent(ctx, userGrantAgg, existingUserGrant.RoleKeys), nil
|
|
}
|
|
|
|
return usergrant.NewUserGrantChangedEvent(ctx, userGrantAgg, existingUserGrant.UserID, existingUserGrant.RoleKeys), nil
|
|
}
|
|
|
|
func (c *Commands) DeactivateUserGrant(ctx context.Context, grantID string, resourceOwner string, check UserGrantPermissionCheck) (objectDetails *domain.ObjectDetails, err error) {
|
|
if grantID == "" {
|
|
return nil, zerrors.ThrowInvalidArgument(nil, "COMMAND-N2OhG", "Errors.UserGrant.IDMissing")
|
|
}
|
|
|
|
existingUserGrant, err := c.userGrantWriteModelByID(ctx, grantID, resourceOwner)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if existingUserGrant.State == domain.UserGrantStateUnspecified || existingUserGrant.State == domain.UserGrantStateRemoved {
|
|
return nil, zerrors.ThrowNotFound(nil, "COMMAND-3M9sd", "Errors.UserGrant.NotFound")
|
|
}
|
|
if existingUserGrant.State != domain.UserGrantStateActive {
|
|
return writeModelToObjectDetails(&existingUserGrant.WriteModel), nil
|
|
}
|
|
if check != nil {
|
|
err = check(existingUserGrant.ProjectID, existingUserGrant.ProjectGrantID)(existingUserGrant.ResourceOwner, "")
|
|
} else {
|
|
err = checkExplicitProjectPermission(ctx, existingUserGrant.ProjectGrantID, existingUserGrant.ProjectID)
|
|
}
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
deactivateUserGrant := NewUserGrantWriteModel(grantID, existingUserGrant.ResourceOwner)
|
|
userGrantAgg := UserGrantAggregateFromWriteModel(&deactivateUserGrant.WriteModel)
|
|
pushedEvents, err := c.eventstore.Push(ctx, usergrant.NewUserGrantDeactivatedEvent(ctx, userGrantAgg))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
err = AppendAndReduce(existingUserGrant, pushedEvents...)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return writeModelToObjectDetails(&existingUserGrant.WriteModel), nil
|
|
}
|
|
|
|
func (c *Commands) ReactivateUserGrant(ctx context.Context, grantID string, resourceOwner string, check UserGrantPermissionCheck) (objectDetails *domain.ObjectDetails, err error) {
|
|
if grantID == "" {
|
|
return nil, zerrors.ThrowInvalidArgument(nil, "COMMAND-Qxy8v", "Errors.UserGrant.IDMissing")
|
|
}
|
|
|
|
existingUserGrant, err := c.userGrantWriteModelByID(ctx, grantID, resourceOwner)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if existingUserGrant.State == domain.UserGrantStateUnspecified || existingUserGrant.State == domain.UserGrantStateRemoved {
|
|
return nil, zerrors.ThrowNotFound(nil, "COMMAND-Lp0gs", "Errors.UserGrant.NotFound")
|
|
}
|
|
if existingUserGrant.State != domain.UserGrantStateInactive {
|
|
return writeModelToObjectDetails(&existingUserGrant.WriteModel), nil
|
|
}
|
|
if check != nil {
|
|
err = check(existingUserGrant.ProjectID, existingUserGrant.ProjectGrantID)(existingUserGrant.ResourceOwner, "")
|
|
} else {
|
|
err = checkExplicitProjectPermission(ctx, existingUserGrant.ProjectGrantID, existingUserGrant.ProjectID)
|
|
}
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
deactivateUserGrant := NewUserGrantWriteModel(grantID, existingUserGrant.ResourceOwner)
|
|
userGrantAgg := UserGrantAggregateFromWriteModel(&deactivateUserGrant.WriteModel)
|
|
pushedEvents, err := c.eventstore.Push(ctx, usergrant.NewUserGrantReactivatedEvent(ctx, userGrantAgg))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
err = AppendAndReduce(existingUserGrant, pushedEvents...)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return writeModelToObjectDetails(&existingUserGrant.WriteModel), nil
|
|
}
|
|
|
|
func (c *Commands) RemoveUserGrant(ctx context.Context, grantID string, resourceOwner string, ignoreNotFound bool, check UserGrantPermissionCheck) (objectDetails *domain.ObjectDetails, err error) {
|
|
event, existingUserGrant, err := c.removeUserGrant(ctx, grantID, resourceOwner, false, ignoreNotFound, check)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if event == nil {
|
|
return writeModelToObjectDetails(&existingUserGrant.WriteModel), nil
|
|
}
|
|
pushedEvents, err := c.eventstore.Push(ctx, event)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
err = AppendAndReduce(existingUserGrant, pushedEvents...)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return writeModelToObjectDetails(&existingUserGrant.WriteModel), nil
|
|
}
|
|
|
|
func (c *Commands) BulkRemoveUserGrant(ctx context.Context, grantIDs []string, resourceOwner string) (err error) {
|
|
if len(grantIDs) == 0 {
|
|
return zerrors.ThrowInvalidArgument(nil, "COMMAND-5M0sd", "Errors.UserGrant.IDMissing")
|
|
}
|
|
events := make([]eventstore.Command, len(grantIDs))
|
|
for i, grantID := range grantIDs {
|
|
event, _, err := c.removeUserGrant(ctx, grantID, resourceOwner, false, false, nil)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
events[i] = event
|
|
}
|
|
_, err = c.eventstore.Push(ctx, events...)
|
|
return err
|
|
}
|
|
|
|
func (c *Commands) removeUserGrant(ctx context.Context, grantID string, resourceOwner string, cascade, ignoreNotFound bool, check UserGrantPermissionCheck) (_ eventstore.Command, writeModel *UserGrantWriteModel, err error) {
|
|
if grantID == "" {
|
|
return nil, nil, zerrors.ThrowInvalidArgument(nil, "COMMAND-J9sc5", "Errors.UserGrant.IDMissing")
|
|
}
|
|
|
|
existingUserGrant, err := c.userGrantWriteModelByID(ctx, grantID, resourceOwner)
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
if existingUserGrant.State == domain.UserGrantStateUnspecified || existingUserGrant.State == domain.UserGrantStateRemoved {
|
|
if ignoreNotFound {
|
|
return nil, existingUserGrant, nil
|
|
}
|
|
return nil, nil, zerrors.ThrowNotFound(nil, "COMMAND-1My0t", "Errors.UserGrant.NotFound")
|
|
}
|
|
if !cascade && check == nil {
|
|
err = checkExplicitProjectPermission(ctx, existingUserGrant.ProjectGrantID, existingUserGrant.ProjectID)
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
}
|
|
if check != nil {
|
|
if err = check(existingUserGrant.ProjectID, existingUserGrant.ProjectGrantID)(existingUserGrant.ResourceOwner, ""); err != nil {
|
|
return nil, nil, err
|
|
}
|
|
}
|
|
removeUserGrant := NewUserGrantWriteModel(grantID, existingUserGrant.ResourceOwner)
|
|
userGrantAgg := UserGrantAggregateFromWriteModel(&removeUserGrant.WriteModel)
|
|
if cascade {
|
|
return usergrant.NewUserGrantCascadeRemovedEvent(
|
|
ctx,
|
|
userGrantAgg,
|
|
existingUserGrant.UserID,
|
|
existingUserGrant.ProjectID,
|
|
existingUserGrant.ProjectGrantID), existingUserGrant, nil
|
|
}
|
|
return usergrant.NewUserGrantRemovedEvent(
|
|
ctx,
|
|
userGrantAgg,
|
|
existingUserGrant.UserID,
|
|
existingUserGrant.ProjectID,
|
|
existingUserGrant.ProjectGrantID), existingUserGrant, nil
|
|
}
|
|
|
|
func (c *Commands) userGrantWriteModelByID(ctx context.Context, userGrantID string, resourceOwner string) (writeModel *UserGrantWriteModel, err error) {
|
|
ctx, span := tracing.NewSpan(ctx)
|
|
defer func() { span.EndWithError(err) }()
|
|
|
|
writeModel = NewUserGrantWriteModel(userGrantID, resourceOwner)
|
|
err = c.eventstore.FilterToQueryReducer(ctx, writeModel)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return writeModel, nil
|
|
}
|
|
|
|
type userGrantOwners struct {
|
|
userResourceOwner string
|
|
projectResourceOwner string
|
|
grantedOrg string
|
|
}
|
|
|
|
func (c *Commands) checkUserGrantPreCondition(ctx context.Context, usergrant *domain.UserGrant, check UserGrantPermissionCheck) (owners userGrantOwners, err error) {
|
|
if !authz.GetFeatures(ctx).ShouldUseImprovedPerformance(feature.ImprovedPerformanceTypeUserGrant) {
|
|
return c.checkUserGrantPreConditionOld(ctx, usergrant, check)
|
|
}
|
|
|
|
ctx, span := tracing.NewSpan(ctx)
|
|
defer func() { span.EndWithError(err) }()
|
|
|
|
userResourceOwner, err := c.checkUserExists(ctx, usergrant.UserID, "")
|
|
if err != nil {
|
|
return userGrantOwners{}, err
|
|
}
|
|
if usergrant.ProjectGrantID != "" || usergrant.ResourceOwner == "" {
|
|
projectOwner, grantID, err := c.searchProjectOwnerAndGrantID(ctx, usergrant.ProjectID, "")
|
|
if err != nil {
|
|
return userGrantOwners{}, err
|
|
}
|
|
if usergrant.ResourceOwner == "" {
|
|
usergrant.ResourceOwner = projectOwner
|
|
}
|
|
if usergrant.ProjectGrantID == "" {
|
|
usergrant.ProjectGrantID = grantID
|
|
}
|
|
owners.projectResourceOwner = projectOwner
|
|
}
|
|
if owners.projectResourceOwner == "" {
|
|
owners.projectResourceOwner = usergrant.ResourceOwner
|
|
}
|
|
existingRoleKeys, err := c.searchUserGrantPreConditionState(ctx, usergrant)
|
|
if err != nil {
|
|
return userGrantOwners{}, err
|
|
}
|
|
if usergrant.HasInvalidRoles(existingRoleKeys) {
|
|
return userGrantOwners{}, zerrors.ThrowPreconditionFailed(err, "COMMAND-mm9F4", "Errors.Project.Role.NotFound")
|
|
}
|
|
if check != nil {
|
|
if err := check(usergrant.ProjectID, usergrant.ProjectGrantID)(usergrant.ResourceOwner, ""); err != nil {
|
|
return userGrantOwners{}, err
|
|
}
|
|
}
|
|
owners.userResourceOwner = userResourceOwner
|
|
if usergrant.ProjectGrantID != "" {
|
|
owners.grantedOrg = usergrant.ResourceOwner
|
|
}
|
|
return owners, nil
|
|
}
|
|
|
|
// this code needs to be rewritten anyways as soon as we improved the fields handling
|
|
//
|
|
//nolint:gocognit
|
|
func (c *Commands) searchUserGrantPreConditionState(ctx context.Context, userGrant *domain.UserGrant) (existingRoleKeys []string, err error) {
|
|
criteria := []map[eventstore.FieldType]any{
|
|
// project state query
|
|
{
|
|
eventstore.FieldTypeAggregateType: project.AggregateType,
|
|
eventstore.FieldTypeAggregateID: userGrant.ProjectID,
|
|
eventstore.FieldTypeFieldName: project.ProjectStateSearchField,
|
|
eventstore.FieldTypeObjectType: project.ProjectSearchType,
|
|
},
|
|
// granted org query
|
|
{
|
|
eventstore.FieldTypeAggregateType: org.AggregateType,
|
|
eventstore.FieldTypeAggregateID: userGrant.ResourceOwner,
|
|
eventstore.FieldTypeFieldName: org.OrgStateSearchField,
|
|
eventstore.FieldTypeObjectType: org.OrgSearchType,
|
|
},
|
|
}
|
|
if userGrant.ProjectGrantID != "" {
|
|
criteria = append(criteria, map[eventstore.FieldType]any{
|
|
eventstore.FieldTypeAggregateType: project.AggregateType,
|
|
eventstore.FieldTypeAggregateID: userGrant.ProjectID,
|
|
eventstore.FieldTypeObjectType: project.ProjectGrantSearchType,
|
|
eventstore.FieldTypeObjectID: userGrant.ProjectGrantID,
|
|
})
|
|
} else {
|
|
criteria = append(criteria, map[eventstore.FieldType]any{
|
|
eventstore.FieldTypeAggregateType: project.AggregateType,
|
|
eventstore.FieldTypeAggregateID: userGrant.ProjectID,
|
|
eventstore.FieldTypeObjectType: project.ProjectRoleSearchType,
|
|
eventstore.FieldTypeFieldName: project.ProjectRoleKeySearchField,
|
|
})
|
|
}
|
|
results, err := c.eventstore.Search(ctx, criteria...)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
var (
|
|
existsProject bool
|
|
existsGrantedOrg bool
|
|
existsGrant bool
|
|
)
|
|
|
|
for _, result := range results {
|
|
switch result.Object.Type {
|
|
case project.ProjectRoleSearchType:
|
|
var role string
|
|
err := result.Value.Unmarshal(&role)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
existingRoleKeys = append(existingRoleKeys, role)
|
|
case org.OrgSearchType:
|
|
var state domain.OrgState
|
|
err := result.Value.Unmarshal(&state)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
existsGrantedOrg = state.Valid() && state != domain.OrgStateRemoved
|
|
case project.ProjectSearchType:
|
|
var state domain.ProjectState
|
|
err := result.Value.Unmarshal(&state)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
existsProject = state.Valid() && state != domain.ProjectStateRemoved
|
|
case project.ProjectGrantSearchType:
|
|
switch result.FieldName {
|
|
case project.ProjectGrantGrantedOrgIDSearchField:
|
|
var orgID string
|
|
err := result.Value.Unmarshal(&orgID)
|
|
if err != nil || orgID != userGrant.ResourceOwner {
|
|
return nil, zerrors.ThrowPreconditionFailed(err, "COMMAND-3m9gg", "Errors.Org.NotFound")
|
|
}
|
|
case project.ProjectGrantStateSearchField:
|
|
var state domain.ProjectGrantState
|
|
err := result.Value.Unmarshal(&state)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
existsGrant = state.Valid() && state != domain.ProjectGrantStateRemoved
|
|
case project.ProjectGrantRoleKeySearchField:
|
|
var role string
|
|
err := result.Value.Unmarshal(&role)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
existingRoleKeys = append(existingRoleKeys, role)
|
|
case project.ProjectGrantGrantIDSearchField:
|
|
var grantID string
|
|
err := result.Value.Unmarshal(&grantID)
|
|
if err != nil || grantID != userGrant.ProjectGrantID {
|
|
return nil, zerrors.ThrowPreconditionFailed(err, "COMMAND-huvKF", "Errors.Project.Grant.NotFound")
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
if !existsProject {
|
|
return nil, zerrors.ThrowPreconditionFailed(err, "COMMAND-m9gsd", "Errors.Project.NotFound")
|
|
}
|
|
if !existsGrantedOrg {
|
|
return nil, zerrors.ThrowPreconditionFailed(err, "COMMAND-3m9gg", "Errors.Org.NotFound")
|
|
}
|
|
if userGrant.ProjectGrantID != "" && !existsGrant {
|
|
return nil, zerrors.ThrowPreconditionFailed(err, "COMMAND-huvKF", "Errors.Project.Grant.NotFound")
|
|
}
|
|
return existingRoleKeys, nil
|
|
}
|
|
|
|
func (c *Commands) checkUserGrantPreConditionOld(ctx context.Context, usergrant *domain.UserGrant, check UserGrantPermissionCheck) (owners userGrantOwners, err error) {
|
|
ctx, span := tracing.NewSpan(ctx)
|
|
defer func() { span.EndWithError(err) }()
|
|
|
|
preConditions := NewUserGrantPreConditionReadModel(usergrant.UserID, usergrant.ProjectID, usergrant.ProjectGrantID, usergrant.ResourceOwner)
|
|
err = c.eventstore.FilterToQueryReducer(ctx, preConditions)
|
|
if err != nil {
|
|
return userGrantOwners{}, err
|
|
}
|
|
if usergrant.ResourceOwner == "" {
|
|
usergrant.ResourceOwner = preConditions.ProjectResourceOwner
|
|
}
|
|
if usergrant.ProjectGrantID == "" {
|
|
usergrant.ProjectGrantID = preConditions.FoundGrantID
|
|
}
|
|
if !preConditions.UserExists {
|
|
return userGrantOwners{}, zerrors.ThrowPreconditionFailed(err, "COMMAND-4f8sg", "Errors.User.NotFound")
|
|
}
|
|
projectIsOwned := usergrant.ResourceOwner == "" || usergrant.ResourceOwner == preConditions.ProjectResourceOwner
|
|
if projectIsOwned && !preConditions.ProjectExists {
|
|
return userGrantOwners{}, zerrors.ThrowPreconditionFailed(err, "COMMAND-3n77S", "Errors.Project.NotFound")
|
|
}
|
|
if !projectIsOwned && preConditions.FoundGrantID == "" {
|
|
return userGrantOwners{}, zerrors.ThrowPreconditionFailed(err, "COMMAND-4m9ff", "Errors.Project.Grant.NotFound")
|
|
}
|
|
// Either check roles from project or project grant
|
|
if usergrant.HasInvalidRoles(preConditions.existingRoles()) {
|
|
return userGrantOwners{}, zerrors.ThrowPreconditionFailed(err, "COMMAND-mm9F4", "Errors.Project.Role.NotFound")
|
|
}
|
|
if check != nil {
|
|
if err := check(usergrant.ProjectID, usergrant.ProjectGrantID)(usergrant.ResourceOwner, ""); err != nil {
|
|
return userGrantOwners{}, err
|
|
}
|
|
}
|
|
owners.userResourceOwner = preConditions.UserResourceOwner
|
|
owners.projectResourceOwner = preConditions.ProjectResourceOwner
|
|
if usergrant.ProjectGrantID != "" {
|
|
owners.grantedOrg = usergrant.ResourceOwner
|
|
}
|
|
return owners, nil
|
|
}
|
|
|
|
func (c *Commands) searchProjectOwnerAndGrantID(ctx context.Context, projectID string, grantedOrgID string) (projectOwner string, grantID string, err error) {
|
|
grantIDQuery := map[eventstore.FieldType]any{
|
|
eventstore.FieldTypeAggregateType: project.AggregateType,
|
|
eventstore.FieldTypeAggregateID: projectID,
|
|
eventstore.FieldTypeFieldName: project.ProjectGrantGrantedOrgIDSearchField,
|
|
}
|
|
if grantedOrgID != "" {
|
|
grantIDQuery[eventstore.FieldTypeValue] = grantedOrgID
|
|
grantIDQuery[eventstore.FieldTypeObjectType] = project.ProjectGrantSearchType
|
|
|
|
}
|
|
results, err := c.eventstore.Search(ctx, grantIDQuery)
|
|
if err != nil {
|
|
return "", "", err
|
|
}
|
|
for _, result := range results {
|
|
projectOwner = result.Aggregate.ResourceOwner
|
|
if grantedOrgID != "" && grantedOrgID == projectOwner {
|
|
return projectOwner, "", nil
|
|
}
|
|
if result.Object.Type == project.ProjectGrantSearchType {
|
|
return projectOwner, result.Object.ID, nil
|
|
}
|
|
}
|
|
return projectOwner, grantID, err
|
|
}
|