mirror of
https://github.com/andwati/zitadel.git
synced 2026-11-01 20:02:15 +00:00
# Which Problems Are Solved The `/.well-known/apple-app-site-association` and `/.well-known/assetlinks.json` responses are instance specific: the body depends on the requested host. The responses did not declare this, so a shared cache whose cache key does not include the host could store one instance's file and serve it on another instance's domain. This could result in a wrong or empty file being returned intermittently, breaking native passkey verification. Dropping the `public` directive (#12634) was not sufficient: depending on its cache mode, a shared cache may store any response carrying a `max-age`. The docs page for native app links also still documented the old `Cache-Control: public` header and only the single `get_login_creds` relation (missing `handle_all_urls`, added in #12634). # How the Problems Are Solved - Send **`Vary: Host`** on both well-known responses, declaring that the body depends on the host: a spec-compliant shared cache must store per-host variants or skip caching. Clients addressing a single host (the Apple and Google verifiers, browsers) are unaffected and keep honoring the configured `max-age`. - Correct the outdated caching reasoning in the code comments. - Guard the header with unit and integration tests. - Update the native app links docs page: both Digital Asset Links relations and the current response headers. # Additional Changes None. `WellKnown.AppLinksCacheControlMaxAge` behavior is unchanged (`0` still results in `no-store`). # Additional Context - Follow-up to #12634; relates to #12497. - Verified with interleaved requests against two instances: responses are no longer reused across domains, and each domain consistently serves its own configuration. - To be cherry-picked to `v4.x` from `main` once merged. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5 <[email protected]>
191 lines
6.2 KiB
Go
191 lines
6.2 KiB
Go
package well_known
|
|
|
|
import (
|
|
"context"
|
|
"crypto/sha256"
|
|
"encoding/hex"
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
"strings"
|
|
|
|
"github.com/zitadel/zitadel/backend/v3/instrumentation/logging"
|
|
http_util "github.com/zitadel/zitadel/internal/api/http"
|
|
"github.com/zitadel/zitadel/internal/query"
|
|
)
|
|
|
|
const (
|
|
AppleAppSiteAssociationPath = "/.well-known/apple-app-site-association"
|
|
AssetLinksPath = "/.well-known/assetlinks.json"
|
|
)
|
|
|
|
// HandlerPrefixes are registered with [api.API.RegisterHandlerPrefixes].
|
|
var HandlerPrefixes = []string{
|
|
AppleAppSiteAssociationPath,
|
|
AssetLinksPath,
|
|
}
|
|
|
|
type appLinkQuerier interface {
|
|
SearchOIDCAppLinkConfigs(ctx context.Context) ([]*query.OIDCAppLinkConfig, error)
|
|
}
|
|
|
|
type Handler struct {
|
|
queries appLinkQuerier
|
|
}
|
|
|
|
func NewHandler(queries appLinkQuerier) *Handler {
|
|
return &Handler{queries: queries}
|
|
}
|
|
|
|
func (h *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
|
|
switch r.URL.Path {
|
|
case AppleAppSiteAssociationPath:
|
|
h.serveAppleAppSiteAssociation(w, r)
|
|
case AssetLinksPath:
|
|
h.serveAssetLinks(w, r)
|
|
default:
|
|
http.NotFound(w, r)
|
|
}
|
|
}
|
|
|
|
type appleAppSiteAssociation struct {
|
|
WebCredentials appleWebCredentials `json:"webcredentials"`
|
|
}
|
|
|
|
type appleWebCredentials struct {
|
|
Apps []string `json:"apps"`
|
|
}
|
|
|
|
type assetLink struct {
|
|
Relation []string `json:"relation"`
|
|
Target assetLinkTarget `json:"target"`
|
|
}
|
|
|
|
type assetLinkTarget struct {
|
|
Namespace string `json:"namespace"`
|
|
PackageName string `json:"package_name"`
|
|
SHA256CertFingerprints []string `json:"sha256_cert_fingerprints"`
|
|
}
|
|
|
|
func (h *Handler) serveAppleAppSiteAssociation(w http.ResponseWriter, r *http.Request) {
|
|
if r.Method != http.MethodGet && r.Method != http.MethodHead {
|
|
http.Error(w, http.StatusText(http.StatusMethodNotAllowed), http.StatusMethodNotAllowed)
|
|
return
|
|
}
|
|
configs, err := h.queries.SearchOIDCAppLinkConfigs(r.Context())
|
|
if err != nil {
|
|
logging.Error(r.Context(), "unable to query OIDC app link configs for apple-app-site-association", "err", err)
|
|
http.Error(w, http.StatusText(http.StatusInternalServerError), http.StatusInternalServerError)
|
|
return
|
|
}
|
|
h.writeJSON(w, r, buildAppleAppSiteAssociation(configs))
|
|
}
|
|
|
|
func (h *Handler) serveAssetLinks(w http.ResponseWriter, r *http.Request) {
|
|
if r.Method != http.MethodGet && r.Method != http.MethodHead {
|
|
http.Error(w, http.StatusText(http.StatusMethodNotAllowed), http.StatusMethodNotAllowed)
|
|
return
|
|
}
|
|
configs, err := h.queries.SearchOIDCAppLinkConfigs(r.Context())
|
|
if err != nil {
|
|
logging.Error(r.Context(), "unable to query OIDC app link configs for assetlinks.json", "err", err)
|
|
http.Error(w, http.StatusText(http.StatusInternalServerError), http.StatusInternalServerError)
|
|
return
|
|
}
|
|
h.writeJSON(w, r, buildAssetLinks(r.Context(), configs))
|
|
}
|
|
|
|
func buildAppleAppSiteAssociation(configs []*query.OIDCAppLinkConfig) appleAppSiteAssociation {
|
|
apps := make([]string, 0)
|
|
seen := make(map[string]struct{})
|
|
for _, cfg := range configs {
|
|
if cfg.IOSTeamID == "" || cfg.IOSBundleID == "" {
|
|
continue
|
|
}
|
|
appID := cfg.IOSTeamID + "." + cfg.IOSBundleID
|
|
if _, ok := seen[appID]; ok {
|
|
continue
|
|
}
|
|
seen[appID] = struct{}{}
|
|
apps = append(apps, appID)
|
|
}
|
|
return appleAppSiteAssociation{
|
|
WebCredentials: appleWebCredentials{Apps: apps},
|
|
}
|
|
}
|
|
|
|
func buildAssetLinks(ctx context.Context, configs []*query.OIDCAppLinkConfig) []assetLink {
|
|
links := make([]assetLink, 0)
|
|
for _, cfg := range configs {
|
|
if cfg.AndroidPackageName == "" || len(cfg.AndroidSHA256CertFingerprints) == 0 {
|
|
continue
|
|
}
|
|
links = append(links, assetLink{
|
|
// Google's Credential Manager prerequisites require both relations for
|
|
// passkeys; some devices (e.g. Pixel) reject passkey creation when
|
|
// handle_all_urls is missing.
|
|
// https://developer.android.com/identity/credential-manager/prerequisites
|
|
Relation: []string{
|
|
"delegate_permission/common.handle_all_urls",
|
|
"delegate_permission/common.get_login_creds",
|
|
},
|
|
Target: assetLinkTarget{
|
|
Namespace: "android_app",
|
|
PackageName: cfg.AndroidPackageName,
|
|
SHA256CertFingerprints: normalizeSHA256Fingerprints(ctx, cfg.AndroidSHA256CertFingerprints),
|
|
},
|
|
})
|
|
}
|
|
return links
|
|
}
|
|
|
|
// normalizeSHA256Fingerprints returns colon-separated uppercase hex fingerprints
|
|
// for assetlinks.json. Normalization is applied at serve time only so stored /
|
|
// client state can keep the format clients sent.
|
|
func normalizeSHA256Fingerprints(ctx context.Context, fps []string) []string {
|
|
out := make([]string, len(fps))
|
|
for i, fp := range fps {
|
|
out[i] = normalizeSHA256Fingerprint(ctx, fp)
|
|
}
|
|
return out
|
|
}
|
|
|
|
func normalizeSHA256Fingerprint(ctx context.Context, fp string) string {
|
|
if strings.Contains(fp, ":") {
|
|
return strings.ToUpper(fp) // already 32 valid pairs per API validation; only case may vary
|
|
}
|
|
raw, err := hex.DecodeString(fp) // guaranteed 64 hex chars
|
|
if err != nil || len(raw) != sha256.Size {
|
|
logging.Warn(ctx, "stored android sha256 fingerprint is not canonical hex; serving as-is",
|
|
"fingerprint", fp, "err", err)
|
|
return strings.ToUpper(fp)
|
|
}
|
|
parts := make([]string, len(raw))
|
|
for i, b := range raw {
|
|
parts[i] = fmt.Sprintf("%02X", b)
|
|
}
|
|
return strings.Join(parts, ":")
|
|
}
|
|
|
|
func (h *Handler) writeJSON(w http.ResponseWriter, r *http.Request, v any) {
|
|
w.Header().Set("Content-Type", "application/json")
|
|
// The bodies are instance specific: the same path serves different content
|
|
// per requested host, and the request field selecting the instance can also
|
|
// be a (configurable) proxy header rather than Host. HTTP caching must
|
|
// therefore be disabled entirely: a shared cache whose key does not cover
|
|
// the effective selector would serve one instance's file on another
|
|
// instance's domain. Caching is also of no use here, as the only relevant
|
|
// consumers (the Apple and Google association verifiers) fetch rarely and
|
|
// cache on their side regardless of these headers. Should the query load
|
|
// ever become a concern, add a server-side per-instance cache instead of
|
|
// HTTP caching.
|
|
w.Header().Set(http_util.CacheControl, "no-store")
|
|
w.WriteHeader(http.StatusOK)
|
|
if r.Method == http.MethodHead {
|
|
return
|
|
}
|
|
if err := json.NewEncoder(w).Encode(v); err != nil {
|
|
logging.Error(r.Context(), "unable to encode well-known response", "err", err)
|
|
}
|
|
}
|