mirror of
https://github.com/andwati/zitadel.git
synced 2026-10-18 05:52:51 +00:00
# Which Problems Are Solved The payload in actions V2 is currently sent as JSON to the target endpoint. It might get exposed to intermediary infrastructure or logging systems. For these scenarios there needs to be an application-layer encryption, where the provider of the endpoint can define an key to be used for the encryption. # How the Problems Are Solved - Added an additional option to the target to specify the payload type: `JSON` (current and default), `JWT`, `JWE` (api and console) - added endpoints to upload and manage public keys (to be used for encryption) for a target - updated all action v2 executions (interceptors, oidc, saml, ...) to provide the `GetActiveSigningWebKey` from queries - implemented jwt and jwe in the exections incl. refactoring of code and tests - changes to the authn_keys table: - added a `fingerprint` column - dropped not null constraint on expiration - moved the `GetSignerOnce` into its own package to prevent circular dependencies # Additional Changes None # Additional Context closes #11061 --------- Co-authored-by: Marco A. <[email protected]> Co-authored-by: conblem <[email protected]> Co-authored-by: Silvan <[email protected]>
221 lines
6.2 KiB
Go
221 lines
6.2 KiB
Go
package command
|
|
|
|
import (
|
|
"context"
|
|
"net/url"
|
|
"time"
|
|
|
|
"github.com/zitadel/zitadel/internal/command/preparation"
|
|
"github.com/zitadel/zitadel/internal/crypto"
|
|
"github.com/zitadel/zitadel/internal/domain"
|
|
"github.com/zitadel/zitadel/internal/eventstore/v1/models"
|
|
target_domain "github.com/zitadel/zitadel/internal/execution/target"
|
|
"github.com/zitadel/zitadel/internal/repository/target"
|
|
"github.com/zitadel/zitadel/internal/zerrors"
|
|
)
|
|
|
|
type AddTarget struct {
|
|
models.ObjectRoot
|
|
|
|
Name string
|
|
TargetType target_domain.TargetType
|
|
Endpoint string
|
|
Timeout time.Duration
|
|
InterruptOnError bool
|
|
PayloadType target_domain.PayloadType
|
|
|
|
SigningKey string
|
|
}
|
|
|
|
func (a *AddTarget) IsValid() error {
|
|
if a.Name == "" {
|
|
return zerrors.ThrowInvalidArgument(nil, "COMMAND-ddqbm9us5p", "Errors.Target.Invalid")
|
|
}
|
|
if a.Timeout == 0 {
|
|
return zerrors.ThrowInvalidArgument(nil, "COMMAND-39f35d8uri", "Errors.Target.NoTimeout")
|
|
}
|
|
_, err := url.Parse(a.Endpoint)
|
|
if err != nil || a.Endpoint == "" {
|
|
return zerrors.ThrowInvalidArgument(err, "COMMAND-1r2k6qo6wg", "Errors.Target.InvalidURL")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (c *Commands) AddTarget(ctx context.Context, add *AddTarget, resourceOwner string) (_ time.Time, err error) {
|
|
if resourceOwner == "" {
|
|
return time.Time{}, zerrors.ThrowInvalidArgument(nil, "COMMAND-brml926e2d", "Errors.IDMissing")
|
|
}
|
|
|
|
if err := add.IsValid(); err != nil {
|
|
return time.Time{}, err
|
|
}
|
|
|
|
if add.AggregateID == "" {
|
|
add.AggregateID, err = c.idGenerator.Next()
|
|
if err != nil {
|
|
return time.Time{}, err
|
|
}
|
|
}
|
|
wm, err := c.getTargetWriteModelByID(ctx, add.AggregateID, resourceOwner)
|
|
if err != nil {
|
|
return time.Time{}, err
|
|
}
|
|
if wm.State.Exists() {
|
|
return time.Time{}, zerrors.ThrowAlreadyExists(nil, "INSTANCE-9axkz0jvzm", "Errors.Target.AlreadyExists")
|
|
}
|
|
code, err := c.newSigningKey(ctx, c.eventstore.Filter, c.targetEncryption) //nolint
|
|
if err != nil {
|
|
return time.Time{}, err
|
|
}
|
|
add.SigningKey = code.PlainCode()
|
|
pushedEvents, err := c.eventstore.Push(ctx, target.NewAddedEvent(
|
|
ctx,
|
|
TargetAggregateFromWriteModel(&wm.WriteModel),
|
|
add.Name,
|
|
add.TargetType,
|
|
add.Endpoint,
|
|
add.Timeout,
|
|
add.InterruptOnError,
|
|
code.Crypted,
|
|
add.PayloadType,
|
|
))
|
|
if err != nil {
|
|
return time.Time{}, err
|
|
}
|
|
if err := AppendAndReduce(wm, pushedEvents...); err != nil {
|
|
return time.Time{}, err
|
|
}
|
|
return wm.ChangeDate, nil
|
|
}
|
|
|
|
type ChangeTarget struct {
|
|
models.ObjectRoot
|
|
|
|
Name *string
|
|
TargetType *target_domain.TargetType
|
|
Endpoint *string
|
|
Timeout *time.Duration
|
|
InterruptOnError *bool
|
|
PayloadType target_domain.PayloadType
|
|
|
|
ExpirationSigningKey bool
|
|
SigningKey *string
|
|
}
|
|
|
|
func (a *ChangeTarget) IsValid() error {
|
|
if a.AggregateID == "" {
|
|
return zerrors.ThrowInvalidArgument(nil, "COMMAND-1l6ympeagp", "Errors.IDMissing")
|
|
}
|
|
if a.Name != nil && *a.Name == "" {
|
|
return zerrors.ThrowInvalidArgument(nil, "COMMAND-d1wx4lm0zr", "Errors.Target.Invalid")
|
|
}
|
|
if a.Timeout != nil && *a.Timeout == 0 {
|
|
return zerrors.ThrowInvalidArgument(nil, "COMMAND-08b39vdi57", "Errors.Target.NoTimeout")
|
|
}
|
|
if a.Endpoint != nil {
|
|
_, err := url.Parse(*a.Endpoint)
|
|
if err != nil || *a.Endpoint == "" {
|
|
return zerrors.ThrowInvalidArgument(err, "COMMAND-jsbaera7b6", "Errors.Target.InvalidURL")
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (c *Commands) ChangeTarget(ctx context.Context, change *ChangeTarget, resourceOwner string) (time.Time, error) {
|
|
if resourceOwner == "" {
|
|
return time.Time{}, zerrors.ThrowInvalidArgument(nil, "COMMAND-zqibgg0wwh", "Errors.IDMissing")
|
|
}
|
|
if err := change.IsValid(); err != nil {
|
|
return time.Time{}, err
|
|
}
|
|
existing, err := c.getTargetWriteModelByID(ctx, change.AggregateID, resourceOwner)
|
|
if err != nil {
|
|
return time.Time{}, err
|
|
}
|
|
if !existing.State.Exists() {
|
|
return time.Time{}, zerrors.ThrowNotFound(nil, "COMMAND-xj14f2cccn", "Errors.Target.NotFound")
|
|
}
|
|
|
|
var changedSigningKey *crypto.CryptoValue
|
|
if change.ExpirationSigningKey {
|
|
code, err := c.newSigningKey(ctx, c.eventstore.Filter, c.targetEncryption) //nolint
|
|
if err != nil {
|
|
return time.Time{}, err
|
|
}
|
|
changedSigningKey = code.Crypted
|
|
change.SigningKey = &code.Plain
|
|
}
|
|
|
|
changedEvent := existing.NewChangedEvent(
|
|
ctx,
|
|
TargetAggregateFromWriteModel(&existing.WriteModel),
|
|
change.Name,
|
|
change.TargetType,
|
|
change.Endpoint,
|
|
change.Timeout,
|
|
change.InterruptOnError,
|
|
changedSigningKey,
|
|
change.PayloadType,
|
|
)
|
|
if changedEvent == nil {
|
|
return existing.WriteModel.ChangeDate, nil
|
|
}
|
|
pushedEvents, err := c.eventstore.Push(ctx, changedEvent)
|
|
if err != nil {
|
|
return time.Time{}, err
|
|
}
|
|
err = AppendAndReduce(existing, pushedEvents...)
|
|
if err != nil {
|
|
return time.Time{}, err
|
|
}
|
|
return existing.WriteModel.ChangeDate, nil
|
|
}
|
|
|
|
func (c *Commands) DeleteTarget(ctx context.Context, id, resourceOwner string) (time.Time, error) {
|
|
if id == "" || resourceOwner == "" {
|
|
return time.Time{}, zerrors.ThrowInvalidArgument(nil, "COMMAND-obqos2l3no", "Errors.IDMissing")
|
|
}
|
|
|
|
existing, err := c.getTargetWriteModelByID(ctx, id, resourceOwner)
|
|
if err != nil {
|
|
return time.Time{}, err
|
|
}
|
|
if !existing.State.Exists() {
|
|
return existing.WriteModel.ChangeDate, nil
|
|
}
|
|
|
|
if err := c.pushAppendAndReduce(ctx,
|
|
existing,
|
|
target.NewRemovedEvent(ctx,
|
|
TargetAggregateFromWriteModel(&existing.WriteModel),
|
|
existing.Name,
|
|
),
|
|
); err != nil {
|
|
return time.Time{}, err
|
|
}
|
|
return existing.WriteModel.ChangeDate, nil
|
|
}
|
|
|
|
func (c *Commands) existsTargetsByIDs(ctx context.Context, ids []string, resourceOwner string) bool {
|
|
wm := NewTargetsExistsWriteModel(ids, resourceOwner)
|
|
err := c.eventstore.FilterToQueryReducer(ctx, wm)
|
|
if err != nil {
|
|
return false
|
|
}
|
|
return wm.AllExists()
|
|
}
|
|
|
|
func (c *Commands) getTargetWriteModelByID(ctx context.Context, id string, resourceOwner string) (*TargetWriteModel, error) {
|
|
wm := NewTargetWriteModel(id, resourceOwner)
|
|
err := c.eventstore.FilterToQueryReducer(ctx, wm)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return wm, nil
|
|
}
|
|
|
|
func (c *Commands) newSigningKey(ctx context.Context, filter preparation.FilterToQueryReducer, alg crypto.EncryptionAlgorithm) (*EncryptedCode, error) {
|
|
return c.newEncryptedCodeWithDefault(ctx, filter, domain.SecretGeneratorTypeSigningKey, alg, c.defaultSecretGenerators.SigningKey)
|
|
}
|