fix: ui_locales being ignored in v2 login ui (#11617)

# Which Problems Are Solved

* v2 login ui was ignoring oicd `ui_locales` making it impossible to
sync the login ui locale with the apps ui

# How the Problems Are Solved

- Read `uiLocales` from `authRequest`
- check all listed if valid in ui
- take the first valid one
- set language cookie (if a valid locale is pressent in uiLocales)

# Additional Changes

- tests

# Additional Context

---------

Co-authored-by: Florian Forster <[email protected]>
Co-authored-by: Max Peintner <[email protected]>
This commit is contained in:
TomRoyls
2026-03-04 09:17:16 -08:00
committed by GitHub
co-authored by Florian Forster Max Peintner
parent 80aaf52aae
commit fb27c6d212
8 changed files with 330 additions and 1 deletions
+52 -1
View File
@@ -1,7 +1,58 @@
import { describe, it, expect } from "vitest";
import { validateAuthRequest, isRSCRequest } from "./auth-utils";
import { validateAuthRequest, isRSCRequest, isValidLanguage, getValidLocaleFromUILocales } from "./auth-utils";
describe("auth-utils", () => {
describe("isValidLanguage", () => {
it("should return true for valid language codes", () => {
expect(isValidLanguage("en")).toBe(true);
expect(isValidLanguage("de")).toBe(true);
expect(isValidLanguage("fr")).toBe(true);
expect(isValidLanguage("zh")).toBe(true);
});
it("should return false for invalid language codes", () => {
expect(isValidLanguage("invalid")).toBe(false);
expect(isValidLanguage("xx")).toBe(false);
expect(isValidLanguage("")).toBe(false);
});
it("should be case-insensitive", () => {
expect(isValidLanguage("EN")).toBe(true);
expect(isValidLanguage("De")).toBe(true);
});
});
describe("getValidLocaleFromUILocales", () => {
it("should return null for undefined or empty array", () => {
expect(getValidLocaleFromUILocales(undefined)).toBeNull();
expect(getValidLocaleFromUILocales([])).toBeNull();
});
it("should extract valid language from simple locale codes", () => {
expect(getValidLocaleFromUILocales(["de"])).toBe("de");
expect(getValidLocaleFromUILocales(["en", "de"])).toBe("en");
});
it("should extract language code from language tags", () => {
expect(getValidLocaleFromUILocales(["de-CH"])).toBe("de");
expect(getValidLocaleFromUILocales(["en-US"])).toBe("en");
expect(getValidLocaleFromUILocales(["zh-CN"])).toBe("zh");
});
it("should return first valid language when multiple provided", () => {
expect(getValidLocaleFromUILocales(["xx-XX", "de", "en"])).toBe("de");
});
it("should return null when no valid languages found", () => {
expect(getValidLocaleFromUILocales(["xx", "yy", "zz"])).toBeNull();
});
it("should handle case-insensitive matching", () => {
expect(getValidLocaleFromUILocales(["DE"])).toBe("de");
expect(getValidLocaleFromUILocales(["En-US"])).toBe("en");
});
});
describe("validateAuthRequest", () => {
it("should return null when no auth parameters are present", () => {
const searchParams = new URLSearchParams();