andwati/zitadel
1
0
Fork 0
mirror of https://github.com/andwati/zitadel.git synced 2026-11-13 01:25:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(removing dead code): removing LabelPolicyAssetsRemovedEventType event is never made (#10742)

Browse Source 
# Which Problems Are Solved

The event `LabelPolicyAssetsRemovedEventType` is never actually made
anywhere, this is dead code, this PR will remove it
This commit is contained in:
Iraq
2025-09-22 06:19:34 +00:00
committed by GitHub
parent b6ff4ff16c
commit e5575d6042
10 changed files with 2 additions and 170 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/query/projection/label_policy.go
-34
View File
@@ -153,10 +153,6 @@ func (p *labelPolicyProjection) Reducers() []handler.AggregateReducer {
Event: org.LabelPolicyFontRemovedEventType,
Reduce: p.reduceFontRemoved,
},
{
Event: org.LabelPolicyAssetsRemovedEventType,
Reduce: p.reduceAssetsRemoved,
},
{
Event: org.OrgRemovedEventType,
Reduce: p.reduceOwnerRemoved,
@@ -218,10 +214,6 @@ func (p *labelPolicyProjection) Reducers() []handler.AggregateReducer {
Event: instance.LabelPolicyFontRemovedEventType,
Reduce: p.reduceFontRemoved,
},
{
Event: instance.LabelPolicyAssetsRemovedEventType,
Reduce: p.reduceAssetsRemoved,
},
{
Event: instance.InstanceRemovedEventType,
Reduce: reduceInstanceRemovedHelper(LabelPolicyInstanceIDCol),
@@ -584,32 +576,6 @@ func (p *labelPolicyProjection) reduceFontRemoved(event eventstore.Event) (*hand
}), nil
}
func (p *labelPolicyProjection) reduceAssetsRemoved(event eventstore.Event) (*handler.Statement, error) {
switch event.(type) {
case *org.LabelPolicyAssetsRemovedEvent, *instance.LabelPolicyAssetsRemovedEvent:
//ok
default:
return nil, zerrors.ThrowInvalidArgumentf(nil, "PROJE-qi39A", "reduce.wrong.event.type %v", []eventstore.EventType{org.LabelPolicyAssetsRemovedEventType, instance.LabelPolicyAssetsRemovedEventType})
}
return handler.NewUpdateStatement(
event,
[]handler.Column{
handler.NewCol(LabelPolicyChangeDateCol, event.CreatedAt()),
handler.NewCol(LabelPolicySequenceCol, event.Sequence()),
handler.NewCol(LabelPolicyLightLogoURLCol, nil),
handler.NewCol(LabelPolicyLightIconURLCol, nil),
handler.NewCol(LabelPolicyDarkLogoURLCol, nil),
handler.NewCol(LabelPolicyDarkIconURLCol, nil),
handler.NewCol(LabelPolicyFontURLCol, nil),
},
[]handler.Condition{
handler.NewCond(LabelPolicyIDCol, event.Aggregate().ID),
handler.NewCond(LabelPolicyStateCol, domain.LabelPolicyStatePreview),
handler.NewCond(LabelPolicyInstanceIDCol, event.Aggregate().InstanceID),
}), nil
}
func (p *labelPolicyProjection) reduceOwnerRemoved(event eventstore.Event) (*handler.Statement, error) {
e, ok := event.(*org.OrgRemovedEvent)
if !ok {
internal/query/projection/label_policy_test.go
-70
View File
@@ -495,41 +495,6 @@ func TestLabelPolicyProjection_reduces(t *testing.T) {
},
},
},
{
name: "org reduceAssetsRemoved",
args: args{
event: getEvent(
testEvent(
org.LabelPolicyAssetsRemovedEventType,
org.AggregateType,
nil,
), org.LabelPolicyAssetsRemovedEventMapper),
},
reduce: (&labelPolicyProjection{}).reduceAssetsRemoved,
want: wantReduce{
aggregateType: eventstore.AggregateType("org"),
sequence: 15,
executer: &testExecuter{
executions: []execution{
{
expectedStmt: "UPDATE projections.label_policies3 SET (change_date, sequence, light_logo_url, light_icon_url, dark_logo_url, dark_icon_url, font_url) = ($1, $2, $3, $4, $5, $6, $7) WHERE (id = $8) AND (state = $9) AND (instance_id = $10)",
expectedArgs: []interface{}{
anyArg{},
uint64(15),
nil,
nil,
nil,
nil,
nil,
"agg-id",
domain.LabelPolicyStatePreview,
"instance-id",
},
},
},
},
},
},
{
name: "instance reduceAdded",
args: args{
@@ -958,41 +923,6 @@ func TestLabelPolicyProjection_reduces(t *testing.T) {
},
},
},
{
name: "instance reduceAssetsRemoved",
args: args{
event: getEvent(
testEvent(
instance.LabelPolicyAssetsRemovedEventType,
instance.AggregateType,
nil,
), instance.LabelPolicyAssetsRemovedEventMapper),
},
reduce: (&labelPolicyProjection{}).reduceAssetsRemoved,
want: wantReduce{
aggregateType: eventstore.AggregateType("instance"),
sequence: 15,
executer: &testExecuter{
executions: []execution{
{
expectedStmt: "UPDATE projections.label_policies3 SET (change_date, sequence, light_logo_url, light_icon_url, dark_logo_url, dark_icon_url, font_url) = ($1, $2, $3, $4, $5, $6, $7) WHERE (id = $8) AND (state = $9) AND (instance_id = $10)",
expectedArgs: []interface{}{
anyArg{},
uint64(15),
nil,
nil,
nil,
nil,
nil,
"agg-id",
domain.LabelPolicyStatePreview,
"instance-id",
},
},
},
},
},
},
{
name: "org.reduceOwnerRemoved",
reduce: (&labelPolicyProjection{}).reduceOwnerRemoved,