feat(login): redirect configuration options in multi-domain setups (#11527)

# Which Problems Are Solved

This PR introduces robust redirect configuration options and enhances
security for Server Actions in multi-domain setups.

# How the Problems Are Solved

- Redirect Fallback Logic: Implemented a unified `resolveRedirectUri`
utility that prioritizes redirect targets as follows:
  - Environment override (`DEFAULT_REDIRECT_URI`)
  - Organization settings (`defaultRedirectUri`).
  - Relative fallback (`/signedin?...`).
- Host Reflection: `DEFAULT_REDIRECT_URI` supports absolute URLs or
relative paths via host reflection.
- Server Action Security: Configured `serverActions.allowedOrigins` to
be dynamically manageable via the `SERVER_ACTION_ALLOWED_ORIGINS`
environment variable (comma-separated list). It defaults to an empty
list for maximum security.
- UI Integration: Updated the /signedin page to use the unified redirect
logic, ensuring consistent behavior for the "Continue" button.
- Documentation: Added type definitions and detailed descriptions for
new environment variables in
`next-env-vars.d.ts`

---------

Co-authored-by: Copilot <[email protected]>
This commit is contained in:
Max Peintner
2026-02-24 11:02:29 +03:00
committed by GitHub
co-authored by Copilot
parent 87aae1b5fc
commit d27833e1bc
22 changed files with 267 additions and 53 deletions
+46 -36
View File
@@ -1,4 +1,9 @@
"use server";
import { headers } from "next/headers";
import { completeAuthFlow } from "./server/auth-flow";
import { getPublicHostWithProtocol } from "./server/host";
import { isSafeRedirectUri } from "./client-utils";
type FinishFlowCommand =
| {
@@ -100,47 +105,52 @@ export async function getNextUrl(
// OIDC/SAML flows are now handled by completeAuthFlowAction() server action
// This function only handles device flows and fallback navigation
if (defaultRedirectUri) {
console.log("getNextUrl: Using defaultRedirectUri:", defaultRedirectUri);
return defaultRedirectUri;
}
const result = goToSignedInPage(command);
console.log("getNextUrl: got goToSignedInPage result");
const result = await resolveRedirectUri(command, defaultRedirectUri);
console.log("getNextUrl: Resolved redirect URI:", result);
return result;
}
export type ServerActionResponse =
| { redirect: string }
| { error: string }
| { samlData: { url: string; fields: Record<string, string> } }
| undefined
| null;
export function handleServerActionResponse(
response: ServerActionResponse,
router: { push: (url: string) => void },
setSamlData: (data: { url: string; fields: Record<string, string> }) => void,
setError: (error: string) => void,
): boolean {
if (!response) {
return false;
/**
* Resolves the redirect URI based on the following priority:
* 1. DEFAULT_REDIRECT_URI environment variable
* 2. defaultRedirectUri from organization settings
* 3. Relative signed-in page fallback
* 4. Reserved for future extensions
*/
export async function resolveRedirectUri(command: FinishFlowCommand, defaultRedirectUri?: string): Promise<string> {
// 1. Environment variable override
const envOverride = process.env.DEFAULT_REDIRECT_URI;
if (envOverride) {
if (envOverride.startsWith("/")) {
// Special state: trigger absolute host-based redirect with provided path
try {
const _headers = await headers();
const host = getPublicHostWithProtocol(_headers);
const result = `${host}${envOverride}`;
console.log("resolveRedirectUri: Using host-based redirect from override:", result);
return result;
} catch (error) {
console.warn("resolveRedirectUri: Could not determine host for override, falling back", error);
}
} else {
console.log("resolveRedirectUri: Using DEFAULT_REDIRECT_URI override:", envOverride);
return envOverride;
}
}
if ("redirect" in response && response.redirect) {
router.push(response.redirect);
return true;
// 2. Default redirect URI from settings
if (defaultRedirectUri) {
if (isSafeRedirectUri(defaultRedirectUri)) {
console.log("resolveRedirectUri: Using defaultRedirectUri from settings:", defaultRedirectUri);
return defaultRedirectUri;
} else {
console.warn("resolveRedirectUri: Unsafe defaultRedirectUri prevented:", defaultRedirectUri);
}
}
if ("samlData" in response && response.samlData) {
setSamlData(response.samlData);
return true;
}
if ("error" in response && response.error) {
setError(response.error);
return true;
}
return false;
// 3. Default signed-in page (relative)
const result = goToSignedInPage(command);
console.log("resolveRedirectUri: Using relative goToSignedInPage result:", result);
return result;
}