From c790715628b3d5d46785ea51c87dc98fd871de98 Mon Sep 17 00:00:00 2001
From: Livio Spring <livio.a@gmail.com>
Date: Wed, 13 Sep 2023 08:16:57 +0200
Subject: [PATCH] fix: improve autofill values (#6541)

---
 internal/api/ui/login/init_user_handler.go                  | 6 +++++-
 internal/api/ui/login/static/templates/change_password.html | 2 +-
 internal/api/ui/login/static/templates/init_user.html       | 2 +-
 internal/api/ui/login/static/templates/password.html        | 2 +-
 4 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/internal/api/ui/login/init_user_handler.go b/internal/api/ui/login/init_user_handler.go
index c058c6243..fb4b8b845 100644
--- a/internal/api/ui/login/init_user_handler.go
+++ b/internal/api/ui/login/init_user_handler.go
@@ -121,10 +121,14 @@ func (l *Login) renderInitUser(w http.ResponseWriter, r *http.Request, authReq *
 		baseData:    l.getBaseData(r, authReq, "InitUser.Title", "InitUser.Description", errID, errMessage),
 		profileData: l.getProfileData(authReq),
 		UserID:      userID,
-		LoginName:   loginName,
 		Code:        code,
 		PasswordSet: passwordSet,
 	}
+	// if the user clicked on the link in the mail, we need to make sure the loginName is rendered
+	if authReq == nil {
+		data.LoginName = loginName
+		data.UserName = loginName
+	}
 	policy := l.getPasswordComplexityPolicyByUserID(r, userID)
 	if policy != nil {
 		data.MinLength = policy.MinLength
diff --git a/internal/api/ui/login/static/templates/change_password.html b/internal/api/ui/login/static/templates/change_password.html
index 45eacb3ab..506c10778 100644
--- a/internal/api/ui/login/static/templates/change_password.html
+++ b/internal/api/ui/login/static/templates/change_password.html
@@ -12,7 +12,7 @@
     {{ .CSRF }}
 
     <input type="hidden" name="authRequestID" value="{{ .AuthReqID }}" />
-    <input type="text" name="loginname" value="{{ .LoginName }}" autocomplete="username" class="hidden" />
+    <input type="text" name="loginName" value="{{if .DisplayLoginNameSuffix}}{{.LoginName}}{{else}}{{.UserName}}{{end}}" autocomplete="username" class="hidden" />
 
     <div class="fields">
         <div class="field">
diff --git a/internal/api/ui/login/static/templates/init_user.html b/internal/api/ui/login/static/templates/init_user.html
index cf0ad7104..9ffd4f7c9 100644
--- a/internal/api/ui/login/static/templates/init_user.html
+++ b/internal/api/ui/login/static/templates/init_user.html
@@ -16,7 +16,7 @@
     <input type="hidden" name="userID" value="{{ .UserID }}" />
     <input type="hidden" name="passwordSet" value="{{ .PasswordSet }}" />
     <input type="hidden" name="orgID" value="{{ .OrgID }}" />
-    <input type="text" name="loginname" value="{{ .LoginName }}" autocomplete="username" class="hidden" />
+    <input type="text" name="loginName" value="{{if .DisplayLoginNameSuffix}}{{.LoginName}}{{else}}{{.UserName}}{{end}}" autocomplete="username" class="hidden" />
 
     <div class="fields">
         <div class="field">
diff --git a/internal/api/ui/login/static/templates/password.html b/internal/api/ui/login/static/templates/password.html
index 15e9d7c09..2204a25bb 100644
--- a/internal/api/ui/login/static/templates/password.html
+++ b/internal/api/ui/login/static/templates/password.html
@@ -12,7 +12,7 @@
     {{ .CSRF }}
 
     <input type="hidden" name="authRequestID" value="{{ .AuthReqID }}" />
-    <input type="text" name="loginName" value="{{ .LoginName }}" autocomplete="username" class="hidden" />
+    <input type="text" name="loginName" value="{{if .DisplayLoginNameSuffix}}{{.LoginName}}{{else}}{{.UserName}}{{end}}" autocomplete="username" class="hidden" />
 
     <div class="fields">
         <label class="lgn-label" for="password">{{t "Password.PasswordLabel"}}</label>