andwati/zitadel
1
0
Fork 0
mirror of https://github.com/andwati/zitadel.git synced 2026-11-07 14:52:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: naming consistency - Organization ID (#11733)

Browse Source 
# Which Problems Are Solved

Renaming of:

  - Resource Owner
  - OrgID
  - OrganizationID
  - Organization Id

# How the Problems Are Solved

Find & Replace, evalue entries, is resource owner referring to an
organization ? If so, do change

# Additional Context

- Closes #11305
This commit is contained in:
Marco A.
2026-03-03 10:24:44 +00:00
committed by GitHub
parent 41b8aa3f18
commit bebee4c795
12 changed files with 35 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/api/grpc/system/instance.go
+1 -2
View File
@@ -103,8 +103,7 @@ func (s *Server) ListIAMMembers(ctx context.Context, req *system_pb.ListIAMMembe
}
return &system_pb.ListIAMMembersResponse{
Details: object.ToListDetails(res.Count, res.Sequence, res.LastRun),
//TODO: resource owner of user of the member instead of the membership resource owner
Result: member.MembersToPb("", res.Members),
Result: member.MembersToPb("", res.Members),
}, nil
}
internal/api/ui/login/custom_action.go
+1 -1
View File
@@ -40,7 +40,7 @@ func (l *Login) runPostExternalAuthenticationActions(
// so let's do a workaround and resourceOwnerOfUserIDPLink if there would be a IDP link
resourceOwner, err = l.resourceOwnerOfUserIDPLink(ctx, authRequest.SelectedIDPConfigID, user.ExternalUserID)
logging.WithFields("authReq", authRequest.ID, "idpID", authRequest.SelectedIDPConfigID).OnError(err).
Warn("could not determine resource owner for runPostExternalAuthenticationActions, fall back to default org id")
Warn("could not determine Organization ID for runPostExternalAuthenticationActions, fall back to default org id")
}
// fallback to default org id
if resourceOwner == "" {
internal/command/org_custom_message_text_test.go
+2 -2
View File
@@ -33,7 +33,7 @@ func TestCommandSide_SetCustomMessageText(t *testing.T) {
res res
}{
{
name: "no resource owner, error",
name: "no Organization ID, error",
fields: fields{
eventstore: eventstoreExpect(t),
},
@@ -383,7 +383,7 @@ func TestCommandSide_RemoveCustomMessageText(t *testing.T) {
res res
}{
{
name: "no resource owner, error",
name: "no Organization ID, error",
fields: fields{
eventstore: eventstoreExpect(
t,
internal/command/project_grant_member.go
+2 -2
View File
@@ -57,8 +57,8 @@ func (c *Commands) AddProjectGrantMember(ctx context.Context, member *AddProject
if err != nil {
return nil, err
}
// TODO: change e2e tests to use correct resourceowner, wrong resource owner is corrected through aggregate
// error if provided resourceowner is not equal to the resourceowner of the project grant
// TODO: change e2e tests to use correct organization ID, wrong organization ID is corrected through aggregate
// error if provided organization ID is not equal to the organization ID of the project grant
//if projectGrantResourceOwner != addedMember.ResourceOwner {
// return nil, zerrors.ThrowPreconditionFailed(nil, "PROJECT-0l10S9OmZV", "Errors.Project.Grant.Invalid")
//}
internal/command/session.go
+3 -3
View File
@@ -408,14 +408,14 @@ func (c *Commands) updateSession(ctx context.Context, checks *SessionCommands, m
}
// checkSessionWritePermission will check that the caller is granted the "session.write" permission on the resource owner of the authenticated user.
// In case the user is not set, and the userResourceOwner is not set (also the case for the session creation),
// In case the user is not set, and the userOrganizationID is not set (also the case for the session creation),
// it will check permission on the instance.
func (c *Commands) checkSessionWritePermission(ctx context.Context, model *SessionWriteModel) error {
userResourceOwner, err := c.sessionUserResourceOwner(ctx, model)
userOrganizationID, err := c.sessionUserResourceOwner(ctx, model)
if err != nil {
return err
}
return c.checkPermission(ctx, domain.PermissionSessionWrite, userResourceOwner, model.UserID)
return c.checkPermission(ctx, domain.PermissionSessionWrite, userOrganizationID, model.UserID)
}
// checkSessionTerminationPermission will check that the provided sessionToken is correct or
internal/command/user_grant_test.go
+4 -4
View File
@@ -663,7 +663,7 @@ func TestCommandSide_AddUserGrant(t *testing.T) {
},
},
{
name: "usergrant without resource owner on project, ok",
name: "usergrant without Organization ID on project, ok",
fields: fields{
eventstore: expectEventstore(
expectFilter(
@@ -816,7 +816,7 @@ func TestCommandSide_AddUserGrant(t *testing.T) {
},
},
{
name: "usergrant for granted resource owner, ok",
name: "usergrant for granted Organization ID, ok",
fields: fields{
eventstore: expectEventstore(
expectFilter(
@@ -1717,7 +1717,7 @@ func TestCommandSide_ChangeUserGrant(t *testing.T) {
},
},
{
name: "usergrant for projectgrant same resource owner, ok",
name: "usergrant for projectgrant same Organization ID, ok",
fields: fields{
eventstore: expectEventstore(
expectFilter(
@@ -1813,7 +1813,7 @@ func TestCommandSide_ChangeUserGrant(t *testing.T) {
},
},
{
name: "usergrant for project without resource owner, ok",
name: "usergrant for project without Organization ID, ok",
fields: fields{
eventstore: expectEventstore(
expectFilter(
internal/query/permission_example_test.go
+4 -4
View File
@@ -11,7 +11,7 @@ import (
)
// ExamplePermissionClause_org shows how to use the PermissionClause function to filter
// permitted records based on the resource owner and the user's instance or organization membership.
// permitted records based on the Organization ID and the user's instance or organization membership.
func ExamplePermissionClause_org() {
// These variables are typically set in the middleware of Zitadel.
// They do not influence the generation of the clause, just what
@@ -23,7 +23,7 @@ func ExamplePermissionClause_org() {
join, args := PermissionClause(
ctx,
UserResourceOwnerCol, // match the resource owner column
UserResourceOwnerCol, // match the Organization ID column
domain.PermissionUserRead,
SingleOrgPermissionOption([]SearchQuery{
mustSearchQuery(NewUserDisplayNameSearchQuery("zitadel", TextContains)),
@@ -44,7 +44,7 @@ func ExamplePermissionClause_org() {
}
// ExamplePermissionClause_project shows how to use the PermissionClause function to filter
// permitted records based on the resource owner and the user's instance or organization membership.
// permitted records based on the Organization ID and the user's instance or organization membership.
// Additionally, it allows returning records based on the project ID and project membership.
func ExamplePermissionClause_project() {
// These variables are typically set in the middleware of Zitadel.
@@ -57,7 +57,7 @@ func ExamplePermissionClause_project() {
join, args := PermissionClause(
ctx,
ProjectColumnResourceOwner, // match the resource owner column
ProjectColumnResourceOwner, // match the Organization ID column
"project.read",
WithProjectsPermissionOption(ProjectColumnID),
SingleOrgPermissionOption([]SearchQuery{
internal/query/project_grant_test.go
+2 -2
View File
@@ -243,7 +243,7 @@ func Test_ProjectGrantPrepares(t *testing.T) {
},
},
{
name: "prepareProjectGrantsQuery no resource owner",
name: "prepareProjectGrantsQuery no Organization ID",
prepare: prepareProjectGrantsQuery,
want: want{
sqlExpectations: mockQueries(
@@ -476,7 +476,7 @@ func Test_ProjectGrantPrepares(t *testing.T) {
},
},
{
name: "prepareProjectGrantQuery no resource owner",
name: "prepareProjectGrantQuery no Organization ID",
prepare: prepareProjectGrantQuery,
want: want{
sqlExpectations: mockQuery(
internal/query/user_grant_test.go
+4 -4
View File
@@ -67,7 +67,7 @@ var (
"user_id",
"username",
"type",
"resource_owner", //user resource owner
"resource_owner", // user Organization ID
"name",
"primary_domain",
"first_name",
@@ -76,12 +76,12 @@ var (
"display_name",
"avatar_key",
"login_name",
"resource_owner", //user_grant resource owner
"name", //org name
"resource_owner", // user_grant Organization ID
"name", // org name
"primary_domain",
"project_id",
"name", // project name
"resource_owner", // project_grant resource owner
"resource_owner", // project_grant Organization ID
"id", // granted org id
"name", // granted org name
"primary_domain", // granted org domain