mirror of
https://github.com/andwati/zitadel.git
synced 2026-11-17 02:55:11 +00:00
perf(actionsv2): execution target router (#10564)
# Which Problems Are Solved The event execution system currently uses a projection handler that subscribes to and processes all events for all instances. This creates a high static cost because the system over-fetches event data, handling many events that are not needed by most instances. This inefficiency is also reflected in high "rows returned" metrics in the database. # How the Problems Are Solved Eliminate the use of a project handler. Instead, events for which "execution targets" are defined, are directly pushed to the queue by the eventstore. A Router is populated in the Instance object in the authz middleware. - By joining the execution targets to the instance, no additional queries are needed anymore. - As part of the instance object, execution targets are now cached as well. - Events are queued within the same transaction, giving transactional guarantees on delivery. - Uses the "insert many fast` variant of River. Multiple jobs are queued in a single round-trip to the database. - Fix compatibility with PostgreSQL 15 # Additional Changes - The signing key was stored as plain-text in the river job payload in the DB. This violated our [Secrets Storage](https://zitadel.com/docs/concepts/architecture/secrets#secrets-storage) principle. This change removed the field and only uses the encrypted version of the signing key. - Fixed the target ordering from descending to ascending. - Some minor linter warnings on the use of `io.WriteString()`. # Additional Context - Introduced in https://github.com/zitadel/zitadel/pull/9249 - Closes https://github.com/zitadel/zitadel/issues/10553 - Closes https://github.com/zitadel/zitadel/issues/9832 - Closes https://github.com/zitadel/zitadel/issues/10372 - Closes https://github.com/zitadel/zitadel/issues/10492 --------- Co-authored-by: Stefan Benz <[email protected]>
This commit is contained in:
co-authored by
Stefan Benz
parent
5721b63bcb
commit
a9ebc06c77
@@ -0,0 +1,69 @@
|
||||
package target
|
||||
|
||||
import (
|
||||
"slices"
|
||||
"strings"
|
||||
)
|
||||
|
||||
type element struct {
|
||||
ID string `json:"id"`
|
||||
Targets []Target `json:"targets,omitempty"`
|
||||
}
|
||||
|
||||
type Router []element
|
||||
|
||||
func NewRouter(targets []Target) Router {
|
||||
m := make(map[string][]Target)
|
||||
for _, t := range targets {
|
||||
m[t.GetExecutionID()] = append(m[t.GetExecutionID()], t)
|
||||
}
|
||||
router := make(Router, 0, len(m))
|
||||
for id, targets := range m {
|
||||
router = append(router, element{
|
||||
ID: id,
|
||||
Targets: targets,
|
||||
})
|
||||
}
|
||||
slices.SortFunc(router, func(a, b element) int {
|
||||
return strings.Compare(a.ID, b.ID)
|
||||
})
|
||||
return router
|
||||
}
|
||||
|
||||
// Get execution targets by exact match of the executionID
|
||||
func (r Router) Get(executionID string) ([]Target, bool) {
|
||||
i, ok := slices.BinarySearchFunc(r, executionID, func(a element, b string) int {
|
||||
return strings.Compare(a.ID, b)
|
||||
})
|
||||
if ok {
|
||||
return r[i].Targets, true
|
||||
}
|
||||
return nil, false
|
||||
}
|
||||
|
||||
// GetEventBestMatch returns the best matching execution targets for an event.
|
||||
// The following match priority is used:
|
||||
// 1. Exact match
|
||||
// 2. Wildcard match
|
||||
// 3. Prefix match ("event")
|
||||
func (r Router) GetEventBestMatch(executionID string) ([]Target, bool) {
|
||||
t, ok := r.Get(executionID)
|
||||
if ok {
|
||||
return t, true
|
||||
}
|
||||
var bestMatch element
|
||||
for _, e := range r {
|
||||
if e.ID == "event" && strings.HasPrefix(executionID, e.ID) {
|
||||
bestMatch, ok = e, true
|
||||
}
|
||||
cut, has := strings.CutSuffix(e.ID, ".*")
|
||||
if has && strings.HasPrefix(executionID, cut) {
|
||||
bestMatch, ok = e, true
|
||||
}
|
||||
}
|
||||
return bestMatch.Targets, ok
|
||||
}
|
||||
|
||||
func (r Router) IsZero() bool {
|
||||
return len(r) == 0
|
||||
}
|
||||
Reference in New Issue
Block a user