fix(login): Safari Cookie Issues in Development Mode (#10594)

Safari was not creating session cookies during local development,
causing authentication failures. This was due to nextjs default setting
of SameSite cookie property.
We explicitly set "strict" for session cookies now.

Closes #10473 

# Which Problems Are Solved

Authentication Issues with Safari in local development

# How the Problems Are Solved

- Cleaner API: Replaced confusing sameSite boolean/string parameters
with iFrameEnabled boolean
- Better logic flow:

iFrameEnabled: true → sameSite: "none" (for iframe embedding)
Production → sameSite: "strict" (maximum security)
This commit is contained in:
Max Peintner
2025-09-11 15:01:24 +00:00
committed by GitHub
parent 1a42e99329
commit a9cd3ff9c0
3 changed files with 61 additions and 119 deletions
+5 -14
View File
@@ -69,10 +69,7 @@ export async function skipMFAAndContinueWithNextUrl({
}
}
export async function continueWithSession({
requestId,
...session
}: Session & { requestId?: string }) {
export async function continueWithSession({ requestId, ...session }: Session & { requestId?: string }) {
const _headers = await headers();
const { serviceUrl } = getServiceUrlFromHeaders(_headers);
@@ -116,8 +113,7 @@ export type UpdateSessionCommand = {
};
export async function updateSession(options: UpdateSessionCommand) {
let { loginName, sessionId, organization, checks, requestId, challenges } =
options;
let { loginName, sessionId, organization, checks, requestId, challenges } = options;
const recentSession = sessionId
? await getSessionCookieById({ sessionId })
: loginName
@@ -138,12 +134,7 @@ export async function updateSession(options: UpdateSessionCommand) {
return { error: "Could not get host" };
}
if (
host &&
challenges &&
challenges.webAuthN &&
!challenges.webAuthN.domain
) {
if (host && challenges && challenges.webAuthN && !challenges.webAuthN.domain) {
const [hostname] = host.split(":");
challenges.webAuthN.domain = hostname;
@@ -219,11 +210,11 @@ export async function clearSession(options: ClearSessionOptions) {
});
const securitySettings = await getSecuritySettings({ serviceUrl });
const sameSite = securitySettings?.embeddedIframe?.enabled ? "none" : true;
const iFrameEnabled = !!securitySettings?.embeddedIframe?.enabled;
if (!deleteResponse) {
throw new Error("Could not delete session");
}
return removeSessionFromCookie({ session: sessionCookie, sameSite });
return removeSessionFromCookie({ session: sessionCookie, iFrameEnabled });
}