From a141b8f3e74a6232513c98ba7b89ecd402d3d986 Mon Sep 17 00:00:00 2001
From: Max Peintner <max@caos.ch>
Date: Sat, 19 Aug 2023 09:16:40 +0200
Subject: [PATCH] fix(console): set metadata value encoding to utf-8 (#6392)

* fix: set encoding to utf-8

* org metadata encoding

* user detail mgmt encoding

* utf-8 encoding decoding of saml applications

---------

Co-authored-by: Livio Spring <livio.a@gmail.com>
---
 console/src/app/pages/orgs/org-detail/org-detail.component.ts | 2 +-
 .../pages/projects/apps/app-create/app-create.component.ts    | 4 ++--
 .../pages/projects/apps/app-detail/app-detail.component.ts    | 4 ++--
 .../auth-user-detail/auth-user-detail.component.ts            | 2 +-
 .../users/user-detail/user-detail/user-detail.component.ts    | 2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/console/src/app/pages/orgs/org-detail/org-detail.component.ts b/console/src/app/pages/orgs/org-detail/org-detail.component.ts
index f0689be11..92a885428 100644
--- a/console/src/app/pages/orgs/org-detail/org-detail.component.ts
+++ b/console/src/app/pages/orgs/org-detail/org-detail.component.ts
@@ -248,7 +248,7 @@ export class OrgDetailComponent implements OnInit, OnDestroy {
         this.metadata = resp.resultList.map((md) => {
           return {
             key: md.key,
-            value: Buffer.from(md.value as string, 'base64').toString('ascii'),
+            value: Buffer.from(md.value as string, 'base64').toString('utf-8'),
           };
         });
       })
diff --git a/console/src/app/pages/projects/apps/app-create/app-create.component.ts b/console/src/app/pages/projects/apps/app-create/app-create.component.ts
index dcdf1b3d6..89299d365 100644
--- a/console/src/app/pages/projects/apps/app-create/app-create.component.ts
+++ b/console/src/app/pages/projects/apps/app-create/app-create.component.ts
@@ -521,7 +521,7 @@ export class AppCreateComponent implements OnInit, OnDestroy {
   get decodedBase64(): string {
     const samlReq = this.samlAppRequest.toObject();
     if (samlReq && samlReq.metadataXml && typeof samlReq.metadataXml === 'string') {
-      return Buffer.from(samlReq.metadataXml, 'base64').toString('ascii');
+      return Buffer.from(samlReq.metadataXml, 'base64').toString('utf-8');
     } else {
       return '';
     }
@@ -529,7 +529,7 @@ export class AppCreateComponent implements OnInit, OnDestroy {
 
   set decodedBase64(xmlString) {
     if (this.samlAppRequest) {
-      const base64 = Buffer.from(xmlString, 'ascii').toString('base64');
+      const base64 = Buffer.from(xmlString, 'utf-8').toString('base64');
       this.samlAppRequest.setMetadataXml(base64);
     }
   }
diff --git a/console/src/app/pages/projects/apps/app-detail/app-detail.component.ts b/console/src/app/pages/projects/apps/app-detail/app-detail.component.ts
index 2f743acb7..f6ebd94c4 100644
--- a/console/src/app/pages/projects/apps/app-detail/app-detail.component.ts
+++ b/console/src/app/pages/projects/apps/app-detail/app-detail.component.ts
@@ -786,7 +786,7 @@ export class AppDetailComponent implements OnInit, OnDestroy {
       this.app.samlConfig.metadataXml &&
       typeof this.app.samlConfig.metadataXml === 'string'
     ) {
-      return Buffer.from(this.app?.samlConfig.metadataXml, 'base64').toString('ascii');
+      return Buffer.from(this.app?.samlConfig.metadataXml, 'base64').toString('utf-8');
     } else {
       return '';
     }
@@ -794,7 +794,7 @@ export class AppDetailComponent implements OnInit, OnDestroy {
 
   set decodedBase64(xmlString: string) {
     if (this.app && this.app.samlConfig && this.app.samlConfig.metadataXml) {
-      const base64 = Buffer.from(xmlString, 'ascii').toString('base64');
+      const base64 = Buffer.from(xmlString, 'utf-8').toString('base64');
 
       if (this.app.samlConfig) {
         this.app.samlConfig.metadataXml = base64;
diff --git a/console/src/app/pages/users/user-detail/auth-user-detail/auth-user-detail.component.ts b/console/src/app/pages/users/user-detail/auth-user-detail/auth-user-detail.component.ts
index 918304865..fa50b3b41 100644
--- a/console/src/app/pages/users/user-detail/auth-user-detail/auth-user-detail.component.ts
+++ b/console/src/app/pages/users/user-detail/auth-user-detail/auth-user-detail.component.ts
@@ -406,7 +406,7 @@ export class AuthUserDetailComponent implements OnDestroy {
               this.metadata = resp.resultList.map((md) => {
                 return {
                   key: md.key,
-                  value: Buffer.from(md.value as string, 'base64').toString('ascii'),
+                  value: Buffer.from(md.value as string, 'base64').toString('utf8'),
                 };
               });
             })
diff --git a/console/src/app/pages/users/user-detail/user-detail/user-detail.component.ts b/console/src/app/pages/users/user-detail/user-detail/user-detail.component.ts
index a961b6cbd..191115e59 100644
--- a/console/src/app/pages/users/user-detail/user-detail/user-detail.component.ts
+++ b/console/src/app/pages/users/user-detail/user-detail/user-detail.component.ts
@@ -508,7 +508,7 @@ export class UserDetailComponent implements OnInit {
         this.metadata = resp.resultList.map((md) => {
           return {
             key: md.key,
-            value: Buffer.from(md.value as string, 'base64').toString('ascii'),
+            value: Buffer.from(md.value as string, 'base64').toString('utf-8'),
           };
         });
       })