fix(console): delete provider, refactor add and update methods (#5515)

fix: provider deletion
This commit is contained in:
Max Peintner
2023-03-21 17:48:35 +01:00
committed by GitHub
parent a6c471b2e4
commit 9b41758af0
14 changed files with 425 additions and 840 deletions
+3 -9
View File
@@ -156,8 +156,6 @@ import {
RemoveIAMMemberResponse,
RemoveIDPFromLoginPolicyRequest,
RemoveIDPFromLoginPolicyResponse,
RemoveIDPRequest,
RemoveIDPResponse,
RemoveLabelPolicyFontRequest,
RemoveLabelPolicyFontResponse,
RemoveLabelPolicyIconDarkRequest,
@@ -898,12 +896,6 @@ export class AdminService {
return this.grpcService.admin.listLoginPolicyIDPs(req, null).then((resp) => resp.toObject());
}
public removeIDP(id: string): Promise<RemoveIDPResponse.AsObject> {
const req = new RemoveIDPRequest();
req.setIdpId(id);
return this.grpcService.admin.removeIDP(req, null).then((resp) => resp.toObject());
}
public deactivateIDP(id: string): Promise<DeactivateIDPResponse.AsObject> {
const req = new DeactivateIDPRequest();
req.setIdpId(id);
@@ -1002,7 +994,9 @@ export class AdminService {
return this.grpcService.admin.updateGitHubEnterpriseServerProvider(req, null).then((resp) => resp.toObject());
}
public deleteProvider(req: DeleteProviderRequest): Promise<DeleteProviderResponse.AsObject> {
public deleteProvider(id: string): Promise<DeleteProviderResponse.AsObject> {
const req = new DeleteProviderRequest();
req.setId(id);
return this.grpcService.admin.deleteProvider(req, null).then((resp) => resp.toObject());
}
+3 -9
View File
@@ -330,8 +330,6 @@ import {
RemoveMultiFactorFromLoginPolicyResponse,
RemoveOrgDomainRequest,
RemoveOrgDomainResponse,
RemoveOrgIDPRequest,
RemoveOrgIDPResponse,
RemoveOrgMemberRequest,
RemoveOrgMemberResponse,
RemoveOrgMetadataRequest,
@@ -857,12 +855,6 @@ export class ManagementService {
return this.grpcService.mgmt.listLoginPolicyIDPs(req, null).then((resp) => resp.toObject());
}
public removeOrgIDP(idpId: string): Promise<RemoveOrgIDPResponse.AsObject> {
const req = new RemoveOrgIDPRequest();
req.setIdpId(idpId);
return this.grpcService.mgmt.removeOrgIDP(req, null).then((resp) => resp.toObject());
}
public deactivateOrgIDP(idpId: string): Promise<DeactivateOrgIDPResponse.AsObject> {
const req = new DeactivateOrgIDPRequest();
req.setIdpId(idpId);
@@ -961,7 +953,9 @@ export class ManagementService {
return this.grpcService.mgmt.updateGitHubEnterpriseServerProvider(req, null).then((resp) => resp.toObject());
}
public deleteProvider(req: DeleteProviderRequest): Promise<DeleteProviderResponse.AsObject> {
public deleteProvider(id: string): Promise<DeleteProviderResponse.AsObject> {
const req = new DeleteProviderRequest();
req.setId(id);
return this.grpcService.mgmt.deleteProvider(req, null).then((resp) => resp.toObject());
}