chore: standardised the eslint config structure accross the project (#11814)

console/src/app/directives/scrollable/scrollable.directive.ts

@@ -25,6 +25,8 @@ export class ScrollableDirective {
       if (top === 0) {
         this.scrollPosition.emit('top');
       }
-    } catch (err) {}
+    } catch {
+      // scroll position detection may fail in some browsers
+    }
   }
 }

console/src/app/modules/display-json-dialog/display-json-dialog.component.ts

@@ -19,8 +19,6 @@ export class DisplayJsonDialogComponent {
     @Inject(MAT_DIALOG_DATA) public data: any,
   ) {
     this.event = data.event;
-    if ((data.event as Event) && data.event.payload) {
-    }
   }
 
   public closeDialog(): void {

console/src/app/modules/idp-table/idp-table.component.ts

@@ -235,6 +235,7 @@ export class IdpTableComponent implements OnInit, OnDestroy {
     } else if (this.service instanceof ManagementService) {
       return ['/org', 'idp', 'create'];
     }
+    return undefined;
   }
 
   public routerLinkForRow(row: Provider.AsObject): any {

console/src/app/modules/input/input.directive.ts

@@ -248,6 +248,7 @@ export class InputDirective implements MatFormFieldControl<any>, OnChanges, OnDe
     this._previousNativeValue = this.value;
 
     // Force setter to be called in case id was not specified.
+    // eslint-disable-next-line no-self-assign
     this.id = this.id;
 
     // On some versions of iOS the caret gets stuck in the wrong place when holding down the delete

console/src/app/modules/policies/notification-sms-provider/dialog-add-sms-provider/dialog-add-sms-provider.component.ts

@@ -48,7 +48,7 @@ export class DialogAddSMSProviderComponent {
     });
 
     this.smsProviders = data.smsProviders;
-    if (!!this.twilio) {
+    if (this.twilio) {
       this.twilioForm.patchValue(this.twilio);
     } else {
       this.twilioForm.addControl('token', new FormControl('', requiredValidator));

console/src/app/modules/policies/notification-sms-provider/notification-sms-provider.component.ts

@@ -61,7 +61,7 @@ export class NotificationSMSProviderComponent implements OnInit {
 
     dialogRef.afterClosed().subscribe((req: AddSMSProviderTwilioRequest | UpdateSMSProviderTwilioRequest) => {
       if (req) {
-        if (!!this.twilio) {
+        if (this.twilio) {
           this.service
             .updateSMSProviderTwilio(req as UpdateSMSProviderTwilioRequest)
             .then(() => {

console/src/app/services/statehandler/statehandler.service.ts

@@ -72,10 +72,9 @@ export class StatehandlerServiceImpl implements StatehandlerService, OnDestroy {
   removeParam(key: string, sourceURL: string) {
     var rtn = sourceURL.split('?')[0],
       param,
-      params_arr = [],
       queryString = sourceURL.indexOf('?') !== -1 ? sourceURL.split('?')[1] : '';
     if (queryString !== '') {
-      params_arr = queryString.split('&');
+      var params_arr = queryString.split('&');
       for (var i = params_arr.length - 1; i >= 0; i -= 1) {
         param = params_arr[i].split('=')[0];
         if (param === key) {

console/src/app/utils/color.ts

@@ -72,7 +72,7 @@ export function getColor(toGen: string): string {
 
 export function getMembershipColor(role: string): Color {
   const hash = hashCode(role);
-  let color = COLORS[hash % COLORS.length];
+  let color: Color;
 
   switch (role) {
     case 'IAM_OWNER':