From 78e6d1909834bf748ffd9573eaa26975cbfea1f0 Mon Sep 17 00:00:00 2001
From: Fabiennne <fabienne.gerschwiler@gmail.com>
Date: Mon, 30 Mar 2020 11:42:22 +0200
Subject: [PATCH] fix: reformat test

---
 internal/proto/struct_test.go | 142 ++++++++++++++++++++++++----------
 1 file changed, 102 insertions(+), 40 deletions(-)

diff --git a/internal/proto/struct_test.go b/internal/proto/struct_test.go
index eeed7c63f..53e2503f1 100644
--- a/internal/proto/struct_test.go
+++ b/internal/proto/struct_test.go
@@ -4,50 +4,112 @@ import (
 	"testing"
 
 	pb_struct "github.com/golang/protobuf/ptypes/struct"
-
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
 )
 
-func TestToPBStruct(t *testing.T) {
-	obj := struct {
-		ID   string
-		Name string
-		Seq  uint64
+func Test_ToPBStruct(t *testing.T) {
+	type obj struct {
+		ID  string
+		Seq uint64
+	}
+	type args struct {
+		obj obj
+	}
+	tests := []struct {
+		name    string
+		args    args
+		wantErr bool
+		length  int
+		result  obj
 	}{
-		ID:   "asdf",
-		Name: "ueli",
-		Seq:  208582075,
+		{
+			name: "to pb stuct",
+			args: args{
+				obj: obj{ID: "ID", Seq: 12345},
+			},
+			wantErr: false,
+			length:  2,
+			result:  obj{ID: "ID", Seq: 12345},
+		},
+		{
+			name: "empty struct",
+			args: args{
+				obj: obj{},
+			},
+			wantErr: false,
+			length:  2,
+			result:  obj{ID: "", Seq: 0},
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			fields, err := ToPBStruct(tt.args.obj)
+			if tt.wantErr && err == nil {
+				t.Errorf("got wrong result, should get err: actual: %v ", err)
+			}
+			if !tt.wantErr && len(fields.Fields) != tt.length {
+				t.Errorf("got wrong result length, expecting: %v, actual: %v ", tt.length, len(fields.Fields))
+			}
+			if !tt.wantErr && tt.result.ID != fields.Fields["ID"].GetStringValue() {
+				t.Errorf("got wrong result, ID should be same: expecting: %v, actual: %v ", tt.result.ID, fields.Fields["ID"].GetStringValue())
+			}
+			if !tt.wantErr && int(tt.result.Seq) != int(fields.Fields["Seq"].GetNumberValue()) {
+				t.Errorf("got wrong result, Seq should be same: expecting: %v, actual: %v ", tt.result.Seq, fields.Fields["Seq"].GetStringValue())
+			}
+		})
 	}
-	fields, err := ToPBStruct(&obj)
-	require.NoError(t, err)
-	require.Len(t, fields.Fields, 3)
-
-	assert.Equal(t, obj.ID, fields.Fields["ID"].GetStringValue())
-	assert.Equal(t, int(obj.Seq), int(fields.Fields["Seq"].GetNumberValue()))
-	assert.Equal(t, obj.Name, fields.Fields["Name"].GetStringValue())
 }
 
-func TestFromPBStruct(t *testing.T) {
-	name := "ueli"
-	id := "asdf"
-	seq := float64(208582075)
-	s := &pb_struct.Struct{Fields: map[string]*pb_struct.Value{
-		"ID":   &pb_struct.Value{Kind: &pb_struct.Value_StringValue{StringValue: id}},
-		"Name": &pb_struct.Value{Kind: &pb_struct.Value_StringValue{StringValue: name}},
-		"Seq":  &pb_struct.Value{Kind: &pb_struct.Value_NumberValue{NumberValue: seq}},
-	}}
-
-	obj := struct {
-		ID   string
-		Name string
-		Seq  uint64
-	}{}
-
-	err := FromPBStruct(&obj, s)
-	require.NoError(t, err)
-
-	assert.Equal(t, id, obj.ID)
-	assert.Equal(t, name, obj.Name)
-	assert.Equal(t, int(seq), int(obj.Seq))
+func Test_FromPBStruct(t *testing.T) {
+	type obj struct {
+		ID  string
+		Seq uint64
+	}
+	type args struct {
+		obj    *obj
+		fields *pb_struct.Struct
+	}
+	tests := []struct {
+		name    string
+		args    args
+		wantErr bool
+		result  obj
+	}{
+		{
+			name: "from pb stuct",
+			args: args{
+				obj: &obj{},
+				fields: &pb_struct.Struct{Fields: map[string]*pb_struct.Value{
+					"ID":  &pb_struct.Value{Kind: &pb_struct.Value_StringValue{StringValue: "ID"}},
+					"Seq": &pb_struct.Value{Kind: &pb_struct.Value_NumberValue{NumberValue: 12345}},
+				},
+				},
+			},
+			wantErr: false,
+			result:  obj{ID: "ID", Seq: 12345},
+		},
+		{
+			name: "no fields",
+			args: args{
+				obj: &obj{},
+				fields: &pb_struct.Struct{Fields: map[string]*pb_struct.Value{},
+				},
+			},
+			wantErr: false,
+			result:  obj{ID: "", Seq: 0},
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			err := FromPBStruct(tt.args.obj, tt.args.fields)
+			if tt.wantErr && err == nil {
+				t.Errorf("got wrong result, should get err: actual: %v ", err)
+			}
+			if !tt.wantErr && tt.result.ID != tt.args.obj.ID {
+				t.Errorf("got wrong result, ID should be same: expecting: %v, actual: %v ", tt.result.ID, tt.args.obj.ID)
+			}
+			if !tt.wantErr && int(tt.result.Seq) != int(tt.args.obj.Seq) {
+				t.Errorf("got wrong result, Seq should be same: expecting: %v, actual: %v ", tt.result.Seq, tt.args.obj.Seq)
+			}
+		})
+	}
 }