andwati/zitadel
1
0
Fork 0
mirror of https://github.com/andwati/zitadel.git synced 2026-11-12 00:55:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: move gofakeit integration testing calls (#10684)

Browse Source 
# Which Problems Are Solved

Flakiness and conflicts in value from gofakeit.

# How the Problems Are Solved

Move Gofakeit calls to the integration package, to guarantee proper
usage and values for integration testing.

# Additional Changes

None

# Additional Context

None
This commit is contained in:
Stefan Benz
2025-09-10 09:00:31 +03:00
committed by GitHub
parent b9b9baf67f
commit 492f1826ee
71 changed files with 1083 additions and 980 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/api/grpc/settings/v2/integration_test/query_test.go
+2 -3
View File
@@ -7,7 +7,6 @@ import (
"testing"
"time"
"github.com/brianvoe/gofakeit/v6"
"github.com/muhlemmer/gu"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
@@ -359,7 +358,7 @@ func TestServer_GetActiveIdentityProviders(t *testing.T) {
func TestServer_GetHostedLoginTranslation(t *testing.T) {
// Given
translations := map[string]any{"loginTitle": gofakeit.Slogan()}
translations := map[string]any{"loginTitle": integration.Slogan()}
protoTranslations, err := structpb.NewStruct(translations)
require.NoError(t, err)
@@ -369,7 +368,7 @@ func TestServer_GetHostedLoginTranslation(t *testing.T) {
OrganizationId: Instance.DefaultOrg.GetId(),
},
Translations: protoTranslations,
Locale: gofakeit.LanguageBCP(),
Locale: integration.Language(),
}
savedTranslation, err := Client.SetHostedLoginTranslation(AdminCTX, setupRequest)
require.NoError(t, err)
internal/api/grpc/settings/v2beta/integration_test/settings_test.go
+7 -8
View File
@@ -7,7 +7,6 @@ import (
"testing"
"time"
"github.com/brianvoe/gofakeit/v6"
"github.com/muhlemmer/gu"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
@@ -236,7 +235,7 @@ func TestServer_SetOrganizationSettings(t *testing.T) {
{
name: "success no changes",
prepare: func(req *settings.SetOrganizationSettingsRequest) {
orgResp := instance.CreateOrganization(iamOwnerCTX, integration.OrganizationName(), gofakeit.Email())
orgResp := instance.CreateOrganization(iamOwnerCTX, integration.OrganizationName(), integration.Email())
req.OrganizationId = orgResp.GetOrganizationId()
},
args: args{
@@ -251,7 +250,7 @@ func TestServer_SetOrganizationSettings(t *testing.T) {
{
name: "success user uniqueness",
prepare: func(req *settings.SetOrganizationSettingsRequest) {
orgResp := instance.CreateOrganization(iamOwnerCTX, integration.OrganizationName(), gofakeit.Email())
orgResp := instance.CreateOrganization(iamOwnerCTX, integration.OrganizationName(), integration.Email())
req.OrganizationId = orgResp.GetOrganizationId()
},
args: args{
@@ -268,7 +267,7 @@ func TestServer_SetOrganizationSettings(t *testing.T) {
{
name: "success no change",
prepare: func(req *settings.SetOrganizationSettingsRequest) {
orgResp := instance.CreateOrganization(iamOwnerCTX, integration.OrganizationName(), gofakeit.Email())
orgResp := instance.CreateOrganization(iamOwnerCTX, integration.OrganizationName(), integration.Email())
req.OrganizationId = orgResp.GetOrganizationId()
},
args: args{
@@ -339,7 +338,7 @@ func TestServer_DeleteOrganizationSettings(t *testing.T) {
{
name: "permission error",
prepare: func(t *testing.T, req *settings.DeleteOrganizationSettingsRequest) {
orgResp := instance.CreateOrganization(iamOwnerCTX, integration.OrganizationName(), gofakeit.Email())
orgResp := instance.CreateOrganization(iamOwnerCTX, integration.OrganizationName(), integration.Email())
req.OrganizationId = orgResp.GetOrganizationId()
instance.SetOrganizationSettings(iamOwnerCTX, t, orgResp.GetOrganizationId(), true)
},
@@ -377,7 +376,7 @@ func TestServer_DeleteOrganizationSettings(t *testing.T) {
{
name: "success user uniqueness",
prepare: func(t *testing.T, req *settings.DeleteOrganizationSettingsRequest) {
orgResp := instance.CreateOrganization(iamOwnerCTX, integration.OrganizationName(), gofakeit.Email())
orgResp := instance.CreateOrganization(iamOwnerCTX, integration.OrganizationName(), integration.Email())
req.OrganizationId = orgResp.GetOrganizationId()
instance.SetOrganizationSettings(iamOwnerCTX, t, orgResp.GetOrganizationId(), true)
},
@@ -393,7 +392,7 @@ func TestServer_DeleteOrganizationSettings(t *testing.T) {
{
name: "success no existing",
prepare: func(t *testing.T, req *settings.DeleteOrganizationSettingsRequest) {
orgResp := instance.CreateOrganization(iamOwnerCTX, integration.OrganizationName(), gofakeit.Email())
orgResp := instance.CreateOrganization(iamOwnerCTX, integration.OrganizationName(), integration.Email())
req.OrganizationId = orgResp.GetOrganizationId()
},
args: args{
@@ -408,7 +407,7 @@ func TestServer_DeleteOrganizationSettings(t *testing.T) {
{
name: "success already deleted",
prepare: func(t *testing.T, req *settings.DeleteOrganizationSettingsRequest) {
orgResp := instance.CreateOrganization(iamOwnerCTX, integration.OrganizationName(), gofakeit.Email())
orgResp := instance.CreateOrganization(iamOwnerCTX, integration.OrganizationName(), integration.Email())
req.OrganizationId = orgResp.GetOrganizationId()
instance.SetOrganizationSettings(iamOwnerCTX, t, orgResp.GetOrganizationId(), true)
instance.DeleteOrganizationSettings(iamOwnerCTX, t, orgResp.GetOrganizationId())