mirror of
https://github.com/andwati/zitadel.git
synced 2026-11-18 19:25:13 +00:00
feat: native app links for passkeys (#12580)
# Which Problems Are Solved - Native iOS/Android passkeys need OS trust files on the ZITADEL domain; without them, Associated Domains / App Links verification fails. - Operators could not configure iOS Team ID + Bundle ID or Android package name + SHA-256 fingerprints on OIDC apps. - `/.well-known/apple-app-site-association` and `/.well-known/assetlinks.json` were not served from application config. # How the Problems Are Solved - Add iOS/Android app-link fields on OIDC app create/update (Application API v2 + Management), with validation. - Persist and project those fields; query active app-link configs instance-wide. - Serve AASA (`webcredentials`) and Digital Asset Links (`get_login_creds`) from well-known paths, with configurable `Cache-Control` and fingerprint normalization at serve time. - Console UI to edit the fields, with links to the well-known endpoints. - Operator docs for configuration, endpoints, caching, and verification. # Additional Changes - Document on API fields that well-known responses may be HTTP-cached and platform verifiers may delay propagation. - Runtime config: `WellKnown.AppLinksCacheControlMaxAge` (default `5m`; `0` → `no-store`). # Additional Context - Closes #12497 - Implemented and reviewed as stack: - #12531 API contract - #12532 storage wiring - #12536 well-known endpoints - #12537 console - #12547 docs --------- Co-authored-by: Cursor <[email protected]>
This commit is contained in:
@@ -669,3 +669,84 @@ func TestOIDCOriginAllowList(t *testing.T) {
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestOIDCApp_AppLinkConfigValid(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
app *OIDCApp
|
||||
want bool
|
||||
}{
|
||||
{
|
||||
name: "empty config",
|
||||
app: &OIDCApp{},
|
||||
want: true,
|
||||
},
|
||||
{
|
||||
name: "ios both set",
|
||||
app: &OIDCApp{
|
||||
IOSTeamID: gu.Ptr("TEAMID"),
|
||||
IOSBundleID: gu.Ptr("com.example.app"),
|
||||
},
|
||||
want: true,
|
||||
},
|
||||
{
|
||||
name: "ios team only",
|
||||
app: &OIDCApp{
|
||||
IOSTeamID: gu.Ptr("TEAMID"),
|
||||
},
|
||||
want: false,
|
||||
},
|
||||
{
|
||||
name: "ios bundle only",
|
||||
app: &OIDCApp{
|
||||
IOSBundleID: gu.Ptr("com.example.app"),
|
||||
},
|
||||
want: false,
|
||||
},
|
||||
{
|
||||
name: "ios both empty strings",
|
||||
app: &OIDCApp{
|
||||
IOSTeamID: gu.Ptr(""),
|
||||
IOSBundleID: gu.Ptr(""),
|
||||
},
|
||||
want: true,
|
||||
},
|
||||
{
|
||||
name: "android package only",
|
||||
app: &OIDCApp{
|
||||
AndroidPackageName: gu.Ptr("com.example.app"),
|
||||
},
|
||||
want: true,
|
||||
},
|
||||
{
|
||||
name: "android package and fingerprints",
|
||||
app: &OIDCApp{
|
||||
AndroidPackageName: gu.Ptr("com.example.app"),
|
||||
AndroidSHA256CertFingerprints: []string{"AA:BB"},
|
||||
},
|
||||
want: true,
|
||||
},
|
||||
{
|
||||
name: "android fingerprints without package",
|
||||
app: &OIDCApp{
|
||||
AndroidSHA256CertFingerprints: []string{"AA:BB"},
|
||||
},
|
||||
want: false,
|
||||
},
|
||||
{
|
||||
name: "android fingerprints with empty package",
|
||||
app: &OIDCApp{
|
||||
AndroidPackageName: gu.Ptr(" "),
|
||||
AndroidSHA256CertFingerprints: []string{"AA:BB"},
|
||||
},
|
||||
want: false,
|
||||
},
|
||||
}
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
if got := tt.app.AppLinkConfigValid(); got != tt.want {
|
||||
t.Errorf("AppLinkConfigValid() = %v, want %v", got, tt.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user