mirror of
https://github.com/andwati/zitadel.git
synced 2026-11-12 09:05:12 +00:00
feat: native app links for passkeys (#12580)
# Which Problems Are Solved - Native iOS/Android passkeys need OS trust files on the ZITADEL domain; without them, Associated Domains / App Links verification fails. - Operators could not configure iOS Team ID + Bundle ID or Android package name + SHA-256 fingerprints on OIDC apps. - `/.well-known/apple-app-site-association` and `/.well-known/assetlinks.json` were not served from application config. # How the Problems Are Solved - Add iOS/Android app-link fields on OIDC app create/update (Application API v2 + Management), with validation. - Persist and project those fields; query active app-link configs instance-wide. - Serve AASA (`webcredentials`) and Digital Asset Links (`get_login_creds`) from well-known paths, with configurable `Cache-Control` and fingerprint normalization at serve time. - Console UI to edit the fields, with links to the well-known endpoints. - Operator docs for configuration, endpoints, caching, and verification. # Additional Changes - Document on API fields that well-known responses may be HTTP-cached and platform verifiers may delay propagation. - Runtime config: `WellKnown.AppLinksCacheControlMaxAge` (default `5m`; `0` → `no-store`). # Additional Context - Closes #12497 - Implemented and reviewed as stack: - #12531 API contract - #12532 storage wiring - #12536 well-known endpoints - #12537 console - #12547 docs --------- Co-authored-by: Cursor <[email protected]>
This commit is contained in:
@@ -0,0 +1,187 @@
|
||||
//go:build integration
|
||||
|
||||
package well_known_test
|
||||
|
||||
import (
|
||||
"context"
|
||||
"encoding/json"
|
||||
"io"
|
||||
"net/http"
|
||||
"os"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
|
||||
"github.com/zitadel/zitadel/internal/api/well_known"
|
||||
"github.com/zitadel/zitadel/internal/integration"
|
||||
"github.com/zitadel/zitadel/pkg/grpc/application/v2"
|
||||
)
|
||||
|
||||
var (
|
||||
CTX context.Context
|
||||
IAMOwnerCtx context.Context
|
||||
Instance *integration.Instance
|
||||
)
|
||||
|
||||
func TestMain(m *testing.M) {
|
||||
os.Exit(func() int {
|
||||
ctx, cancel := context.WithTimeout(context.Background(), 15*time.Minute)
|
||||
defer cancel()
|
||||
|
||||
Instance = integration.NewInstance(ctx)
|
||||
CTX = ctx
|
||||
IAMOwnerCtx = Instance.WithAuthorization(ctx, integration.UserTypeIAMOwner)
|
||||
return m.Run()
|
||||
}())
|
||||
}
|
||||
|
||||
func TestWellKnownAppLinks(t *testing.T) {
|
||||
issuer := Instance.OIDCIssuer()
|
||||
|
||||
t.Run("empty when no apps configured", func(t *testing.T) {
|
||||
assertEventuallyJSON(t, issuer+well_known.AppleAppSiteAssociationPath, map[string]any{
|
||||
"webcredentials": map[string]any{
|
||||
"apps": []any{},
|
||||
},
|
||||
})
|
||||
assertEventuallyJSON(t, issuer+well_known.AssetLinksPath, []any{})
|
||||
})
|
||||
|
||||
project := Instance.CreateProject(IAMOwnerCtx, t, Instance.DefaultOrg.GetId(), integration.ProjectName(), false, false)
|
||||
|
||||
ios1 := &application.IOSAppLinkConfig{TeamId: "TEAMAAAAAA", BundleId: "com.example.one"}
|
||||
android1 := &application.AndroidAppLinkConfig{
|
||||
PackageName: "com.example.one",
|
||||
Sha256CertFingerprints: []string{"11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11"},
|
||||
}
|
||||
createOIDCAppWithLinks(t, project.GetId(), ios1, android1)
|
||||
|
||||
ios2 := &application.IOSAppLinkConfig{TeamId: "TEAMBBBBBB", BundleId: "com.example.two"}
|
||||
createOIDCAppWithLinks(t, project.GetId(), ios2, nil)
|
||||
|
||||
android2 := &application.AndroidAppLinkConfig{
|
||||
PackageName: "com.example.two",
|
||||
Sha256CertFingerprints: []string{"22:22:22:22:22:22:22:22:22:22:22:22:22:22:22:22:22:22:22:22:22:22:22:22:22:22:22:22:22:22:22:22"},
|
||||
}
|
||||
createOIDCAppWithLinks(t, project.GetId(), nil, android2)
|
||||
|
||||
// duplicate iOS app id should be deduped in AASA
|
||||
createOIDCAppWithLinks(t, project.GetId(), ios1, nil)
|
||||
|
||||
assertEventuallyJSONUnorderedApps(t, issuer,
|
||||
[]string{
|
||||
"TEAMAAAAAA.com.example.one",
|
||||
"TEAMBBBBBB.com.example.two",
|
||||
},
|
||||
[]any{
|
||||
map[string]any{
|
||||
"relation": []any{"delegate_permission/common.get_login_creds"},
|
||||
"target": map[string]any{
|
||||
"namespace": "android_app",
|
||||
"package_name": "com.example.one",
|
||||
"sha256_cert_fingerprints": []any{android1.Sha256CertFingerprints[0]},
|
||||
},
|
||||
},
|
||||
map[string]any{
|
||||
"relation": []any{"delegate_permission/common.get_login_creds"},
|
||||
"target": map[string]any{
|
||||
"namespace": "android_app",
|
||||
"package_name": "com.example.two",
|
||||
"sha256_cert_fingerprints": []any{android2.Sha256CertFingerprints[0]},
|
||||
},
|
||||
},
|
||||
},
|
||||
)
|
||||
}
|
||||
|
||||
func createOIDCAppWithLinks(t *testing.T, projectID string, ios *application.IOSAppLinkConfig, android *application.AndroidAppLinkConfig) {
|
||||
t.Helper()
|
||||
_, err := Instance.Client.ApplicationV2.CreateApplication(IAMOwnerCtx, &application.CreateApplicationRequest{
|
||||
ProjectId: projectID,
|
||||
Name: integration.ApplicationName(),
|
||||
ApplicationType: &application.CreateApplicationRequest_OidcConfiguration{
|
||||
OidcConfiguration: &application.CreateOIDCApplicationRequest{
|
||||
RedirectUris: []string{"http://example.com"},
|
||||
ResponseTypes: []application.OIDCResponseType{application.OIDCResponseType_OIDC_RESPONSE_TYPE_CODE},
|
||||
GrantTypes: []application.OIDCGrantType{application.OIDCGrantType_OIDC_GRANT_TYPE_AUTHORIZATION_CODE},
|
||||
ApplicationType: application.OIDCApplicationType_OIDC_APP_TYPE_NATIVE,
|
||||
AuthMethodType: application.OIDCAuthMethodType_OIDC_AUTH_METHOD_TYPE_NONE,
|
||||
Version: application.OIDCVersion_OIDC_VERSION_1_0,
|
||||
AccessTokenType: application.OIDCTokenType_OIDC_TOKEN_TYPE_BEARER,
|
||||
Ios: ios,
|
||||
Android: android,
|
||||
},
|
||||
},
|
||||
})
|
||||
require.NoError(t, err)
|
||||
}
|
||||
|
||||
func assertEventuallyJSON(t *testing.T, url string, want any) {
|
||||
t.Helper()
|
||||
retryDuration, tick := integration.WaitForAndTickWithMaxDuration(CTX, time.Minute)
|
||||
require.EventuallyWithT(t, func(ct *assert.CollectT) {
|
||||
resp, err := http.Get(url)
|
||||
if !assert.NoError(ct, err) {
|
||||
return
|
||||
}
|
||||
defer func() {
|
||||
_, _ = io.Copy(io.Discard, resp.Body)
|
||||
_ = resp.Body.Close()
|
||||
}()
|
||||
if !assert.Equal(ct, http.StatusOK, resp.StatusCode) {
|
||||
return
|
||||
}
|
||||
assert.Contains(ct, resp.Header.Get("Content-Type"), "application/json")
|
||||
assert.Equal(ct, "public, max-age=300", resp.Header.Get("Cache-Control"))
|
||||
|
||||
body, err := io.ReadAll(resp.Body)
|
||||
if !assert.NoError(ct, err) {
|
||||
return
|
||||
}
|
||||
var got any
|
||||
if !assert.NoError(ct, json.Unmarshal(body, &got)) {
|
||||
return
|
||||
}
|
||||
assert.Equal(ct, want, got)
|
||||
}, retryDuration, tick)
|
||||
}
|
||||
|
||||
func assertEventuallyJSONUnorderedApps(t *testing.T, url string, wantApps []string, wantAssetLinks []any) {
|
||||
t.Helper()
|
||||
retryDuration, tick := integration.WaitForAndTickWithMaxDuration(CTX, time.Minute)
|
||||
require.EventuallyWithT(t, func(ct *assert.CollectT) {
|
||||
aasaResp, err := http.Get(url + well_known.AppleAppSiteAssociationPath)
|
||||
if !assert.NoError(ct, err) {
|
||||
return
|
||||
}
|
||||
defer aasaResp.Body.Close()
|
||||
if !assert.Equal(ct, http.StatusOK, aasaResp.StatusCode) {
|
||||
return
|
||||
}
|
||||
var aasa struct {
|
||||
WebCredentials struct {
|
||||
Apps []string `json:"apps"`
|
||||
} `json:"webcredentials"`
|
||||
}
|
||||
if !assert.NoError(ct, json.NewDecoder(aasaResp.Body).Decode(&aasa)) {
|
||||
return
|
||||
}
|
||||
assert.ElementsMatch(ct, wantApps, aasa.WebCredentials.Apps)
|
||||
|
||||
assetResp, err := http.Get(url + well_known.AssetLinksPath)
|
||||
if !assert.NoError(ct, err) {
|
||||
return
|
||||
}
|
||||
defer assetResp.Body.Close()
|
||||
if !assert.Equal(ct, http.StatusOK, assetResp.StatusCode) {
|
||||
return
|
||||
}
|
||||
var got []any
|
||||
if !assert.NoError(ct, json.NewDecoder(assetResp.Body).Decode(&got)) {
|
||||
return
|
||||
}
|
||||
assert.ElementsMatch(ct, wantAssetLinks, got)
|
||||
}, retryDuration, tick)
|
||||
}
|
||||
Reference in New Issue
Block a user