fix: correctly send links to login v2 in email notifications (#10711)

# Which Problems Are Solved

There were still some emails (passkey registration and domain claimed)
sent with links pointing to login v1 even when the login v2 was enabled
for the instance.
Also while looking into the issue, it was discovered that some links
pointing to login V2 were not correctly generated.


# How the Problems Are Solved

- Added default paths for passkey registration and domain claimed
notifications
- Fixed the existing paths to properly handle concatenation (resp. use
`url.ResolveReference`)
  - Change their go types (from string) to `*url.URL` 
  - Added a mapstructure hook for string to url
- Removed unnecessary `InstanceSetupFeatures` and corresponding
conversions
- Refactored the methods on the `login.DefaultPaths` struct and added an
interface to the `Commands` to only need to pass a single config (and
not every method)
- Added an `OriginURL` method to the `DomainCtx` to prevent going from
url to string and back
- Added the use of the templates in case of enabled login v2 for passkey
registration and domain claimed)

# Additional Changes

None

# Additional Context

closes #10643

---------

Co-authored-by: Max Peintner <[email protected]>
Co-authored-by: Livio Spring <[email protected]>
Co-authored-by: Livio Spring <[email protected]>
Co-authored-by: Max Peintner <[email protected]>
Co-authored-by: Gayathri Vijayan <[email protected]>

internal/command/instance_test.go

@@ -3,15 +3,12 @@ package command
 import (
 	"context"
 	"encoding/json"
-	"net/url"
 	"slices"
 	"strings"
 	"testing"
 	"time"
 
-	"github.com/muhlemmer/gu"
 	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
 	"go.uber.org/mock/gomock"
 	"golang.org/x/text/language"
 
@@ -21,7 +18,6 @@ import (
 	"github.com/zitadel/zitadel/internal/crypto"
 	"github.com/zitadel/zitadel/internal/domain"
 	"github.com/zitadel/zitadel/internal/eventstore"
-	"github.com/zitadel/zitadel/internal/feature"
 	"github.com/zitadel/zitadel/internal/id"
 	id_mock "github.com/zitadel/zitadel/internal/id/mock"
 	"github.com/zitadel/zitadel/internal/repository/instance"
@@ -1769,118 +1765,3 @@ func TestCommandSide_RemoveInstance(t *testing.T) {
 		})
 	}
 }
-
-func TestInstanceSetupFeatures_ToInstanceFeatures(t *testing.T) {
-	t.Parallel()
-
-	type fields struct {
-		LoginDefaultOrg                *bool
-		UserSchema                     *bool
-		ImprovedPerformance            []feature.ImprovedPerformanceType
-		DebugOIDCParentError           *bool
-		OIDCSingleV1SessionTermination *bool
-		LoginV2                        *InstanceSetupFeatureLoginV2
-		PermissionCheckV2              *bool
-		ManagementConsoleUseV2UserApi  *bool
-		EnableRelationalTables         *bool
-	}
-
-	correctlyParsedURI, err := url.Parse("https://example.com")
-	require.NoError(t, err)
-
-	tt := []struct {
-		name    string
-		fields  fields
-		want    *InstanceFeatures
-		wantErr bool
-	}{
-		{
-			name:   "nil features returns nil",
-			fields: fields{},
-			want:   &InstanceFeatures{},
-		},
-		{
-			name: "all fields no login v2",
-			fields: fields{
-				LoginDefaultOrg:                gu.Ptr(true),
-				UserSchema:                     gu.Ptr(false),
-				ImprovedPerformance:            []feature.ImprovedPerformanceType{feature.ImprovedPerformanceTypeOrgDomainVerified},
-				DebugOIDCParentError:           gu.Ptr(true),
-				OIDCSingleV1SessionTermination: gu.Ptr(false),
-				PermissionCheckV2:              gu.Ptr(true),
-				ManagementConsoleUseV2UserApi:  gu.Ptr(false),
-				EnableRelationalTables:         gu.Ptr(true),
-			},
-			want: &InstanceFeatures{
-				LoginDefaultOrg:                gu.Ptr(true),
-				UserSchema:                     gu.Ptr(false),
-				ImprovedPerformance:            []feature.ImprovedPerformanceType{feature.ImprovedPerformanceTypeOrgDomainVerified},
-				DebugOIDCParentError:           gu.Ptr(true),
-				OIDCSingleV1SessionTermination: gu.Ptr(false),
-				LoginV2:                        nil,
-				PermissionCheckV2:              gu.Ptr(true),
-				ManagementConsoleUseV2UserApi:  gu.Ptr(false),
-				EnableRelationalTables:         gu.Ptr(true),
-			},
-		},
-		{
-			name: "with login v2 no base uri",
-			fields: fields{
-				LoginV2: &InstanceSetupFeatureLoginV2{
-					Required: true,
-				},
-			},
-			want: &InstanceFeatures{
-				LoginV2: &feature.LoginV2{
-					Required: true,
-				},
-			},
-		},
-		{
-			name: "with login v2 valid base uri",
-			fields: fields{
-				LoginV2: &InstanceSetupFeatureLoginV2{
-					Required: true,
-					BaseURI:  gu.Ptr("https://example.com"),
-				},
-			},
-			want: &InstanceFeatures{
-				LoginV2: &feature.LoginV2{
-					Required: true,
-					BaseURI:  correctlyParsedURI,
-				},
-			},
-		},
-		{
-			name: "with login v2 invalid base uri",
-			fields: fields{
-				LoginV2: &InstanceSetupFeatureLoginV2{
-					Required: true,
-					BaseURI:  gu.Ptr("://invalid"),
-				},
-			},
-			wantErr: true,
-		},
-	}
-	for _, tc := range tt {
-		t.Run(tc.name, func(t *testing.T) {
-			t.Parallel()
-
-			f := &InstanceSetupFeatures{
-				LoginDefaultOrg:                tc.fields.LoginDefaultOrg,
-				UserSchema:                     tc.fields.UserSchema,
-				ImprovedPerformance:            tc.fields.ImprovedPerformance,
-				DebugOIDCParentError:           tc.fields.DebugOIDCParentError,
-				OIDCSingleV1SessionTermination: tc.fields.OIDCSingleV1SessionTermination,
-				LoginV2:                        tc.fields.LoginV2,
-				PermissionCheckV2:              tc.fields.PermissionCheckV2,
-				ManagementConsoleUseV2UserApi:  tc.fields.ManagementConsoleUseV2UserApi,
-				EnableRelationalTables:         tc.fields.EnableRelationalTables,
-			}
-			got, err := f.ToInstanceFeatures()
-
-			require.Equal(t, tc.wantErr, err != nil)
-			assert.Equal(t, tc.want, got)
-		})
-	}
-}