chore: update passwap v0.12.1 and align hash validation defaults/errors (#12179)

mirror of https://github.com/andwati/zitadel.git synced 2026-10-18 05:52:51 +00:00

# Which Problems Are Solved

- Upgrading to `zitadel/passwap` v0.12.1 introduced new encoded-hash
validation paths that still had review feedback open.
- Secret hasher defaults were internally inconsistent (`Hasher.Cost: 4`
vs `Limits.Bcrypt.MinCost: 10`), which could reject hashes created by
the configured hasher.
- New validation error IDs/messages and test coverage needed to be
aligned with project conventions and expected behavior branches.

# How the Problems Are Solved

- Kept the dependency upgrade to `zitadel/passwap` v0.12.1 and completed
the validation integration.
- Updated `ValidateEncodedHash` error handling in
`internal/crypto/passwap.go` to:
  - use unique random-style error IDs,
  - return `Errors.Hash.NotSupported` for no-verifier cases,
  - keep invalid-hash branches mapped to invalid argument errors.
- Expanded `TestHasher_ValidateEncodedHash` in
`internal/crypto/passwap_test.go` to cover and assert:
  - bounds error branch,
  - no-verifier branch,
  - generic invalid-hash branch,
  - expected ZITADEL error IDs/messages.
- Restored lost inline verifier-context comments for argon2 and md5plain
verifier entries.

# Additional Changes

- Added the missing explanatory `Limits` comment for `SecretHasher` in
`cmd/defaults.yaml`.
- Corrected `SecretHasher.Limits.Bcrypt.MinCost` from `10` to `4` to
match the configured default bcrypt cost and avoid configuration
footguns.

# Additional Context

- Follow-up for PR review feedback in
https://github.com/zitadel/zitadel/pull/12179#pullrequestreview-4313121965

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: Livio Spring <[email protected]>

This commit is contained in:

Tim Möhlmann

2026-06-05 14:48:35 +02:00

committed by

GitHub

co-authored by

copilot-swe-agent[bot] <198982749+[email protected]>

Livio Spring

parent f85a2373c5

commit 25e263394e

12 changed files with 421 additions and 75 deletions

									
										go.mod
									
		+1
		-1
	
												View File
												
				@@ -101,7 +101,7 @@ require (

					github.com/zitadel/exifremove v0.1.0

					github.com/zitadel/logging v0.7.0

					github.com/zitadel/oidc/v3 v3.47.5

					github.com/zitadel/passwap v0.11.0

					github.com/zitadel/passwap v0.12.1

					github.com/zitadel/saml v0.4.1

					github.com/zitadel/schema v1.3.2

					github.com/zitadel/sloggcp v0.6.0