feat(console): organization overview table, table, org context filtering, fix grpc error log, cleanup pipes (#796)

* chore(deps-dev): bump @angular/cli from 10.0.8 to 10.1.3 in /console (#785) Bumps [@angular/cli](https://github.com/angular/angular-cli) from 10.0.8 to 10.1.3. - [Release notes](https://github.com/angular/angular-cli/releases) - [Commits](https://github.com/angular/angular-cli/compare/v10.0.8...v10.1.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump @angular-devkit/build-angular in /console (#784) Bumps [@angular-devkit/build-angular](https://github.com/angular/angular-cli) from 0.1000.8 to 0.1001.3. - [Release notes](https://github.com/angular/angular-cli/releases) - [Commits](https://github.com/angular/angular-cli/commits) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Max Peintner <[email protected]> * chore(deps-dev): bump @angular/language-service in /console (#783) Bumps [@angular/language-service](https://github.com/angular/angular/tree/HEAD/packages/language-service) from 10.1.0 to 10.1.3. - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/master/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/10.1.3/packages/language-service) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump stylelint from 13.7.1 to 13.7.2 in /console (#782) Bumps [stylelint](https://github.com/stylelint/stylelint) from 13.7.1 to 13.7.2. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md) - [Commits](https://github.com/stylelint/stylelint/compare/13.7.1...13.7.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump karma from 5.2.1 to 5.2.3 in /console (#781) Bumps [karma](https://github.com/karma-runner/karma) from 5.2.1 to 5.2.3. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](https://github.com/karma-runner/karma/compare/v5.2.1...v5.2.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump moment from 2.27.0 to 2.29.0 in /console (#780) Bumps [moment](https://github.com/moment/moment) from 2.27.0 to 2.29.0. - [Release notes](https://github.com/moment/moment/releases) - [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md) - [Commits](https://github.com/moment/moment/compare/2.27.0...2.29.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump @types/node from 14.6.4 to 14.11.2 in /console (#778) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.6.4 to 14.11.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump prettier from 2.1.1 to 2.1.2 in /console (#757) Bumps [prettier](https://github.com/prettier/prettier) from 2.1.1 to 2.1.2. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/2.1.1...2.1.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump ts-protoc-gen from 0.12.0 to 0.13.0 in /console (#737) Bumps [ts-protoc-gen](https://github.com/improbable-eng/ts-protoc-gen) from 0.12.0 to 0.13.0. - [Release notes](https://github.com/improbable-eng/ts-protoc-gen/releases) - [Changelog](https://github.com/improbable-eng/ts-protoc-gen/blob/master/CHANGELOG.md) - [Commits](https://github.com/improbable-eng/ts-protoc-gen/compare/0.12.0...0.13.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump jasmine-spec-reporter in /console (#762) Bumps [jasmine-spec-reporter](https://github.com/bcaudan/jasmine-spec-reporter) from 5.0.2 to 6.0.0. - [Release notes](https://github.com/bcaudan/jasmine-spec-reporter/releases) - [Changelog](https://github.com/bcaudan/jasmine-spec-reporter/blob/master/CHANGELOG.md) - [Commits](https://github.com/bcaudan/jasmine-spec-reporter/compare/v5.0.2...v6.0.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Max Peintner <[email protected]> * fix: package * change html lang to translation lang * disable detail view org idp * catch errorcode 16 in auth response interceptor * new icons * refactor pipes, idp table config * fix router guard * lint * allowed commonjs deps * Update console/src/assets/i18n/en.json Co-authored-by: Florian Forster <[email protected]> * Update console/src/assets/i18n/de.json Co-authored-by: Florian Forster <[email protected]> * clear table warning * org overview table, header filter * toolbar filter * user table filter * fix org filter themed color, reject error * org context filter * button cleanup * commonjs deps, remove a11y module * replace progressbar with spinner * dynamic user, org filter * ts lint, scss lint * cleanup table, row highlighting * lint * fix i18n description, refresh idp list in login p * remove async from grpc services, fix external idp * remove external idp * fix theme toggle * change iam policy header i18n * sticky action columns * lint * add i18n filter to user, remove unused org code Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Florian Forster <[email protected]>
2026-11-06 14:22:15 +00:00 · 2020-10-01 15:53:43 +02:00
parent bdcf9fcc5c
commit 124988e2d2
119 changed files with 1361 additions and 1451 deletions
@@ -18,8 +18,4 @@
  .ok-button {
    margin-left: .5rem;
  }
-
-  button {
-    border-radius: .5rem;
-  }
 }
@@ -103,11 +103,9 @@ export class ChangesComponent implements OnInit {
            this._loading.next(true);

            return from(col).pipe(
+                take(1),
                tap((res: Changes) => {
-                    let values = res.toObject().changesList;
-                    // If prepending, reverse the batch order
-                    values = false ? values.reverse() : values;
-
+                    const values = res.toObject().changesList;
                    // update source with new values, done loading
                    this._data.next(values);

@@ -118,12 +116,11 @@ export class ChangesComponent implements OnInit {
                        this._done.next(true);
                    }
                }),
-                catchError(err => {
+                catchError(_ => {
                    this._loading.next(false);
                    this.bottom = true;
                    return of([]);
                }),
-                take(1),
            ).subscribe();
        }
    }
@@ -25,7 +25,6 @@

  .add-line-btn {
    margin-bottom: 1rem;
-    border-radius: .5rem;
  }
 }

@@ -55,7 +54,6 @@
  margin-top: 3rem;
  display: block;
  padding: .5rem 4rem;
-  border-radius: .5rem;

  @media only screen and (max-width: 450px) {
    margin-top: 1rem;
@@ -16,7 +16,7 @@
            *ngIf="selection.hasValue() && serviceType!=PolicyComponentServiceType.MGMT" [disabled]="disabled">
            <i class="las la-trash"></i>
        </button>
-        <a class="add-button" [routerLink]="createRouterLink" color="primary" mat-raised-button [disabled]="disabled"
+        <a [routerLink]="createRouterLink" color="primary" mat-raised-button [disabled]="disabled"
            *ngIf="serviceType!=PolicyComponentServiceType.MGMT">
            <mat-icon class="icon">add</mat-icon>{{ 'ACTIONS.NEW' | translate }}
        </a>
@@ -85,14 +85,14 @@


            <tr mat-header-row *matHeaderRowDef="displayedColumns"></tr>
-            <tr class="data-row"
+            <tr class="highlight"
                [ngClass]="{'disabled': serviceType==PolicyComponentServiceType.MGMT && row?.providerType == IdpProviderType.IDPPROVIDERTYPE_SYSTEM}"
                mat-row *matRowDef="let row; columns: displayedColumns;"
                [routerLink]="serviceType==PolicyComponentServiceType.ADMIN ? routerLinkForRow(row): null">
            </tr>

        </table>
-        <mat-paginator #paginator class="paginator" [length]="idpResult?.totalResult || 0" [pageSize]="10"
-            [pageSizeOptions]="[5, 10, 20]" (page)="changePage($event)"></mat-paginator>
    </div>
+    <mat-paginator #paginator class="paginator" [length]="idpResult?.totalResult || 0" [pageSize]="10"
+        [pageSizeOptions]="[5, 10, 20]" (page)="changePage($event)"></mat-paginator>
 </app-refresh-table>
@@ -19,14 +19,6 @@
        padding-right: 0;
      }
    }
-
-    .data-row {
-      cursor: pointer;
-
-      &:hover {
-        background-color: #ffffff05;
-      }
-    }
  }
 }

@@ -38,10 +30,6 @@ tr {
  }
 }

-.add-button {
-  border-radius: .5rem;
-}
-
 .avatar {
  height: 30px;
  width: 30px;
@@ -33,7 +33,6 @@
  margin-bottom: 4rem;
  display: block;
  padding: .5rem 4rem;
-  border-radius: .5rem;

  @media only screen and (max-width: 450px) {
    margin-top: 1rem;
@@ -18,8 +18,4 @@
  .ok-button {
    margin-left: .5rem;
  }
-
-  button {
-    border-radius: .5rem;
-  }
 }
@@ -1,5 +1,5 @@
 <app-detail-layout [backRouterLink]="backroutes" [title]="'ORG.POLICY.LOGIN_POLICY.TITLECREATE' | translate"
-    [description]="serviceType==PolicyComponentServiceType.MGMT ? 'ORG.POLICY.LOGIN_POLICY.DESCRIPTIONCREATEMGMT' : PolicyComponentServiceType.ADMIN ? 'ORG.POLICY.LOGIN_POLICY.DESCRIPTIONCREATEADMIN' : '' | translate">
+    [description]="(serviceType==PolicyComponentServiceType.MGMT ? 'ORG.POLICY.LOGIN_POLICY.DESCRIPTIONCREATEMGMT' : PolicyComponentServiceType.ADMIN ? 'ORG.POLICY.LOGIN_POLICY.DESCRIPTIONCREATEADMIN' : '') | translate">
    <ng-container *ngIf="(['policy.delete'] | hasRole | async) && serviceType == PolicyComponentServiceType.MGMT">
        <!--<button matTooltip="{{'ORG.POLICY.DELETE' | translate}}" color="warn" (click)="deletePolicy()"
            mat-stroked-button>
@@ -1,8 +1,3 @@
-
-button {
-  border-radius: .5rem;
-}
-
 .content {
  padding-top: 1rem;
  display: flex;
@@ -39,7 +34,6 @@ button {
    margin-top: 3rem;
    display: block;
    padding: .5rem 4rem;
-    border-radius: .5rem;
  }
 }

@@ -11,11 +11,11 @@ import {
    IdpView as AdminIdpView,
 } from 'src/app/proto/generated/admin_pb';
 import {
-  IdpProviderType,
-  IdpProviderView as MgmtIdpProviderView,
-  IdpView as MgmtIdpView,
-  LoginPolicy,
-  LoginPolicyView, OrgDomainView,
+    IdpProviderType,
+    IdpProviderView as MgmtIdpProviderView,
+    IdpView as MgmtIdpView,
+    LoginPolicy,
+    LoginPolicyView,
 } from 'src/app/proto/generated/management_pb';
 import { AdminService } from 'src/app/services/admin.service';
 import { ManagementService } from 'src/app/services/mgmt.service';
@@ -151,7 +151,9 @@ export class LoginPolicyComponent implements OnDestroy {

        dialogRef.afterClosed().subscribe(resp => {
            if (resp && resp.idp && resp.type) {
-                this.addIdp(resp.idp, resp.type);
+                this.addIdp(resp.idp, resp.type).then(() => {
+                    this.getData();
+                });
            }
        });
    }
@@ -177,15 +179,15 @@ export class LoginPolicyComponent implements OnDestroy {
        }
    }

-  public get backroutes(): string[] {
-    switch (this.serviceType) {
-      case PolicyComponentServiceType.MGMT:
-        return  ['/org'];
-      case PolicyComponentServiceType.ADMIN:
-        return  ['/iam'];
-        break;
+    public get backroutes(): string[] {
+        switch (this.serviceType) {
+            case PolicyComponentServiceType.MGMT:
+                return ['/org'];
+            case PolicyComponentServiceType.ADMIN:
+                return ['/iam'];
+                break;
+        }
+        return [];
    }
-    return [];
-  }

 }
@@ -1,8 +1,3 @@
-
-button {
-  border-radius: .5rem;
-}
-
 .content {
  padding-top: 1rem;
  display: flex;
@@ -39,6 +34,5 @@ button {
    margin-top: 3rem;
    display: block;
    padding: .5rem 4rem;
-    border-radius: .5rem;
  }
 }
@@ -1,8 +1,3 @@
-
-button {
-  border-radius: .5rem;
-}
-
 .content {
  padding-top: 1rem;
  display: flex;
@@ -39,6 +34,5 @@ button {
    margin-top: 3rem;
    display: block;
    padding: .5rem 4rem;
-    border-radius: .5rem;
  }
 }
@@ -1,8 +1,3 @@
-
-button {
-  border-radius: .5rem;
-}
-
 .content {
  padding-top: 1rem;
  display: flex;
@@ -39,6 +34,5 @@ button {
    margin-top: 3rem;
    display: block;
    padding: .5rem 4rem;
-    border-radius: .5rem;
  }
 }
@@ -1,8 +1,4 @@

-button {
-  border-radius: .5rem;
-}
-
 .content {
  padding-top: 1rem;
  display: flex;
@@ -39,6 +35,5 @@ button {
    margin-top: 3rem;
    display: block;
    padding: .5rem 4rem;
-    border-radius: .5rem;
  }
 }
@@ -13,8 +13,7 @@
        </ng-template>
        <ng-template appHasRole actions
            [appHasRole]="['project.member.write:'+project.projectId,'project.member.write']">
-            <a color="primary" [disabled]="disabled" class="add-button" (click)="openAddMember()" color="primary"
-                mat-raised-button>
+            <a color="primary" [disabled]="disabled" (click)="openAddMember()" color="primary" mat-raised-button>
                <mat-icon class="icon">add</mat-icon>{{ 'ACTIONS.NEW' | translate }}
            </a>
        </ng-template>
@@ -84,7 +83,7 @@
                </ng-container>

                <tr mat-header-row *matHeaderRowDef="displayedColumns"></tr>
-                <tr class="data-row" mat-row *matRowDef="let row; columns: displayedColumns;">
+                <tr class="highlight" mat-row *matRowDef="let row; columns: displayedColumns;">
                </tr>
            </table>

@@ -2,10 +2,6 @@
  margin-right: .5rem;
 }

-.add-button {
-  border-radius: .5rem;
-}
-
 .table-wrapper {
  overflow-x: auto;

@@ -31,12 +27,6 @@
      width: 40px;
    }

-    .data-row {
-      &:hover {
-        background-color: #ffffff05;
-      }
-    }
-
    .selection {
      width: 50px;
      max-width: 50px;
@@ -19,8 +19,4 @@
  .ok-button {
    margin-left: .5rem;
  }
-
-  button {
-    border-radius: .5rem;
-  }
 }
@@ -9,8 +9,8 @@
        </button>
    </ng-template>
    <ng-template appHasRole [appHasRole]="['project.role.write:' + projectId, 'project.role.write']" actions>
-        <a *ngIf="actionsVisible" [disabled]="disabled" class="rounded-button"
-            [routerLink]="[ '/projects', projectId, 'roles', 'create']" color="primary" mat-raised-button>
+        <a *ngIf="actionsVisible" [disabled]="disabled" [routerLink]="[ '/projects', projectId, 'roles', 'create']"
+            color="primary" mat-raised-button>
            <mat-icon class="icon">add</mat-icon>{{ 'ACTIONS.NEW' | translate }}
        </a>
    </ng-template>
@@ -57,7 +57,7 @@
            </ng-container>

            <tr mat-header-row *matHeaderRowDef="displayedColumns"></tr>
-            <tr mat-row *matRowDef="let row; columns: displayedColumns;"></tr>
+            <tr class="highlight" mat-row *matRowDef="let row; columns: displayedColumns;"></tr>
        </table>

        <mat-paginator #paginator [length]="dataSource.totalResult" [pageSize]="50"
@@ -1,8 +1,3 @@
-
-.rounded-button {
-  border-radius: .5rem;
-}
-
 .icon-button {
  margin-right: .5rem;
 }
@@ -31,12 +26,6 @@
      width: 40px;
    }

-    .data-row {
-      &:hover {
-        background-color: #ffffff05;
-      }
-    }
-
    .selection {
      width: 50px;
      max-width: 50px;
@@ -13,9 +13,12 @@
    </div>
    <span class="fill-space"></span>
    <mat-spinner class="spinner" *ngIf="loading" diameter="20"></mat-spinner>
+    <ng-content select="[actions]"></ng-content>
+
    <button mat-icon-button (click)="emitRefresh()" class="icon-button" matTooltip="{{'ACTIONS.REFRESH' | translate}}">
        <mat-icon>refresh</mat-icon>
    </button>
-    <ng-content select="[actions]"></ng-content>
 </div>
-<ng-content></ng-content>
+<div class="table-wrapper">
+    <ng-content></ng-content>
+</div>
@@ -30,3 +30,8 @@
    margin-right: .5rem;
  }
 }
+
+.table-wrapper {
+  width: 100%;
+  overflow-x: auto;
+}
@@ -6,7 +6,7 @@
        <i class="las la-trash"></i>
    </button>
    <a *ngIf="allowCreate && context !== UserGrantContext.USER" matTooltip="{{'GRANTS.ADD' | translate}}" actions
-        color="primary" class="add-button" color="primary" mat-raised-button [routerLink]="routerLink">
+        color="primary" color="primary" mat-raised-button [routerLink]="routerLink">
        <mat-icon class="icon">add</mat-icon>{{ 'GRANTS.ADD_BTN' | translate }}
    </a>

@@ -106,7 +106,7 @@
            </ng-container>

            <tr mat-header-row *matHeaderRowDef="displayedColumns"></tr>
-            <tr mat-row *matRowDef="let row; columns: displayedColumns;" class="element-row">
+            <tr class="highlight" mat-row *matRowDef="let row; columns: displayedColumns;">
            </tr>
        </table>

@@ -1,8 +1,3 @@
-
-.add-button {
-  border-radius: .5rem;
-}
-
 .table-wrapper {
  overflow: auto;

@@ -18,8 +18,4 @@
  .fill-space {
    flex: 1;
  }
-
-  button {
-    border-radius: .5rem;
-  }
 }