mirror of
https://github.com/andwati/zitadel.git
synced 2026-11-17 10:55:12 +00:00
fix(projections): overhaul the event projection system (#10560)
This PR overhauls our event projection system to make it more robust and prevent skipped events under high load. The core change replaces our custom, transaction-based locking with standard PostgreSQL advisory locks. We also introduce a worker pool to manage concurrency and prevent database connection exhaustion. ### Key Changes * **Advisory Locks for Projections:** Replaces exclusive row locks and inspection of `pg_stat_activity` with PostgreSQL advisory locks for managing projection state. This is a more reliable and standard approach to distributed locking. * **Simplified Await Logic:** Removes the complex logic for awaiting open transactions, simplifying it to a more straightforward time-based filtering of events. * **Projection Worker Pool:** Implements a worker pool to limit concurrent projection triggers, preventing connection exhaustion and improving stability under load. A new `MaxParallelTriggers` configuration option is introduced. ### Problem Solved Under high throughput, a race condition could cause projections to miss events from the eventstore. This led to inconsistent data in projection tables (e.g., a user grant might be missing). This PR fixes the underlying locking and concurrency issues to ensure all events are processed reliably. ### How it Works 1. **Event Writing:** When writing events, a *shared* advisory lock is taken. This signals that a write is in progress. 2. **Event Handling (Projections):** * A projection worker attempts to acquire an *exclusive* advisory lock for that specific projection. If the lock is already held, it means another worker is on the job, so the current one backs off. * Once the lock is acquired, the worker briefly acquires and releases the same *shared* lock used by event writers. This acts as a barrier, ensuring it waits for any in-flight writes to complete. * Finally, it processes all events that occurred before its transaction began. ### Additional Information * ZITADEL no longer modifies the `application_name` PostgreSQL variable during event writes. * The lock on the `current_states` table is now `FOR NO KEY UPDATE`. * Fixes https://github.com/zitadel/zitadel/issues/8509 --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Tim Möhlmann <[email protected]>
This commit is contained in:
co-authored by
Copilot
Tim Möhlmann
parent
bdefd9147f
commit
0575f67e94
+18
-8
@@ -17,16 +17,16 @@ The use cases under tests are defined in `src/use_cases`. The implementation of
|
||||
|
||||
### Env vars
|
||||
|
||||
- `VUS`: Amount of parallel processes execute the test (default is 20)
|
||||
- `DURATION`: Defines how long the tests are executed (default is `200s`)
|
||||
- `ZITADEL_HOST`: URL of ZITADEL (default is `http://localhost:8080`)
|
||||
- `ADMIN_LOGIN_NAME`: Loginanme of a human user with `IAM_OWNER`-role
|
||||
- `ADMIN_PASSWORD`: password of the human user
|
||||
* `VUS`: Amount of parallel processes execute the test (default is 20)
|
||||
* `DURATION`: Defines how long the tests are executed (default is `200s`)
|
||||
* `ZITADEL_HOST`: URL of ZITADEL (default is `http://localhost:8080`)
|
||||
* `ADMIN_LOGIN_NAME`: Loginanme of a human user with `IAM_OWNER`-role
|
||||
* `ADMIN_PASSWORD`: password of the human user
|
||||
|
||||
To setup the tests we use the credentials of console and log in using an admin. The user must be able to create organizations and all resources inside organizations.
|
||||
|
||||
- `ADMIN_LOGIN_NAME`: `[email protected]`
|
||||
- `ADMIN_PASSWORD`: `Password1!`
|
||||
* `ADMIN_LOGIN_NAME`: `[email protected]`
|
||||
* `ADMIN_PASSWORD`: `Password1!`
|
||||
|
||||
### Test
|
||||
|
||||
@@ -66,4 +66,14 @@ Before you run the tests you need an initialized user. The tests don't implement
|
||||
test: creates a token and calls user info
|
||||
* `make machine_jwt_profile_grant_single_user`
|
||||
setup: generates private/public key, creates machine user, adds a key
|
||||
test: creates a token and calls user info in parallel for the same user
|
||||
test: creates a token and calls user info in parallel for the same user
|
||||
* `make users_by_metadata_key`
|
||||
setup: creates for half of the VUS a human user and a machine for the other half, adds 3 metadata to each user
|
||||
test: calls the list users endpoint and filters by a metadata key
|
||||
* `make users_by_metadata_value`
|
||||
setup: creates for half of the VUS a human user and a machine for the other half, adds 3 metadata to each user
|
||||
test: calls the list users endpoint and filters by a metadata value
|
||||
* `make verify_all_user_grants_exists`
|
||||
setup: creates 50 projects, 1 machine per VU
|
||||
test: creates a machine and grants all projects to the machine
|
||||
teardown: the organization is not removed to verify the data of the projections are correct. You can find additional information [at the bottom of this file](./src/use_cases/verify_all_user_grants_exist.ts)
|
||||
|
||||
Reference in New Issue
Block a user