From 192b4ce7ffc056df6330ecfe2034d3956540c6d6 Mon Sep 17 00:00:00 2001 From: nutcas3 Date: Sun, 3 May 2026 09:49:37 +0300 Subject: [PATCH] feat: Refactor step status checking from if-else to switch statement in GetStepSuccessRate - Replace if-else chain with switch statement for step.Status evaluation in monitor.go - Maintain completed and failed case handling with cleaner control flow --- apps/carrier-connector/internal/mvno/monitor.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/apps/carrier-connector/internal/mvno/monitor.go b/apps/carrier-connector/internal/mvno/monitor.go index 9b58deb..564d28f 100644 --- a/apps/carrier-connector/internal/mvno/monitor.go +++ b/apps/carrier-connector/internal/mvno/monitor.go @@ -121,9 +121,10 @@ func (m *OnboardingMonitor) GetStepSuccessRate() map[string]float64 { stepStats[step.Name] = map[string]int{"completed": 0, "failed": 0, "total": 0} } stepStats[step.Name]["total"]++ - if step.Status == "completed" { + switch step.Status { +case "completed": stepStats[step.Name]["completed"]++ - } else if step.Status == "failed" { + case "failed": stepStats[step.Name]["failed"]++ } }