andwati/dokploy
1
0
Fork 0
mirror of https://github.com/andwati/dokploy.git synced 2026-11-03 18:52:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(gitlab): handle missing expires_in in OAuth token response

Browse Source 
Some self-hosted GitLab instances (e.g. older versions without
expires_in configured in doorkeeper) omit expires_in from the
OAuth token response. Computing Date.now()/1000 + undefined
produced NaN, which Postgres rejected on the expires_at integer
column, crashing both the initial OAuth callback and the token
refresh flow with a 500.

Falls back to null when expires_in is absent, matching the
existing Gitea callback behavior.

Closes #4362
This commit is contained in:
Mauricio Siu
2026-08-13 14:41:10 -06:00
parent 1183c7c4a9
commit fc5b8d03e5
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/dokploy/pages/api/providers/gitlab/callback.ts
+3 -1
View File
@@ -53,7 +53,9 @@ export default async function handler(
return res.status(400).json({ error: "Missing or invalid code" }); return res.status(400).json({ error: "Missing or invalid code" });
} }
const expiresAt = Math.floor(Date.now() / 1000) + result.expires_in; const expiresAt = result.expires_in
? Math.floor(Date.now() / 1000) + result.expires_in
: null;
await updateGitlab(gitlab.gitlabId, { await updateGitlab(gitlab.gitlabId, {
accessToken: result.access_token, accessToken: result.access_token,
refreshToken: result.refresh_token, refreshToken: result.refresh_token,
packages/server/src/utils/providers/gitlab.ts
+3 -1
View File
@@ -44,7 +44,9 @@ export const refreshGitlabToken = async (gitlabProviderId: string) => {
const data = await response.json(); const data = await response.json();
const expiresAt = Math.floor(Date.now() / 1000) + data.expires_in; const expiresAt = data.expires_in
? Math.floor(Date.now() / 1000) + data.expires_in
: null;
await updateGitlab(gitlabProviderId, { await updateGitlab(gitlabProviderId, {
accessToken: data.access_token, accessToken: data.access_token,