fix(schedule): return deployment metadata from runManually and fail early on missing container

apps/dokploy/components/dashboard/application/schedules/show-schedules.tsx

@@ -58,8 +58,12 @@ export const ShowSchedules = ({ id, scheduleType = "application" }: Props) => {
 	const handleRunManually = async (scheduleId: string) => {
 		setRunningSchedules((prev) => new Set(prev).add(scheduleId));
 		try {
-			await runManually({ scheduleId });
+			const result = await runManually({ scheduleId });
+			if (result.status === "error") {
+				toast.error("Schedule run failed, check the deployment logs");
+			} else {
 				toast.success("Schedule run successfully");
+			}
 			await refetchSchedules();
 		} catch {
 			toast.error("Error running schedule");

apps/dokploy/server/api/routers/schedule.ts

@@ -329,13 +329,17 @@ export const scheduleRouter = createTRPCRouter({
 				await checkPermission(ctx, { schedule: ["create"] });
 			}
 			try {
-				await runCommand(input.scheduleId);
+				const deployment = await runCommand(input.scheduleId);
 				await audit(ctx, {
 					action: "run",
 					resourceType: "schedule",
 					resourceId: input.scheduleId,
 				});
-				return true;
+				return {
+					status: deployment.status,
+					deploymentId: deployment.deploymentId,
+					logPath: deployment.logPath,
+				};
 			} catch (error) {
 				throw new TRPCError({
 					code: "INTERNAL_SERVER_ERROR",

packages/server/src/utils/schedules/utils.ts

@@ -55,6 +55,7 @@ export const runCommand = async (scheduleId: string) => {
 		description: "Schedule",
 	});
 
+	try {
 		if (scheduleType === "application" || scheduleType === "compose") {
 			let containerId = "";
 			let serverId = "";
@@ -72,8 +73,28 @@ export const runCommand = async (scheduleId: string) => {
 				serverId = compose.serverId || "";
 			}
 
+			if (!containerId) {
+				const target =
+					scheduleType === "compose"
+						? `service '${serviceName}' of compose '${compose?.name}'`
+						: `application '${application?.appName}'`;
+				const message = `Container not found for ${target}, make sure the service is running`;
+				if (serverId) {
+					await execAsyncRemote(
+						serverId,
+						`echo ${quote([`❌ ${message}`])} >> ${quote([deployment.logPath])}`,
+					);
+				} else {
+					const writeStream = createWriteStream(deployment.logPath, {
+						flags: "a",
+					});
+					writeStream.write(`❌ ${message}\n`);
+					writeStream.end();
+				}
+				throw new Error(message);
+			}
+
 			if (serverId) {
-			try {
 				await execAsyncRemote(
 					serverId,
 					`
@@ -86,12 +107,10 @@ export const runCommand = async (scheduleId: string) => {
 					echo "✅ Command executed successfully" >> ${quote([deployment.logPath])};
 					`,
 				);
-			} catch (error) {
-				await updateDeploymentStatus(deployment.deploymentId, "error");
-				throw error;
-			}
 			} else {
-			const writeStream = createWriteStream(deployment.logPath, { flags: "a" });
+				const writeStream = createWriteStream(deployment.logPath, {
+					flags: "a",
+				});
 
 				try {
 					if (IS_CLOUD) {
@@ -99,7 +118,7 @@ export const runCommand = async (scheduleId: string) => {
 							"This feature is not available in the cloud version.",
 						);
 						writeStream.end();
-					return;
+						return { ...deployment, status: "running" as const };
 					}
 					writeStream.write(
 						`docker exec ${containerId} ${shellType} -c ${command}\n`,
@@ -115,18 +134,17 @@ export const runCommand = async (scheduleId: string) => {
 					);
 
 					writeStream.write("✅ Command executed successfully\n");
+					writeStream.end();
 				} catch (error) {
 					writeStream.write("❌ Command failed\n");
 					writeStream.write(
 						error instanceof Error ? error.message : "Unknown error",
 					);
 					writeStream.end();
-				await updateDeploymentStatus(deployment.deploymentId, "error");
 					throw error;
 				}
 			}
 		} else if (scheduleType === "dokploy-server") {
-		try {
 			const writeStream = createWriteStream(deployment.logPath, { flags: "a" });
 			const { SCHEDULES_PATH } = paths();
 			const fullPath = path.join(SCHEDULES_PATH, appName || "");
@@ -151,12 +169,7 @@ export const runCommand = async (scheduleId: string) => {
 					cwd: fullPath,
 				},
 			);
-		} catch (error) {
-			await updateDeploymentStatus(deployment.deploymentId, "error");
-			throw error;
-		}
 		} else if (scheduleType === "server") {
-		try {
 			const { SCHEDULES_PATH } = paths(true);
 			const fullPath = path.join(SCHEDULES_PATH, appName || "");
 			const command = `
@@ -177,10 +190,11 @@ export const runCommand = async (scheduleId: string) => {
 					});
 				}
 			});
-		} catch (error) {
-			await updateDeploymentStatus(deployment.deploymentId, "error");
-			throw error;
-		}
 		}
 		await updateDeploymentStatus(deployment.deploymentId, "done");
+		return { ...deployment, status: "done" as const };
+	} catch {
+		await updateDeploymentStatus(deployment.deploymentId, "error");
+		return { ...deployment, status: "error" as const };
+	}
 };