andwati/dokploy
1
0
Fork 0
mirror of https://github.com/andwati/dokploy.git synced 2026-11-03 18:52:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(volume-backups): preserve backup failure status

Browse Source
This commit is contained in:
Aditya Nandlal
2026-08-14 12:51:28 +00:00
parent 2598a62771
commit c6ab76fe09
2 changed files with 44 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/dokploy/__test__/backups/volume-backup-restart.test.ts
+33
View File
@@ -28,6 +28,39 @@ describe("createRestartSafeBackupCommand", () => {
expect(outputLines(result.stdout)).toEqual(["stop", "backup", "start"]);
});
it("preserves the backup error status when the restart also fails", () => {
const result = runCommand(
createRestartSafeBackupCommand({
stopCommand: 'echo "stop"',
backupCommand: 'echo "backup"; exit 23',
startCommand: 'echo "start"; exit 17',
uploadCommand: 'echo "upload"',
}),
);
expect(result.status).toBe(23);
expect(outputLines(result.stdout)).toEqual([
"stop",
"backup",
"start",
"Service restart also failed with exit code 17",
]);
});
it("returns the restart error status when the backup succeeds", () => {
const result = runCommand(
createRestartSafeBackupCommand({
stopCommand: 'echo "stop"',
backupCommand: 'echo "backup"',
startCommand: 'echo "start"; exit 17',
uploadCommand: 'echo "upload"',
}),
);
expect(result.status).toBe(17);
expect(outputLines(result.stdout)).toEqual(["stop", "backup", "start"]);
});
it("uploads only after a successful backup and service restart", () => {
const result = runCommand(
createRestartSafeBackupCommand({