fix: address PR review feedback

- Use "kill" audit action for killContainer instead of "stop"
- Pass undefined instead of empty string for optional serverId
This commit is contained in:
Mauricio Siu
2026-04-13 20:34:06 -06:00
parent 89737e7b65
commit a48306a2c6
2 changed files with 2 additions and 2 deletions
@@ -307,7 +307,7 @@ const Service = (
<TabsContent value="containers"> <TabsContent value="containers">
<div className="flex flex-col gap-4 pt-2.5"> <div className="flex flex-col gap-4 pt-2.5">
<ShowComposeContainers <ShowComposeContainers
serverId={data?.serverId || ""} serverId={data?.serverId || undefined}
appName={data?.appName || ""} appName={data?.appName || ""}
appType={data?.composeType || "docker-compose"} appType={data?.composeType || "docker-compose"}
/> />
+1 -1
View File
@@ -135,7 +135,7 @@ export const dockerRouter = createTRPCRouter({
} }
await containerKill(input.containerId, input.serverId); await containerKill(input.containerId, input.serverId);
await audit(ctx, { await audit(ctx, {
action: "stop", action: "kill",
resourceType: "docker", resourceType: "docker",
resourceId: input.containerId, resourceId: input.containerId,
resourceName: input.containerId, resourceName: input.containerId,