andwati/dokploy
1
0
Fork 0
mirror of https://github.com/andwati/dokploy.git synced 2026-11-11 06:25:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: enhance DockerTerminalModal component for better prop handling

Browse Source 
- Removed unnecessary conditional check for containerId in the main dialog open handler.
- Updated Terminal component to ensure serverId and containerId have default values, improving robustness and user experience.
This commit is contained in:
Mauricio Siu
2025-10-05 00:47:50 -06:00
parent c8320da716
commit 586195b5c8
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/dokploy/components/dashboard/settings/web-server/docker-terminal-modal.tsx
+5 -5
View File
@@ -64,10 +64,6 @@ export const DockerTerminalModal = ({
const [confirmDialogOpen, setConfirmDialogOpen] = useState(false); const [confirmDialogOpen, setConfirmDialogOpen] = useState(false);
const handleMainDialogOpenChange = (open: boolean) => { const handleMainDialogOpenChange = (open: boolean) => {
if (!open && !containerId) {
setMainDialogOpen(false);
return;
}
if (!open) { if (!open) {
setConfirmDialogOpen(true); setConfirmDialogOpen(true);
} else { } else {
@@ -131,7 +127,11 @@ export const DockerTerminalModal = ({
</SelectGroup> </SelectGroup>
</SelectContent> </SelectContent>
</Select> </Select>
<Terminal serverId={serverId} id="terminal" containerId={containerId} /> <Terminal
serverId={serverId || ""}
id="terminal"
containerId={containerId || "select-a-container"}
/>
<Dialog open={confirmDialogOpen} onOpenChange={setConfirmDialogOpen}> <Dialog open={confirmDialogOpen} onOpenChange={setConfirmDialogOpen}>
<DialogContent onEscapeKeyDown={(event) => event.preventDefault()}> <DialogContent onEscapeKeyDown={(event) => event.preventDefault()}>
<DialogHeader> <DialogHeader>