andwati/dokploy
1
0
Fork 0
mirror of https://github.com/andwati/dokploy.git synced 2026-11-15 00:15:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent removal of current directory in deployment logs

Browse Source 
- Updated the removeLastTenDeployments function to check if logPath is not the current directory before executing the removal command.
- Enhanced the unlink operation to ensure it only attempts to delete valid log paths.
This commit is contained in:
Mauricio Siu
2025-07-01 23:17:27 -06:00
parent 03e04b7bce
commit 2f6f1b19e7
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/server/src/services/deployment.ts
+10 -4
View File
@@ -538,9 +538,11 @@ const removeLastTenDeployments = async (
await removeRollbackById(oldDeployment.rollbackId); await removeRollbackById(oldDeployment.rollbackId);
} }
command += ` if (logPath !== ".") {
rm -rf ${logPath}; command += `
`; rm -rf ${logPath};
`;
}
await removeDeployment(oldDeployment.deploymentId); await removeDeployment(oldDeployment.deploymentId);
} }
@@ -551,7 +553,11 @@ const removeLastTenDeployments = async (
await removeRollbackById(oldDeployment.rollbackId); await removeRollbackById(oldDeployment.rollbackId);
} }
const logPath = path.join(oldDeployment.logPath); const logPath = path.join(oldDeployment.logPath);
if (existsSync(logPath) && !oldDeployment.errorMessage) { if (
existsSync(logPath) &&
!oldDeployment.errorMessage &&
logPath !== "."
) {
await fsPromises.unlink(logPath); await fsPromises.unlink(logPath);
} }
await removeDeployment(oldDeployment.deploymentId); await removeDeployment(oldDeployment.deploymentId);