Merge pull request #3107 from Dokploy/2883-s3-destinations-test-connection-fails-to-quote-region

fix: update rclone S3 flags to use quotes for improved parsing
This commit is contained in:
Mauricio Siu
2025-11-26 02:04:38 -05:00
committed by GitHub
@@ -47,10 +47,10 @@ export const destinationRouter = createTRPCRouter({
input; input;
try { try {
const rcloneFlags = [ const rcloneFlags = [
`--s3-access-key-id=${accessKey}`, `--s3-access-key-id="${accessKey}"`,
`--s3-secret-access-key=${secretAccessKey}`, `--s3-secret-access-key="${secretAccessKey}"`,
`--s3-region=${region}`, `--s3-region="${region}"`,
`--s3-endpoint=${endpoint}`, `--s3-endpoint="${endpoint}"`,
"--s3-no-check-bucket", "--s3-no-check-bucket",
"--s3-force-path-style", "--s3-force-path-style",
"--retries 1", "--retries 1",
@@ -59,7 +59,7 @@ export const destinationRouter = createTRPCRouter({
"--contimeout 5s", "--contimeout 5s",
]; ];
if (provider) { if (provider) {
rcloneFlags.unshift(`--s3-provider=${provider}`); rcloneFlags.unshift(`--s3-provider="${provider}"`);
} }
const rcloneDestination = `:s3:${bucket}`; const rcloneDestination = `:s3:${bucket}`;
const rcloneCommand = `rclone ls ${rcloneFlags.join(" ")} "${rcloneDestination}"`; const rcloneCommand = `rclone ls ${rcloneFlags.join(" ")} "${rcloneDestination}"`;